From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org, Bin Meng <bmeng.cn@gmail.com>
Cc: "Pragnesh Patel" <pragnesh.patel@sifive.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-block@nongnu.org
Subject: [PATCH v3 3/6] hw/sd: sd: Allow single/multiple block write for SPI mode
Date: Sun, 24 Jan 2021 21:28:14 +0100 [thread overview]
Message-ID: <20210124202817.2624557-4-f4bug@amsat.org> (raw)
In-Reply-To: <20210124202817.2624557-1-f4bug@amsat.org>
From: Bin Meng <bin.meng@windriver.com>
At present the single/multiple block write in SPI mode is blocked
by sd_normal_command(). Remove the limitation.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20210123104016.17485-14-bmeng.cn@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/sd/sd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 09753359bb2..946036d87cb 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -1230,9 +1230,6 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)
case 25: /* CMD25: WRITE_MULTIPLE_BLOCK */
switch (sd->state) {
case sd_transfer_state:
- /* Writing in SPI mode not implemented. */
- if (sd->spi)
- break;
if (addr + sd->blk_len > sd->size) {
sd->card_status |= ADDRESS_ERROR;
--
2.26.2
next prev parent reply other threads:[~2021-01-24 20:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-24 20:28 [PATCH v3 0/6] hw/sd: Support block write in SPI mode Philippe Mathieu-Daudé
2021-01-24 20:28 ` [PATCH v3 1/6] hw/sd: ssi-sd: Support multiple block read Philippe Mathieu-Daudé
2021-01-24 20:28 ` [PATCH v3 2/6] hw/sd: sd: Remove duplicated codes in single/multiple block read/write Philippe Mathieu-Daudé
2021-01-24 20:28 ` Philippe Mathieu-Daudé [this message]
2021-01-24 20:28 ` [PATCH v3 4/6] hw/sd: Introduce receive_ready() callback Philippe Mathieu-Daudé
2021-01-24 20:28 ` [PATCH v3 5/6] hw/sd: ssi-sd: Support single block write Philippe Mathieu-Daudé
2021-01-24 20:28 ` [PATCH v3 6/6] hw/sd: ssi-sd: Support multiple " Philippe Mathieu-Daudé
2021-01-25 3:21 ` [PATCH v3 0/6] hw/sd: Support block write in SPI mode Bin Meng
2021-01-25 8:38 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210124202817.2624557-4-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=bmeng.cn@gmail.com \
--cc=pragnesh.patel@sifive.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.