From: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
To: linux-mips@vger.kernel.org
Cc: tsbogend@alpha.franken.de, axboe@kernel.dk,
linux-block@vger.kernel.org, cand@gmx.com,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: [PATCH 4/9] n64: use enums for reg
Date: Mon, 25 Jan 2021 15:32:38 -0800 [thread overview]
Message-ID: <20210125233243.5982-5-chaitanya.kulkarni@wdc.com> (raw)
In-Reply-To: <20210125233243.5982-1-chaitanya.kulkarni@wdc.com>
Macros tend to be not type-safe. Use enum for register definitions.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Lauri Kasanen <cand@gmx.com>
---
drivers/block/n64cart.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/block/n64cart.c b/drivers/block/n64cart.c
index b18f034ee1ad..620f9e080d5d 100644
--- a/drivers/block/n64cart.c
+++ b/drivers/block/n64cart.c
@@ -13,11 +13,13 @@
#include <linux/module.h>
#include <linux/platform_device.h>
-#define PI_DRAM_REG 0
-#define PI_CART_REG 1
-#define PI_READ_REG 2
-#define PI_WRITE_REG 3
-#define PI_STATUS_REG 4
+enum {
+ PI_DRAM_REG = 0,
+ PI_CART_REG,
+ PI_READ_REG,
+ PI_WRITE_REG,
+ PI_STATUS_REG,
+};
#define PI_STATUS_DMA_BUSY (1 << 0)
#define PI_STATUS_IO_BUSY (1 << 1)
--
2.22.1
next prev parent reply other threads:[~2021-01-25 23:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 23:32 [PATCH 0/9] n64: small cleanups Chaitanya Kulkarni
2021-01-25 23:32 ` [PATCH 1/9] n64: use pr_fmt to avoid duplicate string Chaitanya Kulkarni
2021-01-25 23:32 ` [PATCH 2/9] n64: move module info at the end Chaitanya Kulkarni
2021-01-25 23:32 ` [PATCH 3/9] n64: move module param at the top Chaitanya Kulkarni
2021-01-25 23:32 ` Chaitanya Kulkarni [this message]
2021-01-25 23:32 ` [PATCH 5/9] n64: use sector SECTOR_SHIFT instead 512 Chaitanya Kulkarni
2021-01-25 23:32 ` [PATCH 6/9] n64: remove curly brackets Chaitanya Kulkarni
2021-01-25 23:32 ` [PATCH 7/9] n64: cosmetics changes Chaitanya Kulkarni
2021-01-26 8:53 ` Sergei Shtylyov
2021-01-25 23:32 ` [PATCH 8/9] n64: cleanup n64cart_probe() Chaitanya Kulkarni
2021-01-25 23:32 ` [PATCH 9/9] n64: store dev instance into disk private data Chaitanya Kulkarni
2021-01-26 8:00 ` [PATCH 0/9] n64: small cleanups Lauri Kasanen
2021-02-21 22:39 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125233243.5982-5-chaitanya.kulkarni@wdc.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=cand@gmx.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.