From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
Dave Airlie <airlied@gmail.com>,
greg.depoire@gmail.com, Ben Skeggs <bskeggs@redhat.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org (open list)
Subject: [RFC v2 1/5] drm/nouveau/kms/nv40-/backlight: Assign prop type once
Date: Mon, 25 Jan 2021 19:10:27 -0500 [thread overview]
Message-ID: <20210126001031.881048-2-lyude@redhat.com> (raw)
In-Reply-To: <20210126001031.881048-1-lyude@redhat.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Dave Airlie <airlied@gmail.com>
Cc: greg.depoire@gmail.com
---
drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c
index 72f35a2babcb..42b498e7e2bf 100644
--- a/drivers/gpu/drm/nouveau/nouveau_backlight.c
+++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c
@@ -106,7 +106,6 @@ nv40_backlight_init(struct nouveau_encoder *encoder,
if (!(nvif_rd32(device, NV40_PMC_BACKLIGHT) & NV40_PMC_BACKLIGHT_MASK))
return -ENODEV;
- props->type = BACKLIGHT_RAW;
props->max_brightness = 31;
*ops = &nv40_bl_ops;
return 0;
@@ -212,7 +211,6 @@ nv50_backlight_init(struct nouveau_encoder *nv_encoder,
else
*ops = &nva3_bl_ops;
- props->type = BACKLIGHT_RAW;
props->max_brightness = 100;
return 0;
@@ -226,7 +224,7 @@ nouveau_backlight_init(struct drm_connector *connector)
struct nouveau_encoder *nv_encoder = NULL;
struct nvif_device *device = &drm->client.device;
char backlight_name[BL_NAME_SIZE];
- struct backlight_properties props = {0};
+ struct backlight_properties props = { .type = BACKLIGHT_RAW, 0 };
const struct backlight_ops *ops;
int ret;
--
2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
greg.depoire@gmail.com, Ben Skeggs <bskeggs@redhat.com>
Subject: [RFC v2 1/5] drm/nouveau/kms/nv40-/backlight: Assign prop type once
Date: Mon, 25 Jan 2021 19:10:27 -0500 [thread overview]
Message-ID: <20210126001031.881048-2-lyude@redhat.com> (raw)
In-Reply-To: <20210126001031.881048-1-lyude@redhat.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Dave Airlie <airlied@gmail.com>
Cc: greg.depoire@gmail.com
---
drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c
index 72f35a2babcb..42b498e7e2bf 100644
--- a/drivers/gpu/drm/nouveau/nouveau_backlight.c
+++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c
@@ -106,7 +106,6 @@ nv40_backlight_init(struct nouveau_encoder *encoder,
if (!(nvif_rd32(device, NV40_PMC_BACKLIGHT) & NV40_PMC_BACKLIGHT_MASK))
return -ENODEV;
- props->type = BACKLIGHT_RAW;
props->max_brightness = 31;
*ops = &nv40_bl_ops;
return 0;
@@ -212,7 +211,6 @@ nv50_backlight_init(struct nouveau_encoder *nv_encoder,
else
*ops = &nva3_bl_ops;
- props->type = BACKLIGHT_RAW;
props->max_brightness = 100;
return 0;
@@ -226,7 +224,7 @@ nouveau_backlight_init(struct drm_connector *connector)
struct nouveau_encoder *nv_encoder = NULL;
struct nvif_device *device = &drm->client.device;
char backlight_name[BL_NAME_SIZE];
- struct backlight_properties props = {0};
+ struct backlight_properties props = { .type = BACKLIGHT_RAW, 0 };
const struct backlight_ops *ops;
int ret;
--
2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
greg.depoire@gmail.com, Ben Skeggs <bskeggs@redhat.com>
Subject: [RFC v2 1/5] drm/nouveau/kms/nv40-/backlight: Assign prop type once
Date: Mon, 25 Jan 2021 19:10:27 -0500 [thread overview]
Message-ID: <20210126001031.881048-2-lyude@redhat.com> (raw)
In-Reply-To: <20210126001031.881048-1-lyude@redhat.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Dave Airlie <airlied@gmail.com>
Cc: greg.depoire@gmail.com
---
drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c
index 72f35a2babcb..42b498e7e2bf 100644
--- a/drivers/gpu/drm/nouveau/nouveau_backlight.c
+++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c
@@ -106,7 +106,6 @@ nv40_backlight_init(struct nouveau_encoder *encoder,
if (!(nvif_rd32(device, NV40_PMC_BACKLIGHT) & NV40_PMC_BACKLIGHT_MASK))
return -ENODEV;
- props->type = BACKLIGHT_RAW;
props->max_brightness = 31;
*ops = &nv40_bl_ops;
return 0;
@@ -212,7 +211,6 @@ nv50_backlight_init(struct nouveau_encoder *nv_encoder,
else
*ops = &nva3_bl_ops;
- props->type = BACKLIGHT_RAW;
props->max_brightness = 100;
return 0;
@@ -226,7 +224,7 @@ nouveau_backlight_init(struct drm_connector *connector)
struct nouveau_encoder *nv_encoder = NULL;
struct nvif_device *device = &drm->client.device;
char backlight_name[BL_NAME_SIZE];
- struct backlight_properties props = {0};
+ struct backlight_properties props = { .type = BACKLIGHT_RAW, 0 };
const struct backlight_ops *ops;
int ret;
--
2.29.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
greg.depoire@gmail.com, Ben Skeggs <bskeggs@redhat.com>
Subject: [Intel-gfx] [RFC v2 1/5] drm/nouveau/kms/nv40-/backlight: Assign prop type once
Date: Mon, 25 Jan 2021 19:10:27 -0500 [thread overview]
Message-ID: <20210126001031.881048-2-lyude@redhat.com> (raw)
In-Reply-To: <20210126001031.881048-1-lyude@redhat.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Dave Airlie <airlied@gmail.com>
Cc: greg.depoire@gmail.com
---
drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c
index 72f35a2babcb..42b498e7e2bf 100644
--- a/drivers/gpu/drm/nouveau/nouveau_backlight.c
+++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c
@@ -106,7 +106,6 @@ nv40_backlight_init(struct nouveau_encoder *encoder,
if (!(nvif_rd32(device, NV40_PMC_BACKLIGHT) & NV40_PMC_BACKLIGHT_MASK))
return -ENODEV;
- props->type = BACKLIGHT_RAW;
props->max_brightness = 31;
*ops = &nv40_bl_ops;
return 0;
@@ -212,7 +211,6 @@ nv50_backlight_init(struct nouveau_encoder *nv_encoder,
else
*ops = &nva3_bl_ops;
- props->type = BACKLIGHT_RAW;
props->max_brightness = 100;
return 0;
@@ -226,7 +224,7 @@ nouveau_backlight_init(struct drm_connector *connector)
struct nouveau_encoder *nv_encoder = NULL;
struct nvif_device *device = &drm->client.device;
char backlight_name[BL_NAME_SIZE];
- struct backlight_properties props = {0};
+ struct backlight_properties props = { .type = BACKLIGHT_RAW, 0 };
const struct backlight_ops *ops;
int ret;
--
2.29.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-26 1:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 0:10 [RFC v2 0/5] drm: Extract DPCD backlight helpers from i915, add support in nouveau Lyude Paul
2021-01-26 0:10 ` [Intel-gfx] " Lyude Paul
2021-01-26 0:10 ` Lyude Paul
2021-01-26 0:10 ` Lyude Paul [this message]
2021-01-26 0:10 ` [Intel-gfx] [RFC v2 1/5] drm/nouveau/kms/nv40-/backlight: Assign prop type once Lyude Paul
2021-01-26 0:10 ` Lyude Paul
2021-01-26 0:10 ` Lyude Paul
2021-01-26 0:10 ` [RFC v2 2/5] drm/nouveau/kms: Don't probe eDP connectors more then once Lyude Paul
2021-01-26 0:10 ` [Intel-gfx] " Lyude Paul
2021-01-26 0:10 ` Lyude Paul
2021-01-26 0:10 ` Lyude Paul
2021-01-26 0:10 ` [RFC v2 3/5] drm/i915/dp: Remove redundant AUX backlight frequency calculations Lyude Paul
2021-01-26 0:10 ` [Intel-gfx] " Lyude Paul
2021-01-26 0:10 ` Lyude Paul
2021-01-26 0:10 ` Lyude Paul
2021-01-26 0:10 ` [RFC v2 4/5] drm/dp: Extract i915's eDP backlight code into DRM helpers Lyude Paul
2021-01-26 0:10 ` [Intel-gfx] " Lyude Paul
2021-01-26 0:10 ` Lyude Paul
2021-01-26 0:10 ` Lyude Paul
2021-02-03 20:58 ` Rodrigo Vivi
2021-02-03 20:58 ` [Intel-gfx] " Rodrigo Vivi
2021-02-03 20:58 ` Rodrigo Vivi
2021-02-03 20:58 ` [Nouveau] " Rodrigo Vivi
2021-02-03 21:29 ` Lyude Paul
2021-02-03 21:29 ` [Intel-gfx] " Lyude Paul
2021-02-03 21:29 ` Lyude Paul
2021-02-03 21:29 ` [Nouveau] " Lyude Paul
2021-01-26 0:10 ` [RFC v2 5/5] drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau Lyude Paul
2021-01-26 0:10 ` [Intel-gfx] " Lyude Paul
2021-01-26 0:10 ` Lyude Paul
2021-01-26 0:10 ` Lyude Paul
2021-01-26 2:18 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev4) Patchwork
2021-01-26 2:20 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-01-26 2:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-26 8:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126001031.881048-2-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=greg.depoire@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.