From: Dave Hansen <dave.hansen@linux.intel.com> To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Dave Hansen <dave.hansen@linux.intel.com>, yang.shi@linux.alibaba.com, rientjes@google.com, ying.huang@intel.com, dan.j.williams@intel.com, david@redhat.com, osalvador@suse.de Subject: [RFC][PATCH 09/13] mm/vmscan: add page demotion counter Date: Mon, 25 Jan 2021 16:34:29 -0800 [thread overview] Message-ID: <20210126003429.1045A904@viggo.jf.intel.com> (raw) In-Reply-To: <20210126003411.2AC51464@viggo.jf.intel.com> From: Yang Shi <yang.shi@linux.alibaba.com> Account the number of demoted pages into reclaim_state->nr_demoted. Add pgdemote_kswapd and pgdemote_direct VM counters showed in /proc/vmstat. [ daveh: - __count_vm_events() a bit, and made them look at the THP size directly rather than getting data from migrate_pages() ] Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com> Cc: David Rientjes <rientjes@google.com> Cc: Huang Ying <ying.huang@intel.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: David Hildenbrand <david@redhat.com> Cc: osalvador <osalvador@suse.de> -- Changes since 202010: * remove unused scan-control 'demoted' field --- b/include/linux/vm_event_item.h | 2 ++ b/mm/vmscan.c | 5 +++++ b/mm/vmstat.c | 2 ++ 3 files changed, 9 insertions(+) diff -puN include/linux/vm_event_item.h~mm-vmscan-add-page-demotion-counter include/linux/vm_event_item.h --- a/include/linux/vm_event_item.h~mm-vmscan-add-page-demotion-counter 2021-01-25 16:23:15.821866693 -0800 +++ b/include/linux/vm_event_item.h 2021-01-25 16:23:15.831866693 -0800 @@ -33,6 +33,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PS PGREUSE, PGSTEAL_KSWAPD, PGSTEAL_DIRECT, + PGDEMOTE_KSWAPD, + PGDEMOTE_DIRECT, PGSCAN_KSWAPD, PGSCAN_DIRECT, PGSCAN_DIRECT_THROTTLE, diff -puN mm/vmscan.c~mm-vmscan-add-page-demotion-counter mm/vmscan.c --- a/mm/vmscan.c~mm-vmscan-add-page-demotion-counter 2021-01-25 16:23:15.823866693 -0800 +++ b/mm/vmscan.c 2021-01-25 16:23:15.835866693 -0800 @@ -1120,6 +1120,11 @@ static unsigned int demote_page_list(str target_nid, MIGRATE_ASYNC, MR_DEMOTION, &nr_succeeded); + if (current_is_kswapd()) + __count_vm_events(PGDEMOTE_KSWAPD, nr_succeeded); + else + __count_vm_events(PGDEMOTE_DIRECT, nr_succeeded); + return nr_succeeded; } diff -puN mm/vmstat.c~mm-vmscan-add-page-demotion-counter mm/vmstat.c --- a/mm/vmstat.c~mm-vmscan-add-page-demotion-counter 2021-01-25 16:23:15.825866693 -0800 +++ b/mm/vmstat.c 2021-01-25 16:23:15.838866693 -0800 @@ -1244,6 +1244,8 @@ const char * const vmstat_text[] = { "pgreuse", "pgsteal_kswapd", "pgsteal_direct", + "pgdemote_kswapd", + "pgdemote_direct", "pgscan_kswapd", "pgscan_direct", "pgscan_direct_throttle", _
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@linux.intel.com> To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org,Dave Hansen <dave.hansen@linux.intel.com>,yang.shi@linux.alibaba.com,rientjes@google.com,ying.huang@intel.com,dan.j.williams@intel.com,david@redhat.com,osalvador@suse.de Subject: [RFC][PATCH 09/13] mm/vmscan: add page demotion counter Date: Mon, 25 Jan 2021 16:34:29 -0800 [thread overview] Message-ID: <20210126003429.1045A904@viggo.jf.intel.com> (raw) In-Reply-To: <20210126003411.2AC51464@viggo.jf.intel.com> From: Yang Shi <yang.shi@linux.alibaba.com> Account the number of demoted pages into reclaim_state->nr_demoted. Add pgdemote_kswapd and pgdemote_direct VM counters showed in /proc/vmstat. [ daveh: - __count_vm_events() a bit, and made them look at the THP size directly rather than getting data from migrate_pages() ] Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com> Cc: David Rientjes <rientjes@google.com> Cc: Huang Ying <ying.huang@intel.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: David Hildenbrand <david@redhat.com> Cc: osalvador <osalvador@suse.de> -- Changes since 202010: * remove unused scan-control 'demoted' field --- b/include/linux/vm_event_item.h | 2 ++ b/mm/vmscan.c | 5 +++++ b/mm/vmstat.c | 2 ++ 3 files changed, 9 insertions(+) diff -puN include/linux/vm_event_item.h~mm-vmscan-add-page-demotion-counter include/linux/vm_event_item.h --- a/include/linux/vm_event_item.h~mm-vmscan-add-page-demotion-counter 2021-01-25 16:23:15.821866693 -0800 +++ b/include/linux/vm_event_item.h 2021-01-25 16:23:15.831866693 -0800 @@ -33,6 +33,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PS PGREUSE, PGSTEAL_KSWAPD, PGSTEAL_DIRECT, + PGDEMOTE_KSWAPD, + PGDEMOTE_DIRECT, PGSCAN_KSWAPD, PGSCAN_DIRECT, PGSCAN_DIRECT_THROTTLE, diff -puN mm/vmscan.c~mm-vmscan-add-page-demotion-counter mm/vmscan.c --- a/mm/vmscan.c~mm-vmscan-add-page-demotion-counter 2021-01-25 16:23:15.823866693 -0800 +++ b/mm/vmscan.c 2021-01-25 16:23:15.835866693 -0800 @@ -1120,6 +1120,11 @@ static unsigned int demote_page_list(str target_nid, MIGRATE_ASYNC, MR_DEMOTION, &nr_succeeded); + if (current_is_kswapd()) + __count_vm_events(PGDEMOTE_KSWAPD, nr_succeeded); + else + __count_vm_events(PGDEMOTE_DIRECT, nr_succeeded); + return nr_succeeded; } diff -puN mm/vmstat.c~mm-vmscan-add-page-demotion-counter mm/vmstat.c --- a/mm/vmstat.c~mm-vmscan-add-page-demotion-counter 2021-01-25 16:23:15.825866693 -0800 +++ b/mm/vmstat.c 2021-01-25 16:23:15.838866693 -0800 @@ -1244,6 +1244,8 @@ const char * const vmstat_text[] = { "pgreuse", "pgsteal_kswapd", "pgsteal_direct", + "pgdemote_kswapd", + "pgdemote_direct", "pgscan_kswapd", "pgscan_direct", "pgscan_direct_throttle", _
next prev parent reply other threads:[~2021-01-26 12:35 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-26 0:34 [RFC][PATCH 00/13] [v5] Migrate Pages in lieu of discard Dave Hansen 2021-01-26 0:34 ` Dave Hansen 2021-01-26 0:34 ` [RFC][PATCH 01/13] mm/vmscan: restore zone_reclaim_mode ABI Dave Hansen 2021-01-26 0:34 ` Dave Hansen 2021-02-10 9:42 ` Oscar Salvador 2021-01-26 0:34 ` [RFC][PATCH 02/13] mm/vmscan: move RECLAIM* bits to uapi header Dave Hansen 2021-01-26 0:34 ` Dave Hansen 2021-02-10 9:44 ` Oscar Salvador 2021-01-26 0:34 ` [RFC][PATCH 03/13] mm/vmscan: replace implicit RECLAIM_ZONE checks with explicit checks Dave Hansen 2021-01-26 0:34 ` Dave Hansen 2021-01-31 1:10 ` David Rientjes 2021-01-31 1:10 ` David Rientjes 2021-02-10 9:54 ` Oscar Salvador 2021-01-26 0:34 ` [RFC][PATCH 04/13] mm/numa: node demotion data structure and lookup Dave Hansen 2021-01-26 0:34 ` Dave Hansen 2021-01-31 1:19 ` David Rientjes 2021-01-31 1:19 ` David Rientjes 2021-02-01 17:49 ` Dave Hansen 2021-01-26 0:34 ` [RFC][PATCH 05/13] mm/numa: automatically generate node migration order Dave Hansen 2021-01-26 0:34 ` Dave Hansen 2021-01-29 20:46 ` Yang Shi 2021-01-29 20:46 ` Yang Shi 2021-02-01 19:13 ` Dave Hansen 2021-02-02 11:43 ` Oscar Salvador 2021-02-02 17:46 ` Yang Shi 2021-02-02 17:46 ` Yang Shi 2021-02-03 0:43 ` Dave Hansen 2021-02-04 0:26 ` Yang Shi 2021-02-04 0:26 ` Yang Shi 2021-01-26 0:34 ` [RFC][PATCH 06/13] mm/migrate: update migration order during on hotplug events Dave Hansen 2021-01-26 0:34 ` Dave Hansen 2021-01-29 20:59 ` Yang Shi 2021-01-29 20:59 ` Yang Shi 2021-02-02 11:42 ` Oscar Salvador 2021-02-09 23:45 ` Dave Hansen 2021-02-10 8:55 ` Oscar Salvador 2021-01-26 0:34 ` [RFC][PATCH 07/13] mm/migrate: make migrate_pages() return nr_succeeded Dave Hansen 2021-01-26 0:34 ` Dave Hansen 2021-01-29 21:04 ` Yang Shi 2021-01-29 21:04 ` Yang Shi 2021-02-09 23:41 ` Dave Hansen 2021-01-26 0:34 ` [RFC][PATCH 08/13] mm/migrate: demote pages during reclaim Dave Hansen 2021-01-26 0:34 ` Dave Hansen 2021-02-02 11:55 ` Oscar Salvador 2021-02-02 22:45 ` Yang Shi 2021-02-02 22:45 ` Yang Shi 2021-02-02 22:56 ` Dave Hansen 2021-02-02 18:22 ` Yang Shi 2021-02-02 18:22 ` Yang Shi 2021-02-02 18:34 ` Dave Hansen 2021-01-26 0:34 ` Dave Hansen [this message] 2021-01-26 0:34 ` [RFC][PATCH 09/13] mm/vmscan: add page demotion counter Dave Hansen 2021-01-26 0:34 ` [RFC][PATCH 10/13] mm/vmscan: add helper for querying ability to age anonymous pages Dave Hansen 2021-01-26 0:34 ` Dave Hansen 2021-01-26 0:34 ` [RFC][PATCH 11/13] mm/vmscan: Consider anonymous pages without swap Dave Hansen 2021-01-26 0:34 ` Dave Hansen 2021-02-02 18:56 ` Yang Shi 2021-02-02 18:56 ` Yang Shi 2021-02-02 21:35 ` Dave Hansen 2021-02-02 22:35 ` Yang Shi 2021-02-02 22:35 ` Yang Shi 2021-01-26 0:34 ` [RFC][PATCH 12/13] mm/vmscan: never demote for memcg reclaim Dave Hansen 2021-01-26 0:34 ` Dave Hansen 2021-01-26 0:34 ` [RFC][PATCH 13/13] mm/migrate: new zone_reclaim_mode to enable reclaim migration Dave Hansen 2021-01-26 0:34 ` Dave Hansen 2021-01-31 1:13 ` [RFC][PATCH 00/13] [v5] Migrate Pages in lieu of discard David Rientjes 2021-01-31 1:13 ` David Rientjes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210126003429.1045A904@viggo.jf.intel.com \ --to=dave.hansen@linux.intel.com \ --cc=dan.j.williams@intel.com \ --cc=david@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=osalvador@suse.de \ --cc=rientjes@google.com \ --cc=yang.shi@linux.alibaba.com \ --cc=ying.huang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.