All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Leng <lengchao@huawei.com>
To: <linux-nvme@lists.infradead.org>
Cc: <kbusch@kernel.org>, <axboe@fb.com>, <hch@lst.de>,
	<sagi@grimberg.me>, <linux-block@vger.kernel.org>,
	<axboe@kernel.dk>
Subject: [PATCH v4 3/5] nvme-fabrics: avoid double request completion for nvmf_fail_nonready_command
Date: Tue, 26 Jan 2021 16:15:37 +0800	[thread overview]
Message-ID: <20210126081539.13320-4-lengchao@huawei.com> (raw)
In-Reply-To: <20210126081539.13320-1-lengchao@huawei.com>

When reconnect, the request may be completed with NVME_SC_HOST_PATH_ERROR
in nvmf_fail_nonready_command. The state of request will be changed to
MQ_RQ_IN_FLIGHT before call nvme_complete_rq. If free the request
asynchronously such as in nvme_submit_user_cmd, in extreme scenario
the request may be completed again in tear down process.
nvmf_fail_nonready_command do not need calling blk_mq_start_request
before complete the request. nvmf_fail_nonready_command should set
the state of request to MQ_RQ_COMPLETE before complete the request.

Signed-off-by: Chao Leng <lengchao@huawei.com>
---
 drivers/nvme/host/fabrics.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index 72ac00173500..40f40c0debc1 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -553,9 +553,7 @@ blk_status_t nvmf_fail_nonready_command(struct nvme_ctrl *ctrl,
 	    !blk_noretry_request(rq) && !(rq->cmd_flags & REQ_NVME_MPATH))
 		return BLK_STS_RESOURCE;
 
-	nvme_req(rq)->status = NVME_SC_HOST_PATH_ERROR;
-	blk_mq_start_request(rq);
-	nvme_complete_rq(rq);
+	nvme_complete_failed_rq(rq, NVME_SC_HOST_PATH_ERROR);
 	return BLK_STS_OK;
 }
 EXPORT_SYMBOL_GPL(nvmf_fail_nonready_command);
-- 
2.16.4


WARNING: multiple messages have this Message-ID (diff)
From: Chao Leng <lengchao@huawei.com>
To: <linux-nvme@lists.infradead.org>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, sagi@grimberg.me,
	axboe@fb.com, kbusch@kernel.org, hch@lst.de
Subject: [PATCH v4 3/5] nvme-fabrics: avoid double request completion for nvmf_fail_nonready_command
Date: Tue, 26 Jan 2021 16:15:37 +0800	[thread overview]
Message-ID: <20210126081539.13320-4-lengchao@huawei.com> (raw)
In-Reply-To: <20210126081539.13320-1-lengchao@huawei.com>

When reconnect, the request may be completed with NVME_SC_HOST_PATH_ERROR
in nvmf_fail_nonready_command. The state of request will be changed to
MQ_RQ_IN_FLIGHT before call nvme_complete_rq. If free the request
asynchronously such as in nvme_submit_user_cmd, in extreme scenario
the request may be completed again in tear down process.
nvmf_fail_nonready_command do not need calling blk_mq_start_request
before complete the request. nvmf_fail_nonready_command should set
the state of request to MQ_RQ_COMPLETE before complete the request.

Signed-off-by: Chao Leng <lengchao@huawei.com>
---
 drivers/nvme/host/fabrics.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index 72ac00173500..40f40c0debc1 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -553,9 +553,7 @@ blk_status_t nvmf_fail_nonready_command(struct nvme_ctrl *ctrl,
 	    !blk_noretry_request(rq) && !(rq->cmd_flags & REQ_NVME_MPATH))
 		return BLK_STS_RESOURCE;
 
-	nvme_req(rq)->status = NVME_SC_HOST_PATH_ERROR;
-	blk_mq_start_request(rq);
-	nvme_complete_rq(rq);
+	nvme_complete_failed_rq(rq, NVME_SC_HOST_PATH_ERROR);
 	return BLK_STS_OK;
 }
 EXPORT_SYMBOL_GPL(nvmf_fail_nonready_command);
-- 
2.16.4


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  parent reply	other threads:[~2021-01-26 18:53 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26  8:15 [PATCH v4 0/5] avoid double request completion and IO error Chao Leng
2021-01-26  8:15 ` Chao Leng
2021-01-26  8:15 ` [PATCH v4 1/5] blk-mq: introduce blk_mq_set_request_complete Chao Leng
2021-01-26  8:15   ` Chao Leng
2021-01-27 16:40   ` Christoph Hellwig
2021-01-27 16:40     ` Christoph Hellwig
2021-01-28  1:34     ` Chao Leng
2021-01-28  1:34       ` Chao Leng
2021-01-26  8:15 ` [PATCH v4 2/5] nvme-core: introduce complete failed request Chao Leng
2021-01-26  8:15   ` Chao Leng
2021-01-26  8:15 ` Chao Leng [this message]
2021-01-26  8:15   ` [PATCH v4 3/5] nvme-fabrics: avoid double request completion for nvmf_fail_nonready_command Chao Leng
2021-01-26  8:15 ` [PATCH v4 4/5] nvme-rdma: avoid IO error for nvme native multipath Chao Leng
2021-01-26  8:15   ` Chao Leng
2021-01-28  8:39   ` Sagi Grimberg
2021-01-28  8:39     ` Sagi Grimberg
2021-01-28  9:31     ` Chao Leng
2021-01-28  9:31       ` Chao Leng
2021-01-29  1:35       ` Sagi Grimberg
2021-01-29  1:35         ` Sagi Grimberg
2021-01-29  2:48         ` Chao Leng
2021-01-29  2:48           ` Chao Leng
2021-01-29  3:24           ` Sagi Grimberg
2021-01-29  3:24             ` Sagi Grimberg
2021-01-29  3:30             ` Chao Leng
2021-01-29  3:30               ` Chao Leng
2021-01-29  3:37               ` Sagi Grimberg
2021-01-29  3:37                 ` Sagi Grimberg
2021-01-29  3:50                 ` Chao Leng
2021-01-29  3:50                   ` Chao Leng
2021-01-29  3:37             ` Chao Leng
2021-01-29  3:37               ` Chao Leng
2021-01-26  8:15 ` [PATCH v4 5/5] nvme-fc: " Chao Leng
2021-01-26  8:15   ` Chao Leng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210126081539.13320-4-lengchao@huawei.com \
    --to=lengchao@huawei.com \
    --cc=axboe@fb.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.