All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org
Subject: [PATCH 13/21] clk: qcom: gcc-ipq4019: Remove unused variable 'ret'
Date: Tue, 26 Jan 2021 12:45:32 +0000	[thread overview]
Message-ID: <20210126124540.3320214-14-lee.jones@linaro.org> (raw)
In-Reply-To: <20210126124540.3320214-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/clk/qcom/gcc-ipq4019.c: In function ‘clk_cpu_div_set_rate’:
 drivers/clk/qcom/gcc-ipq4019.c:1279:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]

Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/clk/qcom/gcc-ipq4019.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/qcom/gcc-ipq4019.c b/drivers/clk/qcom/gcc-ipq4019.c
index ef5137fd50f3f..8abad4032de71 100644
--- a/drivers/clk/qcom/gcc-ipq4019.c
+++ b/drivers/clk/qcom/gcc-ipq4019.c
@@ -1276,16 +1276,15 @@ static int clk_cpu_div_set_rate(struct clk_hw *hw, unsigned long rate,
 	struct clk_fepll *pll = to_clk_fepll(hw);
 	const struct freq_tbl *f;
 	u32 mask;
-	int ret;
 
 	f = qcom_find_freq(pll->freq_tbl, rate);
 	if (!f)
 		return -EINVAL;
 
 	mask = (BIT(pll->cdiv.width) - 1) << pll->cdiv.shift;
-	ret = regmap_update_bits(pll->cdiv.clkr.regmap,
-				 pll->cdiv.reg, mask,
-				 f->pre_div << pll->cdiv.shift);
+	regmap_update_bits(pll->cdiv.clkr.regmap,
+			   pll->cdiv.reg, mask,
+			   f->pre_div << pll->cdiv.shift);
 	/*
 	 * There is no status bit which can be checked for successful CPU
 	 * divider update operation so using delay for the same.
-- 
2.25.1


  parent reply	other threads:[~2021-01-26 12:54 UTC|newest]

Thread overview: 147+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 12:45 [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
2021-01-26 12:45 ` Lee Jones
2021-01-26 12:45 ` Lee Jones
2021-01-26 12:45 ` [PATCH 01/21] clk: zynq: pll: Fix kernel-doc formatting in 'clk_register_zynq_pll's header Lee Jones
2021-01-26 12:45   ` Lee Jones
2021-01-26 12:58   ` Michal Simek
2021-01-26 12:58     ` Michal Simek
2021-02-11 19:54   ` Stephen Boyd
2021-02-11 19:54     ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 02/21] clk: ti: clkt_dpll: Fix some kernel-doc misdemeanours Lee Jones
2021-02-11 19:54   ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 03/21] clk: ti: dpll3xxx: Fix some kernel-doc headers and promote other worthy ones Lee Jones
2021-02-11 19:54   ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 04/21] clk: qcom: clk-regmap: Provide missing description for 'devm_clk_register_regmap()'s dev param Lee Jones
2021-01-26 13:59   ` Bjorn Andersson
2021-02-11 19:54   ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 05/21] clk: sunxi: clk-sun9i-core: Demote non-conformant kernel-doc headers Lee Jones
2021-01-26 12:45   ` Lee Jones
2021-01-26 12:45 ` [PATCH 06/21] clk: sunxi: clk-usb: Demote obvious kernel-doc abuse Lee Jones
2021-01-26 12:45   ` Lee Jones
2021-01-26 12:45 ` [PATCH 07/21] clk: tegra: clk-tegra30: Remove unused variable 'reg' Lee Jones
2021-02-11 19:55   ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 08/21] clk: clkdev: Ignore suggestion to use gnu_printf() as it's not appropriate here Lee Jones
2021-01-26 12:45   ` Lee Jones
2021-02-11 19:23   ` Stephen Boyd
2021-02-11 19:23     ` Stephen Boyd
2021-02-12  9:36     ` Lee Jones
2021-02-12  9:36       ` Lee Jones
2021-03-10  8:59       ` Lee Jones
2021-03-10  8:59         ` Lee Jones
2021-01-26 12:45 ` [PATCH 09/21] clk: tegra: cvb: Provide missing description for 'tegra_cvb_add_opp_table()'s align param Lee Jones
2021-02-11 19:56   ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 10/21] clk: ti: dpll44xx: Fix some potential doc-rot Lee Jones
2021-02-11 19:56   ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 11/21] clk: renesas: renesas-cpg-mssr: Fix formatting issues for 'smstpcr_saved's documentation Lee Jones
2021-01-26 15:49   ` Geert Uytterhoeven
2021-01-26 12:45 ` [PATCH 12/21] clk: sunxi: clk-sun6i-ar100: Demote non-conformant kernel-doc header Lee Jones
2021-01-26 12:45   ` Lee Jones
2021-01-26 15:54   ` Maxime Ripard
2021-01-26 15:54     ` Maxime Ripard
2021-01-26 16:54     ` Lee Jones
2021-01-26 16:54       ` Lee Jones
2021-02-03  9:27       ` Maxime Ripard
2021-02-03  9:27         ` Maxime Ripard
2021-02-03 10:09         ` Lee Jones
2021-02-03 10:09           ` Lee Jones
2021-01-26 12:45 ` Lee Jones [this message]
2021-01-26 14:01   ` [PATCH 13/21] clk: qcom: gcc-ipq4019: Remove unused variable 'ret' Bjorn Andersson
2021-02-11 19:56   ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 14/21] clk: clk-fixed-mmio: Demote obvious kernel-doc abuse Lee Jones
2021-02-11 19:56   ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 15/21] clk: clk-npcm7xx: Remove unused static const tables 'npcm7xx_gates' and 'npcm7xx_divs_fx' Lee Jones
2021-01-26 12:45   ` Lee Jones
2021-02-03  8:08   ` Tali Perry
2021-02-03  9:52     ` Tali Perry
2021-02-03  9:52       ` Tali Perry
2021-02-11 19:56   ` Stephen Boyd
2021-02-11 19:56     ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 16/21] clk: qcom: mmcc-msm8974: Remove unused static const tables 'mmcc_xo_mmpll0_1_2_gpll0{map}' Lee Jones
2021-01-26 14:02   ` Bjorn Andersson
2021-02-11 19:57   ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 17/21] clk: clk-xgene: Add description for 'mask' and fix formatting for 'flags' Lee Jones
2021-02-11 19:57   ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 18/21] clk: qcom: clk-rpm: Remove a bunch of superfluous code Lee Jones
2021-01-26 14:04   ` Bjorn Andersson
2021-02-11 19:57   ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 19/21] clk: spear: Move prototype to accessible header Lee Jones
2021-01-26 12:45   ` Lee Jones
2021-01-27  4:36   ` Viresh Kumar
2021-01-27  4:36     ` Viresh Kumar
2021-02-11 19:58   ` Stephen Boyd
2021-02-11 19:58     ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 20/21] clk: imx: Move 'imx6sl_set_wait_clk()'s prototype out " Lee Jones
2021-01-26 12:45   ` Lee Jones
2021-01-30 14:13   ` Shawn Guo
2021-01-30 14:13     ` Shawn Guo
2021-01-26 12:45 ` [PATCH 21/21] clk: zynqmp: divider: Add missing description for 'max_div' Lee Jones
2021-01-26 12:45   ` Lee Jones
2021-01-26 12:51   ` Michal Simek
2021-01-26 12:51     ` Michal Simek
2021-02-11 19:58   ` Stephen Boyd
2021-02-11 19:58     ` Stephen Boyd
2021-02-03  8:31 ` [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
2021-02-03  8:31   ` Lee Jones
2021-02-05 18:55   ` Stephen Boyd
2021-02-05 18:55     ` Stephen Boyd
2021-02-05 19:19     ` Lee Jones
2021-02-05 19:19       ` Lee Jones
2021-02-05 19:19       ` Lee Jones
2021-02-08  6:45 ` Tero Kristo
2021-02-08  6:45   ` Tero Kristo
2021-02-08  6:45   ` Tero Kristo
2021-02-11 20:47 ` Stephen Boyd
2021-02-11 20:47   ` Stephen Boyd
2021-02-11 20:47   ` Stephen Boyd
2021-02-11 21:10   ` Lee Jones
2021-02-11 21:10     ` Lee Jones
2021-02-11 21:10     ` Lee Jones
2021-02-12  3:07     ` Stephen Boyd
2021-02-12  3:07       ` Stephen Boyd
2021-02-12  3:07       ` Stephen Boyd
2021-02-12  9:20       ` Lee Jones
2021-02-12  9:20         ` Lee Jones
2021-02-12  9:20         ` Lee Jones
2021-02-12 21:02         ` Stephen Boyd
2021-02-12 21:02           ` Stephen Boyd
2021-02-12 21:02           ` Stephen Boyd
2021-02-12 21:25           ` Lee Jones
2021-02-12 21:25             ` Lee Jones
2021-02-12 21:25             ` Lee Jones
2021-02-12 21:26             ` Lee Jones
2021-02-12 21:26               ` Lee Jones
2021-02-12 21:26               ` Lee Jones
2021-02-12 22:05               ` Stephen Boyd
2021-02-12 22:05                 ` Stephen Boyd
2021-02-12 22:05                 ` Stephen Boyd
2021-02-12 22:37                 ` Lee Jones
2021-02-12 22:37                   ` Lee Jones
2021-02-12 22:37                   ` Lee Jones
2021-02-13  0:06                   ` Stephen Boyd
2021-02-13  0:06                     ` Stephen Boyd
2021-02-13  0:06                     ` Stephen Boyd
2021-02-13 16:04                     ` Andrew Lunn
2021-02-13 16:04                       ` Andrew Lunn
2021-02-13 16:04                       ` Andrew Lunn
2021-02-14 21:00                       ` Stephen Boyd
2021-02-14 21:20                         ` Andrew Lunn
2021-02-14 21:20                           ` Andrew Lunn
2021-02-14 21:20                           ` Andrew Lunn
2021-02-15  8:49                           ` Lee Jones
2021-02-15  8:49                             ` Lee Jones
2021-02-15  8:49                             ` Lee Jones
2021-02-15 17:45                             ` Jakub Kicinski
2021-02-15 17:45                               ` Jakub Kicinski
2021-02-15 17:45                               ` Jakub Kicinski
2021-02-16  8:20                               ` Lee Jones
2021-02-16  8:20                                 ` Lee Jones
2021-02-16  8:20                                 ` Lee Jones
2021-02-17 18:08                                 ` Jakub Kicinski
2021-02-17 18:08                                   ` Jakub Kicinski
2021-02-17 18:08                                   ` Jakub Kicinski
2021-02-18  9:31                                   ` Lee Jones
2021-02-18  9:31                                     ` Lee Jones
2021-02-18  9:31                                     ` Lee Jones
2021-02-13 15:58       ` Andrew Lunn
2021-02-13 15:58         ` Andrew Lunn
2021-02-13 15:58         ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210126124540.3320214-14-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.