From: Gao Xiang <hsiangkao@redhat.com>
To: linux-xfs@vger.kernel.org
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Brian Foster <bfoster@redhat.com>,
Eric Sandeen <sandeen@sandeen.net>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>,
Gao Xiang <hsiangkao@redhat.com>
Subject: [PATCH v6 0/7] xfs: support shrinking free space in the last AG
Date: Tue, 26 Jan 2021 20:56:14 +0800 [thread overview]
Message-ID: <20210126125621.3846735-1-hsiangkao@redhat.com> (raw)
Hi folks,
v5: https://lore.kernel.org/r/20210118083700.2384277-1-hsiangkao@redhat.com
This patchset attempts to support shrinking free space in the last AG.
This version addresses Darrick's review of v5, aside from that I'm not
sure if seperating the whole shrink functionality is a good idea (I just
tried but it seemed that ~90% is duplicated code.) IMHO, It'd be better
to separate when needed (I'm investigating shrinking the whole AGs as
well, it seems not too much invasive than the current approach...) Yet
if people have strong opinion of this, I will resend the next version
instead.
Thanks for the time!
Thanks,
Gao Xiang
xfsprogs: https://lore.kernel.org/r/20201028114010.545331-1-hsiangkao@redhat.com
xfstests: https://lore.kernel.org/r/20201028230909.639698-1-hsiangkao@redhat.com
Changes since v5 (Darrick):
- [3/7] use a separate patch to update lazy sb counters;
- [5/7] introduce the xfs_ag_shrink_space() helper first
as a seperate patch... I think it'd be better to "define
xfs_ag_shrink_space() as a stub that returns EOPNOSUPP..."
- [5/7] roll the transaction in advance so the new trans can be
canceled safely.
- [6/7] "nagcount != oagcount" ==> "nagcount < oagcount"
Gao Xiang (7):
xfs: rename `new' to `delta' in xfs_growfs_data_private()
xfs: get rid of xfs_growfs_{data,log}_t
xfs: update lazy sb counters immediately for resizefs
xfs: hoist out xfs_resizefs_init_new_ags()
xfs: introduce xfs_ag_shrink_space()
xfs: support shrinking unused space in the last AG
xfs: add error injection for per-AG resv failure when shrinkfs
fs/xfs/libxfs/xfs_ag.c | 113 +++++++++++++++++++++++++
fs/xfs/libxfs/xfs_ag.h | 2 +
fs/xfs/libxfs/xfs_errortag.h | 4 +-
fs/xfs/xfs_error.c | 2 +
fs/xfs/xfs_fsops.c | 158 ++++++++++++++++++++++-------------
fs/xfs/xfs_fsops.h | 4 +-
fs/xfs/xfs_ioctl.c | 4 +-
fs/xfs/xfs_trans.c | 1 -
8 files changed, 224 insertions(+), 64 deletions(-)
--
2.27.0
next reply other threads:[~2021-01-26 12:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 12:56 Gao Xiang [this message]
2021-01-26 12:56 ` [PATCH v6 1/7] xfs: rename `new' to `delta' in xfs_growfs_data_private() Gao Xiang
2021-02-02 19:37 ` Brian Foster
2021-01-26 12:56 ` [PATCH v6 2/7] xfs: get rid of xfs_growfs_{data,log}_t Gao Xiang
2021-02-02 19:37 ` Brian Foster
2021-01-26 12:56 ` [PATCH v6 3/7] xfs: update lazy sb counters immediately for resizefs Gao Xiang
2021-02-02 19:38 ` Brian Foster
2021-02-03 0:45 ` Gao Xiang
2021-01-26 12:56 ` [PATCH v6 4/7] xfs: hoist out xfs_resizefs_init_new_ags() Gao Xiang
2021-02-02 19:38 ` Brian Foster
2021-01-26 12:56 ` [PATCH v6 5/7] xfs: introduce xfs_ag_shrink_space() Gao Xiang
2021-01-26 12:56 ` [PATCH v6 6/7] xfs: support shrinking unused space in the last AG Gao Xiang
2021-02-03 14:23 ` Brian Foster
2021-02-03 14:51 ` Gao Xiang
2021-02-03 18:01 ` Brian Foster
2021-02-04 9:18 ` Gao Xiang
2021-02-04 12:33 ` Brian Foster
2021-02-04 16:21 ` Gao Xiang
2021-02-03 18:12 ` Darrick J. Wong
2021-02-03 18:14 ` Darrick J. Wong
2021-02-03 19:02 ` Gao Xiang
2021-02-03 19:19 ` Gao Xiang
2021-02-04 12:33 ` Brian Foster
2021-02-04 13:58 ` Gao Xiang
2021-02-04 9:40 ` Gao Xiang
2021-01-26 12:56 ` [PATCH v6 7/7] xfs: add error injection for per-AG resv failure when shrinkfs Gao Xiang
2021-02-03 14:23 ` Brian Foster
2021-02-03 15:01 ` Gao Xiang
2021-02-03 18:01 ` Brian Foster
2021-02-04 9:20 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126125621.3846735-1-hsiangkao@redhat.com \
--to=hsiangkao@redhat.com \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.