All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@redhat.com>
To: fstests@vger.kernel.org
Subject: [PATCH] generic/233,270: unlimit the max locked memory size for io_uring
Date: Wed, 27 Jan 2021 15:21:43 +0800	[thread overview]
Message-ID: <20210127072143.247849-1-zlang@redhat.com> (raw)

The ltp/fsstress always fails on io_uring_queue_init() by returnning
ENOMEM. Due to io_uring accounts memory it needs under the rlimit
memlocked option, which can be quite low on some setups, especially
on 64K pagesize machine. root isn't under this restriction, but
regular users are. So only g/233 and g/270 which use $qa_user to run
fsstress are failed.

To avoid this failure, set max locked memory to unlimited before doing
fsstress, then restore it after test done.

Signed-off-by: Zorro Lang <zlang@redhat.com>
---
 tests/generic/233 | 8 ++++++++
 tests/generic/270 | 8 ++++++++
 2 files changed, 16 insertions(+)

diff --git a/tests/generic/233 b/tests/generic/233
index 7eda5774..342690c2 100755
--- a/tests/generic/233
+++ b/tests/generic/233
@@ -43,6 +43,13 @@ _fsstress()
 -f rename=10 -f fsync=2 -f write=15 -f dwrite=15 \
 -n $count -d $out -p 7`
 
+	# io_uring accounts memory it needs under the rlimit memlocked option,
+	# which can be quite low on some setups (especially 64K pagesize). root
+	# isn't under this restriction, but regular users are. To avoid the
+	# io_uring_queue_init fail on ENOMEM, set max locked memory to unlimited
+	# temporarily.
+	lmem=`ulimit -l`
+	ulimit -l unlimited
 	echo "fsstress $args" >> $seqres.full
 	if ! su $qa_user -c "$FSSTRESS_PROG $args" | tee -a $seqres.full | _filter_num
 	then
@@ -50,6 +57,7 @@ _fsstress()
 		cat $tmp.out | tee -a $seqres.full
 		status=1
 	fi
+	ulimit -l $lmem
 }
 
 # real QA test starts here
diff --git a/tests/generic/270 b/tests/generic/270
index 3d8656d4..bd52d56e 100755
--- a/tests/generic/270
+++ b/tests/generic/270
@@ -37,6 +37,13 @@ _workout()
 	cp $FSSTRESS_PROG  $tmp.fsstress.bin
 	$SETCAP_PROG cap_chown=epi  $tmp.fsstress.bin
 
+	# io_uring accounts memory it needs under the rlimit memlocked option,
+	# which can be quite low on some setups (especially 64K pagesize). root
+	# isn't under this restriction, but regular users are. To avoid the
+	# io_uring_queue_init fail on ENOMEM, set max locked memory to unlimited
+	# temporarily.
+	lmem=`ulimit -l`
+	ulimit -l unlimited
 	(su $qa_user -c "$tmp.fsstress.bin $args" &) > /dev/null 2>&1
 
 	echo "Run dd writers in parallel"
@@ -50,6 +57,7 @@ _workout()
 	done
 
 	$KILLALL_PROG -w $tmp.fsstress.bin
+	ulimit -l $lmem
 }
 
 # real QA test starts here
-- 
2.29.2


             reply	other threads:[~2021-01-27  7:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27  7:21 Zorro Lang [this message]
2021-01-27 23:43 ` [PATCH] generic/233,270: unlimit the max locked memory size for io_uring Darrick J. Wong
2021-01-28  3:02   ` Zorro Lang
2021-01-31 15:24     ` Eryu Guan
     [not found]       ` <20210131163412.GZ14354@localhost.localdomain>
2021-02-07 16:23         ` Eryu Guan
2021-02-07 16:31 ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210127072143.247849-1-zlang@redhat.com \
    --to=zlang@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.