From: Biwen Li <biwen.li@oss.nxp.com> To: mark.rutland@arm.com, leoyang.li@nxp.com, tglx@linutronix.de, jason@lakedaemon.net, maz@kernel.org Cc: linux-kernel@vger.kernel.org, jiafei.pan@nxp.com, linux-arm-kernel@lists.infradead.org, ran.wang_1@nxp.com, Biwen Li <biwen.li@nxp.com> Subject: [PATCH] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace Date: Wed, 27 Jan 2021 16:55:09 +0800 [thread overview] Message-ID: <20210127085509.18948-1-biwen.li@oss.nxp.com> (raw) From: Biwen Li <biwen.li@nxp.com> Add flag IRQCHIP_SKIP_SET_WAKE to remove call trace as follow, ... [ 45.605239] Unbalanced IRQ 120 wake disable [ 45.609445] WARNING: CPU: 0 PID: 1124 at kernel/irq/manage.c:800 irq_set_irq_wake+0x154/0x1a0 ... [ 45.645141] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--) [ 45.651144] pc : irq_set_irq_wake+0x154/0x1a0 [ 45.655497] lr : irq_set_irq_wake+0x154/0x1a0 ... [ 45.742825] Call trace: [ 45.745268] irq_set_irq_wake+0x154/0x1a0 [ 45.749278] ds3232_resume+0x38/0x50 On ls2088ardb: In suspend progress(# echo mem > /sys/power/state), pm_suspend()->suspend_devices_and_enter()->dpm_suspend()->device_suspend() ->ds3232_suspend()->enable_irq_wake()->irq_set_irq_wake() ->set_irq_wake_real(), return -ENXIO, there get "Cannot set wakeup source" in ds3232_suspend(). In resume progress(wakeup by flextimer) dpm_resume_end()->dpm_resume() ->device_resume()->ds3232_resume() ->disable_irq_wake()->irq_set_irq_wake() ->set_irq_wake_real(), there get kernel call trace(Unbalanced IRQ 120 wake disable) Signed-off-by: Biwen Li <biwen.li@nxp.com> --- Change in v2: - update description drivers/irqchip/irq-ls-extirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-ls-extirq.c b/drivers/irqchip/irq-ls-extirq.c index 564e6de0bd8e..3c6ed7b4744d 100644 --- a/drivers/irqchip/irq-ls-extirq.c +++ b/drivers/irqchip/irq-ls-extirq.c @@ -65,7 +65,7 @@ static struct irq_chip ls_extirq_chip = { .irq_set_type = ls_extirq_set_type, .irq_retrigger = irq_chip_retrigger_hierarchy, .irq_set_affinity = irq_chip_set_affinity_parent, - .flags = IRQCHIP_SET_TYPE_MASKED, + .flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SET_WAKE, }; static int -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Biwen Li <biwen.li@oss.nxp.com> To: mark.rutland@arm.com, leoyang.li@nxp.com, tglx@linutronix.de, jason@lakedaemon.net, maz@kernel.org Cc: Biwen Li <biwen.li@nxp.com>, jiafei.pan@nxp.com, ran.wang_1@nxp.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace Date: Wed, 27 Jan 2021 16:55:09 +0800 [thread overview] Message-ID: <20210127085509.18948-1-biwen.li@oss.nxp.com> (raw) From: Biwen Li <biwen.li@nxp.com> Add flag IRQCHIP_SKIP_SET_WAKE to remove call trace as follow, ... [ 45.605239] Unbalanced IRQ 120 wake disable [ 45.609445] WARNING: CPU: 0 PID: 1124 at kernel/irq/manage.c:800 irq_set_irq_wake+0x154/0x1a0 ... [ 45.645141] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--) [ 45.651144] pc : irq_set_irq_wake+0x154/0x1a0 [ 45.655497] lr : irq_set_irq_wake+0x154/0x1a0 ... [ 45.742825] Call trace: [ 45.745268] irq_set_irq_wake+0x154/0x1a0 [ 45.749278] ds3232_resume+0x38/0x50 On ls2088ardb: In suspend progress(# echo mem > /sys/power/state), pm_suspend()->suspend_devices_and_enter()->dpm_suspend()->device_suspend() ->ds3232_suspend()->enable_irq_wake()->irq_set_irq_wake() ->set_irq_wake_real(), return -ENXIO, there get "Cannot set wakeup source" in ds3232_suspend(). In resume progress(wakeup by flextimer) dpm_resume_end()->dpm_resume() ->device_resume()->ds3232_resume() ->disable_irq_wake()->irq_set_irq_wake() ->set_irq_wake_real(), there get kernel call trace(Unbalanced IRQ 120 wake disable) Signed-off-by: Biwen Li <biwen.li@nxp.com> --- Change in v2: - update description drivers/irqchip/irq-ls-extirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-ls-extirq.c b/drivers/irqchip/irq-ls-extirq.c index 564e6de0bd8e..3c6ed7b4744d 100644 --- a/drivers/irqchip/irq-ls-extirq.c +++ b/drivers/irqchip/irq-ls-extirq.c @@ -65,7 +65,7 @@ static struct irq_chip ls_extirq_chip = { .irq_set_type = ls_extirq_set_type, .irq_retrigger = irq_chip_retrigger_hierarchy, .irq_set_affinity = irq_chip_set_affinity_parent, - .flags = IRQCHIP_SET_TYPE_MASKED, + .flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SET_WAKE, }; static int -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-01-27 10:01 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-27 8:55 Biwen Li [this message] 2021-01-27 8:55 ` [PATCH] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace Biwen Li -- strict thread matches above, loose matches on Subject: below -- 2021-01-26 11:00 Biwen Li 2021-01-26 11:00 ` Biwen Li 2021-01-26 14:01 ` Marc Zyngier 2021-01-26 14:01 ` Marc Zyngier 2021-01-27 2:58 ` Biwen Li (OSS) 2021-01-27 2:58 ` Biwen Li (OSS)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210127085509.18948-1-biwen.li@oss.nxp.com \ --to=biwen.li@oss.nxp.com \ --cc=biwen.li@nxp.com \ --cc=jason@lakedaemon.net \ --cc=jiafei.pan@nxp.com \ --cc=leoyang.li@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=ran.wang_1@nxp.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.