All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yafang Shao <laoar.shao@gmail.com>
To: david@redhat.com, vbabka@suse.cz, cl@linux.com,
	penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
	akpm@linux-foundation.org, pmladek@suse.com, rostedt@goodmis.org,
	sergey.senozhatsky@gmail.com, andriy.shevchenko@linux.intel.com,
	linux@rasmusvillemoes.dk
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Yafang Shao <laoar.shao@gmail.com>
Subject: [PATCH 1/3] mm, slub: use pGp to print page flags
Date: Thu, 28 Jan 2021 10:19:45 +0800	[thread overview]
Message-ID: <20210128021947.22877-2-laoar.shao@gmail.com> (raw)
In-Reply-To: <20210128021947.22877-1-laoar.shao@gmail.com>

As pGp has been already introduced in printk, we'd better use it to make
the output human readable.

Before this change, the output is,
[ 6155.716018] INFO: Slab 0x000000004027dd4f objects=33 used=3 fp=0x000000008cd1579c flags=0x17ffffc0010200

While after this change, the output is,
[ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head)

Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
---
 mm/slub.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index 69742ab9a21d..4b9ab267afbc 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -641,8 +641,9 @@ void print_tracking(struct kmem_cache *s, void *object)
 
 static void print_page_info(struct page *page)
 {
-	pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=0x%04lx\n",
-	       page, page->objects, page->inuse, page->freelist, page->flags);
+	pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n",
+	       page, page->objects, page->inuse, page->freelist,
+	       page->flags, &page->flags);
 
 }
 
-- 
2.17.1


  reply	other threads:[~2021-01-28  2:21 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28  2:19 [PATCH 0/3] mm, printk: dump full information of page flags in pGp Yafang Shao
2021-01-28  2:19 ` Yafang Shao [this message]
2021-01-28 10:23   ` [PATCH 1/3] mm, slub: use pGp to print page flags Vlastimil Babka
2021-01-28 22:42   ` David Rientjes
2021-01-28 22:42     ` David Rientjes
2021-01-28  2:19 ` [PATCH 2/3] mm, slub: don't combine pr_err with INFO Yafang Shao
2021-01-28 10:35   ` Vlastimil Babka
2021-01-28 13:06     ` Yafang Shao
2021-01-28 13:06       ` Yafang Shao
2021-01-28  2:19 ` [PATCH 3/3] printk: dump full information of page flags in pGp Yafang Shao
2021-01-28  2:35   ` Joe Perches
2021-01-28  2:35     ` Joe Perches
2021-01-28  7:42     ` Yafang Shao
2021-01-28  7:42       ` Yafang Shao
2021-01-28  2:52   ` Miaohe Lin
2021-01-28  7:44     ` Yafang Shao
2021-01-28  7:44       ` Yafang Shao
2021-01-28 10:42   ` Vlastimil Babka
2021-01-28 13:07     ` Yafang Shao
2021-01-28 13:07       ` Yafang Shao
2021-01-28 12:11   ` Andy Shevchenko
2021-01-28 13:18     ` Yafang Shao
2021-01-28 13:18       ` Yafang Shao
2021-01-28 14:50       ` Andy Shevchenko
2021-01-29  1:21         ` Yafang Shao
2021-01-29  1:21           ` Yafang Shao
2021-01-28 12:12 ` [PATCH 0/3] mm, " Andy Shevchenko
2021-01-28 13:19   ` Yafang Shao
2021-01-28 13:19     ` Yafang Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210128021947.22877-2-laoar.shao@gmail.com \
    --to=laoar.shao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=cl@linux.com \
    --cc=david@redhat.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=penberg@kernel.org \
    --cc=pmladek@suse.com \
    --cc=rientjes@google.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.