From: Hermann.Lauer@uni-heidelberg.de To: linux-arm-kernel@lists.infradead.org Cc: mripard@kernel.org, wens@csie.org, jernej.skrabec@siol.net, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4] ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode Date: Thu, 28 Jan 2021 12:18:42 +0100 [thread overview] Message-ID: <20210128111842.GA11919@lemon.iwr.uni-heidelberg.de> (raw) In-Reply-To: <20210128094040.GD11559@lemon.iwr.uni-heidelberg.de> BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high packet loss rates. The realtek phy driver overrides the settings of the pull ups for the delays, so fix this for BananaPro. Fix the phy-mode description to correctly reflect this so that the implementation doesn't reconfigure the delays incorrectly. This happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config"). Fixes: 10662a33dcd9 ("ARM: dts: sun7i: Add dts file for Bananapro board") Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de> --- arch/arm/boot/dts/sun7i-a20-bananapro.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sun7i-a20-bananapro.dts b/arch/arm/boot/dts/sun7i-a20-bananapro.dts --- a/arch/arm/boot/dts/sun7i-a20-bananapro.dts +++ b/arch/arm/boot/dts/sun7i-a20-bananapro.dts @@ -110,7 +110,7 @@ pinctrl-names = "default"; pinctrl-0 = <&gmac_rgmii_pins>; phy-handle = <&phy1>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-supply = <®_gmac_3v3>; status = "okay"; };
WARNING: multiple messages have this Message-ID (diff)
From: Hermann.Lauer@uni-heidelberg.de To: linux-arm-kernel@lists.infradead.org Cc: devicetree@vger.kernel.org, jernej.skrabec@siol.net, linux-kernel@vger.kernel.org, mripard@kernel.org, wens@csie.org, robh+dt@kernel.org Subject: [PATCH v4] ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode Date: Thu, 28 Jan 2021 12:18:42 +0100 [thread overview] Message-ID: <20210128111842.GA11919@lemon.iwr.uni-heidelberg.de> (raw) In-Reply-To: <20210128094040.GD11559@lemon.iwr.uni-heidelberg.de> BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high packet loss rates. The realtek phy driver overrides the settings of the pull ups for the delays, so fix this for BananaPro. Fix the phy-mode description to correctly reflect this so that the implementation doesn't reconfigure the delays incorrectly. This happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config"). Fixes: 10662a33dcd9 ("ARM: dts: sun7i: Add dts file for Bananapro board") Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de> --- arch/arm/boot/dts/sun7i-a20-bananapro.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sun7i-a20-bananapro.dts b/arch/arm/boot/dts/sun7i-a20-bananapro.dts --- a/arch/arm/boot/dts/sun7i-a20-bananapro.dts +++ b/arch/arm/boot/dts/sun7i-a20-bananapro.dts @@ -110,7 +110,7 @@ pinctrl-names = "default"; pinctrl-0 = <&gmac_rgmii_pins>; phy-handle = <&phy1>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-supply = <®_gmac_3v3>; status = "okay"; }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-28 11:19 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-21 17:08 [PATCH v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node Hermann Lauer 2021-01-21 17:08 ` Hermann Lauer 2021-01-21 19:54 ` Jernej Škrabec 2021-01-21 19:54 ` Jernej Škrabec 2021-01-22 3:09 ` Chen-Yu Tsai 2021-01-22 3:09 ` Chen-Yu Tsai 2021-01-28 9:40 ` [PATCH v3] ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode Hermann Lauer 2021-01-28 9:40 ` Hermann Lauer 2021-01-28 11:18 ` Hermann.Lauer [this message] 2021-01-28 11:18 ` [PATCH v4] " Hermann.Lauer 2021-01-28 14:59 ` Maxime Ripard 2021-01-28 14:59 ` Maxime Ripard 2021-02-01 12:08 ` Hermann Lauer 2021-02-01 12:08 ` Hermann Lauer 2021-02-01 17:29 ` Maxime Ripard 2021-02-01 17:29 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210128111842.GA11919@lemon.iwr.uni-heidelberg.de \ --to=hermann.lauer@uni-heidelberg.de \ --cc=devicetree@vger.kernel.org \ --cc=jernej.skrabec@siol.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mripard@kernel.org \ --cc=robh+dt@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.