All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, danil.kipnis@cloud.ionos.com,
	jinpu.wang@cloud.ionos.com, hch@infradead.org,
	Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Subject: [PATCH V2 0/4] block: add two statistic tables
Date: Mon,  1 Feb 2021 02:27:23 +0100	[thread overview]
Message-ID: <20210201012727.28305-1-guoqing.jiang@cloud.ionos.com> (raw)

Hi Jens,

This version has below changes:

1. remove BLK_ADDITIONAL_DISKSTAT option per Christoph's comment.
2. move blk_queue_io_extra_stat into blk_additional_{latency,sector}
   per Christoph's comment.
3. simplify blk_additional_latency by pass duration time directly.

Thanks,
Guoqing


PATCH V1: https://marc.info/?l=linux-block&m=161176000024443&w=2
* add Jack's reviewed-by.

RFC V4: https://marc.info/?l=linux-block&m=161027198729158&w=2
* rebase with latest code.

RFC V3: https://marc.info/?l=linux-block&m=159730633416534&w=2
* Move the #ifdef CONFIG_BLK_ADDITIONAL_DISKSTAT into the function body
  per Johannes's comment.
* Tweak the output of two tables to make they are more intuitive

RFC V2: https://marc.info/?l=linux-block&m=159467483514062&w=2
* don't call ktime_get_ns and drop unnecessary patches.
* add io_extra_stats to avoid potential overhead.

RFC V1: https://marc.info/?l=linux-block&m=159419516730386&w=2

Guoqing Jiang (4):
  block: add a statistic table for io latency
  block: add a statistic table for io sector
  block: add io_extra_stats node
  block: call blk_additional_{latency,sector} only when io_extra_stats
    is true

 Documentation/ABI/testing/sysfs-block | 26 ++++++++++
 Documentation/block/queue-sysfs.rst   |  5 ++
 block/blk-core.c                      | 43 ++++++++++++++++
 block/blk-sysfs.c                     |  3 ++
 block/genhd.c                         | 74 +++++++++++++++++++++++++++
 include/linux/blkdev.h                |  2 +
 include/linux/part_stat.h             |  6 +++
 7 files changed, 159 insertions(+)

-- 
2.17.1


             reply	other threads:[~2021-02-01  1:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01  1:27 Guoqing Jiang [this message]
2021-02-01  1:27 ` [PATCH V2 1/4] block: add a statistic table for io latency Guoqing Jiang
2021-02-01  1:27 ` [PATCH V2 2/4] block: add a statistic table for io sector Guoqing Jiang
2021-02-01  1:27 ` [PATCH V2 3/4] block: add io_extra_stats node Guoqing Jiang
2021-02-01  9:47   ` Johannes Thumshirn
2021-02-02  1:29     ` Guoqing Jiang
2021-02-01  1:27 ` [PATCH V2 4/4] block: call blk_additional_{latency,sector} only when io_extra_stats is true Guoqing Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210201012727.28305-1-guoqing.jiang@cloud.ionos.com \
    --to=guoqing.jiang@cloud.ionos.com \
    --cc=axboe@kernel.dk \
    --cc=danil.kipnis@cloud.ionos.com \
    --cc=hch@infradead.org \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.