From: Hsin-Yi Wang <hsinyi@chromium.org>
To: CK Hu <ck.hu@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Mark Rutland <mark.rutland@arm.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Yongqiang Niu <yongqiang.niu@mediatek.com>
Subject: [PATCH v5 5/8] drm/mediatek: Fix ccorr size config
Date: Mon, 1 Feb 2021 18:37:24 +0800 [thread overview]
Message-ID: <20210201103727.376721-6-hsinyi@chromium.org> (raw)
In-Reply-To: <20210201103727.376721-1-hsinyi@chromium.org>
From: Yongqiang Niu <yongqiang.niu@mediatek.com>
Fix setting to follow hardware datasheet. The original error setting
affects mt8192 display.
Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
index 6ee2431e6b843..6c86673a835c3 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
@@ -65,7 +65,7 @@ void mtk_ccorr_config(struct device *dev, unsigned int w,
{
struct mtk_disp_ccorr *ccorr = dev_get_drvdata(dev);
- mtk_ddp_write(cmdq_pkt, h << 16 | w, &ccorr->cmdq_reg, ccorr->regs,
+ mtk_ddp_write(cmdq_pkt, w << 16 | h, &ccorr->cmdq_reg, ccorr->regs,
DISP_CCORR_SIZE);
mtk_ddp_write(cmdq_pkt, CCORR_ENGINE_EN, &ccorr->cmdq_reg, ccorr->regs,
DISP_CCORR_CFG);
--
2.30.0.365.g02bc693789-goog
WARNING: multiple messages have this Message-ID (diff)
From: Hsin-Yi Wang <hsinyi@chromium.org>
To: CK Hu <ck.hu@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 5/8] drm/mediatek: Fix ccorr size config
Date: Mon, 1 Feb 2021 18:37:24 +0800 [thread overview]
Message-ID: <20210201103727.376721-6-hsinyi@chromium.org> (raw)
In-Reply-To: <20210201103727.376721-1-hsinyi@chromium.org>
From: Yongqiang Niu <yongqiang.niu@mediatek.com>
Fix setting to follow hardware datasheet. The original error setting
affects mt8192 display.
Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
index 6ee2431e6b843..6c86673a835c3 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
@@ -65,7 +65,7 @@ void mtk_ccorr_config(struct device *dev, unsigned int w,
{
struct mtk_disp_ccorr *ccorr = dev_get_drvdata(dev);
- mtk_ddp_write(cmdq_pkt, h << 16 | w, &ccorr->cmdq_reg, ccorr->regs,
+ mtk_ddp_write(cmdq_pkt, w << 16 | h, &ccorr->cmdq_reg, ccorr->regs,
DISP_CCORR_SIZE);
mtk_ddp_write(cmdq_pkt, CCORR_ENGINE_EN, &ccorr->cmdq_reg, ccorr->regs,
DISP_CCORR_CFG);
--
2.30.0.365.g02bc693789-goog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Hsin-Yi Wang <hsinyi@chromium.org>
To: CK Hu <ck.hu@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 5/8] drm/mediatek: Fix ccorr size config
Date: Mon, 1 Feb 2021 18:37:24 +0800 [thread overview]
Message-ID: <20210201103727.376721-6-hsinyi@chromium.org> (raw)
In-Reply-To: <20210201103727.376721-1-hsinyi@chromium.org>
From: Yongqiang Niu <yongqiang.niu@mediatek.com>
Fix setting to follow hardware datasheet. The original error setting
affects mt8192 display.
Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
index 6ee2431e6b843..6c86673a835c3 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
@@ -65,7 +65,7 @@ void mtk_ccorr_config(struct device *dev, unsigned int w,
{
struct mtk_disp_ccorr *ccorr = dev_get_drvdata(dev);
- mtk_ddp_write(cmdq_pkt, h << 16 | w, &ccorr->cmdq_reg, ccorr->regs,
+ mtk_ddp_write(cmdq_pkt, w << 16 | h, &ccorr->cmdq_reg, ccorr->regs,
DISP_CCORR_SIZE);
mtk_ddp_write(cmdq_pkt, CCORR_ENGINE_EN, &ccorr->cmdq_reg, ccorr->regs,
DISP_CCORR_CFG);
--
2.30.0.365.g02bc693789-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Hsin-Yi Wang <hsinyi@chromium.org>
To: CK Hu <ck.hu@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 5/8] drm/mediatek: Fix ccorr size config
Date: Mon, 1 Feb 2021 18:37:24 +0800 [thread overview]
Message-ID: <20210201103727.376721-6-hsinyi@chromium.org> (raw)
In-Reply-To: <20210201103727.376721-1-hsinyi@chromium.org>
From: Yongqiang Niu <yongqiang.niu@mediatek.com>
Fix setting to follow hardware datasheet. The original error setting
affects mt8192 display.
Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
index 6ee2431e6b843..6c86673a835c3 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
@@ -65,7 +65,7 @@ void mtk_ccorr_config(struct device *dev, unsigned int w,
{
struct mtk_disp_ccorr *ccorr = dev_get_drvdata(dev);
- mtk_ddp_write(cmdq_pkt, h << 16 | w, &ccorr->cmdq_reg, ccorr->regs,
+ mtk_ddp_write(cmdq_pkt, w << 16 | h, &ccorr->cmdq_reg, ccorr->regs,
DISP_CCORR_SIZE);
mtk_ddp_write(cmdq_pkt, CCORR_ENGINE_EN, &ccorr->cmdq_reg, ccorr->regs,
DISP_CCORR_CFG);
--
2.30.0.365.g02bc693789-goog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-02-01 10:39 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 10:37 [PATCH v5 0/8] drm/mediatek: add support for mediatek SOC MT8192 Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` [PATCH v5 1/8] drm/mediatek: add component OVL_2L2 Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` [PATCH v5 2/8] drm/mediatek: add component POSTMASK Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-02 5:43 ` CK Hu
2021-02-02 5:43 ` CK Hu
2021-02-02 5:43 ` CK Hu
2021-02-02 5:43 ` CK Hu
2021-02-01 10:37 ` [PATCH v5 3/8] drm/mediatek: add component RDMA4 Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` [PATCH v5 4/8] drm/mediatek: separate ccorr module Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-02 5:44 ` CK Hu
2021-02-02 5:44 ` CK Hu
2021-02-02 5:44 ` CK Hu
2021-02-02 5:44 ` CK Hu
2021-02-01 10:37 ` Hsin-Yi Wang [this message]
2021-02-01 10:37 ` [PATCH v5 5/8] drm/mediatek: Fix ccorr size config Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-02 5:44 ` CK Hu
2021-02-02 5:44 ` CK Hu
2021-02-02 5:44 ` CK Hu
2021-02-02 5:44 ` CK Hu
2021-02-01 10:37 ` [PATCH v5 6/8] drm/mediatek: add matrix_bits private data for ccorr Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-02 5:47 ` CK Hu
2021-02-02 5:47 ` CK Hu
2021-02-02 5:47 ` CK Hu
2021-02-02 5:47 ` CK Hu
2021-02-01 10:37 ` [PATCH v5 7/8] soc: mediatek: add mtk mutex support for MT8192 Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` [PATCH v5 8/8] drm/mediatek: add support for mediatek SOC MT8192 Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
2021-02-01 10:37 ` Hsin-Yi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201103727.376721-6-hsinyi@chromium.org \
--to=hsinyi@chromium.org \
--cc=airlied@linux.ie \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.