All of lore.kernel.org
 help / color / mirror / Atom feed
From: schumaker.anna@gmail.com
To: linux-nfs@vger.kernel.org
Cc: Anna.Schumaker@Netapp.com
Subject: [PATCH v2 4/5] sunrpc: Prepare xs_connect() for taking NULL tasks
Date: Tue,  2 Feb 2021 13:42:43 -0500	[thread overview]
Message-ID: <20210202184244.288898-5-Anna.Schumaker@Netapp.com> (raw)
In-Reply-To: <20210202184244.288898-1-Anna.Schumaker@Netapp.com>

From: Anna Schumaker <Anna.Schumaker@Netapp.com>

We won't have a task structure when we go to change IP addresses, so
check for one before calling the WARN_ON() to avoid crashing.

Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
---
 net/sunrpc/xprtsock.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index c56a66cdf4ac..250abf1aa018 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -2311,7 +2311,8 @@ static void xs_connect(struct rpc_xprt *xprt, struct rpc_task *task)
 	struct sock_xprt *transport = container_of(xprt, struct sock_xprt, xprt);
 	unsigned long delay = 0;
 
-	WARN_ON_ONCE(!xprt_lock_connect(xprt, task, transport));
+	if (task)
+		WARN_ON_ONCE(!xprt_lock_connect(xprt, task, transport));
 
 	if (transport->sock != NULL) {
 		dprintk("RPC:       xs_connect delayed xprt %p for %lu "
-- 
2.29.2


  parent reply	other threads:[~2021-02-02 18:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02 18:42 [PATCH v2 0/5] SUNRPC: Create sysfs files for changing IP schumaker.anna
2021-02-02 18:42 ` [PATCH v2 1/5] sunrpc: Create a sunrpc directory under /sys/kernel/ schumaker.anna
2021-02-02 18:42 ` [PATCH v2 2/5] sunrpc: Create a net/ subdirectory in the sunrpc sysfs schumaker.anna
2021-02-02 18:42 ` [PATCH v2 3/5] sunrpc: Create per-rpc_clnt sysfs kobjects schumaker.anna
2021-02-02 18:42 ` schumaker.anna [this message]
2021-02-02 21:49   ` [PATCH v2 4/5] sunrpc: Prepare xs_connect() for taking NULL tasks Trond Myklebust
2021-02-02 21:59     ` Trond Myklebust
2021-02-05 18:33       ` Anna Schumaker
2021-02-02 18:42 ` [PATCH v2 5/5] sunrpc: Create a per-rpc_clnt file for managing the destination IP address schumaker.anna
2021-02-06 14:02   ` [sunrpc] 32fea9c254: WARNING:suspicious_RCU_usage kernel test robot
2021-02-06 14:02     ` kernel test robot
2021-02-02 18:51 ` [PATCH v2 0/5] SUNRPC: Create sysfs files for changing IP Chuck Lever
2021-02-02 18:52   ` Anna Schumaker
2021-02-02 19:24     ` Dan Aloni
2021-02-02 19:46       ` Chuck Lever
2021-02-02 19:51         ` Anna Schumaker
2021-02-02 19:49       ` Benjamin Coddington
2021-02-02 22:17         ` Trond Myklebust
2021-02-02 22:21           ` Chuck Lever
2021-02-02 22:24             ` Trond Myklebust
2021-02-02 22:31               ` Chuck Lever
2021-02-03 21:20         ` Dan Aloni
2021-02-14 17:41           ` Dan Aloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210202184244.288898-5-Anna.Schumaker@Netapp.com \
    --to=schumaker.anna@gmail.com \
    --cc=Anna.Schumaker@Netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.