All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PULL 1/9] monitor/qmp-cmds.c: Don't include ui/vnc.h
Date: Thu,  4 Feb 2021 15:01:28 +0100	[thread overview]
Message-ID: <20210204140136.2769065-2-armbru@redhat.com> (raw)
In-Reply-To: <20210204140136.2769065-1-armbru@redhat.com>

From: Peter Maydell <peter.maydell@linaro.org>

The qmp-cmds.c file currently includes ui/vnc.h, which (being located
in the ui/ directory rather than include) is really supposed to be
for use only by the ui subsystem.  In fact the function prototypes we
need (vnc_display_password(), etc) are all declared in
include/ui/console.h, so we can switch to including that instead.

(ui/vnc.h includes include/ui/console.h, so this change strictly
reduces the quantity of headers qmp-cmds.c pulls in.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20210104161200.15068-1-peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 monitor/qmp-cmds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/qmp-cmds.c b/monitor/qmp-cmds.c
index 990936136c..c7df8c0ee2 100644
--- a/monitor/qmp-cmds.c
+++ b/monitor/qmp-cmds.c
@@ -23,7 +23,7 @@
 #include "qemu/uuid.h"
 #include "chardev/char.h"
 #include "ui/qemu-spice.h"
-#include "ui/vnc.h"
+#include "ui/console.h"
 #include "sysemu/kvm.h"
 #include "sysemu/runstate.h"
 #include "sysemu/runstate-action.h"
-- 
2.26.2



  reply	other threads:[~2021-02-04 14:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 14:01 [PULL 0/9] QMP patches patches for 2021-02-04 Markus Armbruster
2021-02-04 14:01 ` Markus Armbruster [this message]
2021-02-04 14:01 ` [PULL 2/9] qobject: open brace '{' following struct go on the same line Markus Armbruster
2021-02-04 14:01 ` [PULL 3/9] qobject: code indent should never use tabs Markus Armbruster
2021-02-04 14:01 ` [PULL 4/9] qobject: spaces required around that operators Markus Armbruster
2021-02-04 14:01 ` [PULL 5/9] qobject: braces {} are necessary for all arms of this statement Markus Armbruster
2021-02-04 14:01 ` [PULL 6/9] docs/interop/qmp-spec: Document the request queue limit Markus Armbruster
2021-02-04 14:01 ` [PULL 7/9] qmp: Fix up comments after commit 9ce44e2ce2 Markus Armbruster
2021-02-04 14:01 ` [PULL 8/9] qmp: Add more tracepoints Markus Armbruster
2021-02-04 14:01 ` [PULL 9/9] qmp: Resume OOB-enabled monitor before processing the request Markus Armbruster
2021-02-04 15:12 ` [PULL 0/9] QMP patches patches for 2021-02-04 no-reply
2021-02-04 15:19 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204140136.2769065-2-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.