From: Lukas Bulwahn <lukas.bulwahn@gmail.com> To: Christian Brauner <christian.brauner@ubuntu.com>, linux-fsdevel@vger.kernel.org Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, linux-doc@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn <lukas.bulwahn@gmail.com> Subject: [PATCH 2/5] fs: update kernel-doc for vfs_rename() Date: Thu, 4 Feb 2021 19:00:56 +0100 [thread overview] Message-ID: <20210204180059.28360-3-lukas.bulwahn@gmail.com> (raw) In-Reply-To: <20210204180059.28360-1-lukas.bulwahn@gmail.com> Commit 9fe61450972d ("namei: introduce struct renamedata") introduces a new struct for vfs_rename() and makes the vfs_rename() kernel-doc argument description out of sync. Move the description of arguments for vfs_rename() to a new kernel-doc for the struct renamedata to make these descriptions checkable against the actual implementation. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- fs/namei.c | 9 +-------- include/linux/fs.h | 11 +++++++++++ 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index f131d3efec63..98ea56ebcaf0 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -4406,14 +4406,7 @@ SYSCALL_DEFINE2(link, const char __user *, oldname, const char __user *, newname /** * vfs_rename - rename a filesystem object - * @old_mnt_userns: old user namespace of the mount the inode was found from - * @old_dir: parent of source - * @old_dentry: source - * @new_mnt_userns: new user namespace of the mount the inode was found from - * @new_dir: parent of destination - * @new_dentry: destination - * @delegated_inode: returns an inode needing a delegation break - * @flags: rename flags + * @rd: struct with all information required for renaming * * The caller must hold multiple mutexes--see lock_rename()). * diff --git a/include/linux/fs.h b/include/linux/fs.h index 04b6b142dfcf..52b6d9e34b92 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1782,6 +1782,17 @@ int vfs_rmdir(struct user_namespace *, struct inode *, struct dentry *); int vfs_unlink(struct user_namespace *, struct inode *, struct dentry *, struct inode **); +/** + * struct renamedata - contains all information required for renaming + * @old_mnt_userns: old user namespace of the mount the inode was found from + * @old_dir: parent of source + * @old_dentry: source + * @new_mnt_userns: new user namespace of the mount the inode was found from + * @new_dir: parent of destination + * @new_dentry: destination + * @delegated_inode: returns an inode needing a delegation break + * @flags: rename flags + */ struct renamedata { struct user_namespace *old_mnt_userns; struct inode *old_dir; -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Lukas Bulwahn <lukas.bulwahn@gmail.com> To: Christian Brauner <christian.brauner@ubuntu.com>, linux-fsdevel@vger.kernel.org Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, linux-doc@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn <lukas.bulwahn@gmail.com> Subject: [PATCH 2/5] fs: update kernel-doc for vfs_rename() Date: Thu, 04 Feb 2021 18:00:56 +0000 [thread overview] Message-ID: <20210204180059.28360-3-lukas.bulwahn@gmail.com> (raw) In-Reply-To: <20210204180059.28360-1-lukas.bulwahn@gmail.com> Commit 9fe61450972d ("namei: introduce struct renamedata") introduces a new struct for vfs_rename() and makes the vfs_rename() kernel-doc argument description out of sync. Move the description of arguments for vfs_rename() to a new kernel-doc for the struct renamedata to make these descriptions checkable against the actual implementation. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- fs/namei.c | 9 +-------- include/linux/fs.h | 11 +++++++++++ 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index f131d3efec63..98ea56ebcaf0 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -4406,14 +4406,7 @@ SYSCALL_DEFINE2(link, const char __user *, oldname, const char __user *, newname /** * vfs_rename - rename a filesystem object - * @old_mnt_userns: old user namespace of the mount the inode was found from - * @old_dir: parent of source - * @old_dentry: source - * @new_mnt_userns: new user namespace of the mount the inode was found from - * @new_dir: parent of destination - * @new_dentry: destination - * @delegated_inode: returns an inode needing a delegation break - * @flags: rename flags + * @rd: struct with all information required for renaming * * The caller must hold multiple mutexes--see lock_rename()). * diff --git a/include/linux/fs.h b/include/linux/fs.h index 04b6b142dfcf..52b6d9e34b92 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1782,6 +1782,17 @@ int vfs_rmdir(struct user_namespace *, struct inode *, struct dentry *); int vfs_unlink(struct user_namespace *, struct inode *, struct dentry *, struct inode **); +/** + * struct renamedata - contains all information required for renaming + * @old_mnt_userns: old user namespace of the mount the inode was found from + * @old_dir: parent of source + * @old_dentry: source + * @new_mnt_userns: new user namespace of the mount the inode was found from + * @new_dir: parent of destination + * @new_dentry: destination + * @delegated_inode: returns an inode needing a delegation break + * @flags: rename flags + */ struct renamedata { struct user_namespace *old_mnt_userns; struct inode *old_dir; -- 2.17.1
next prev parent reply other threads:[~2021-02-04 18:03 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-04 18:00 [PATCH 0/5] kernel-doc fixes to latest fs changes Lukas Bulwahn 2021-02-04 18:00 ` Lukas Bulwahn 2021-02-04 18:00 ` [PATCH 1/5] fs: turn some comments into kernel-doc Lukas Bulwahn 2021-02-04 18:00 ` Lukas Bulwahn 2021-02-04 18:00 ` Lukas Bulwahn [this message] 2021-02-04 18:00 ` [PATCH 2/5] fs: update kernel-doc for vfs_rename() Lukas Bulwahn 2021-02-04 18:00 ` [PATCH 3/5] fs: update kernel-doc for may_create_in_sticky() Lukas Bulwahn 2021-02-04 18:00 ` Lukas Bulwahn 2021-02-04 18:00 ` [PATCH 4/5] fs: update kernel-doc for vfs_tmpfile() Lukas Bulwahn 2021-02-04 18:00 ` Lukas Bulwahn 2021-02-04 18:00 ` [PATCH 5/5] fs: update kernel-doc for new mnt_userns argument Lukas Bulwahn 2021-02-04 18:00 ` Lukas Bulwahn 2021-03-01 12:51 ` [PATCH 0/5] kernel-doc fixes to latest fs changes Christian Brauner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210204180059.28360-3-lukas.bulwahn@gmail.com \ --to=lukas.bulwahn@gmail.com \ --cc=christian.brauner@ubuntu.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mchehab+huawei@kernel.org \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.