From: Xulin Sun <xulin.sun@windriver.com>
To: wg@grandegger.com, mkl@pengutronix.de
Cc: dmurphy@ti.com, sriram.dash@samsung.com, kuba@kernel.org,
davem@davemloft.net, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
xulin.sun@windriver.com, xulinsun@gmail.com
Subject: [PATCH 2/2] can: m_can: m_can_class_allocate_dev(): remove impossible error return judgment
Date: Fri, 5 Feb 2021 15:25:59 +0800 [thread overview]
Message-ID: <20210205072559.13241-2-xulin.sun@windriver.com> (raw)
In-Reply-To: <20210205072559.13241-1-xulin.sun@windriver.com>
If the previous can_net device has been successfully allocated, its
private data structure is impossible to be empty, remove this redundant
error return judgment. Otherwise, memory leaks for alloc_candev() will
be triggered.
Signed-off-by: Xulin Sun <xulin.sun@windriver.com>
---
drivers/net/can/m_can/m_can.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 02c5795b7393..042940088d41 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -1797,11 +1797,6 @@ struct m_can_classdev *m_can_class_allocate_dev(struct device *dev)
}
class_dev = netdev_priv(net_dev);
- if (!class_dev) {
- dev_err(dev, "Failed to init netdev cdevate");
- goto out;
- }
-
class_dev->net = net_dev;
class_dev->dev = dev;
SET_NETDEV_DEV(net_dev, dev);
--
2.17.1
next prev parent reply other threads:[~2021-02-05 7:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 7:25 [PATCH 1/2] can: m_can: m_can_plat_probe(): free can_net device in case probe fails Xulin Sun
2021-02-05 7:25 ` Xulin Sun [this message]
2021-02-05 8:19 ` [PATCH 2/2] can: m_can: m_can_class_allocate_dev(): remove impossible error return judgment Marc Kleine-Budde
2021-02-05 8:46 ` Xulin Sun
2021-02-05 8:52 ` Marc Kleine-Budde
2021-02-05 8:05 ` [PATCH 1/2] can: m_can: m_can_plat_probe(): free can_net device in case probe fails Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205072559.13241-2-xulin.sun@windriver.com \
--to=xulin.sun@windriver.com \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=sriram.dash@samsung.com \
--cc=wg@grandegger.com \
--cc=xulinsun@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.