All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
	Dave Airlie <airlied@gmail.com>,
	greg.depoire@gmail.com, Ben Skeggs <bskeggs@redhat.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	linux-kernel@vger.kernel.org (open list)
Subject: [RFC v3 02/10] drm/nouveau/kms: Don't probe eDP connectors more then once
Date: Fri,  5 Feb 2021 18:45:06 -0500	[thread overview]
Message-ID: <20210205234515.1216538-3-lyude@redhat.com> (raw)
In-Reply-To: <20210205234515.1216538-1-lyude@redhat.com>

eDP doesn't do hotplugging, so there's no reason for us to reprobe it (unless a
connection status change is being forced, of course).

Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Dave Airlie <airlied@gmail.com>
Cc: greg.depoire@gmail.com
---
 drivers/gpu/drm/nouveau/nouveau_connector.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index 61e6d7412505..55e986b3cad9 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -556,6 +556,12 @@ nouveau_connector_detect(struct drm_connector *connector, bool force)
 	int ret;
 	enum drm_connector_status conn_status = connector_status_disconnected;
 
+	/* eDP doesn't do hotplugging, never probe more then once */
+	if (nv_connector->type == DCB_CONNECTOR_eDP &&
+	    connector->force == DRM_FORCE_UNSPECIFIED &&
+	    connector->status != connector_status_unknown)
+		return connector->status;
+
 	/* Outputs are only polled while runtime active, so resuming the
 	 * device here is unnecessary (and would deadlock upon runtime suspend
 	 * because it waits for polling to finish). We do however, want to
-- 
2.29.2


WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
	David Airlie <airlied@linux.ie>,
	open list <linux-kernel@vger.kernel.org>,
	greg.depoire@gmail.com, Ben Skeggs <bskeggs@redhat.com>,
	Daniel Vetter <daniel@ffwll.ch>
Subject: [Nouveau] [RFC v3 02/10] drm/nouveau/kms: Don't probe eDP connectors more then once
Date: Fri,  5 Feb 2021 18:45:06 -0500	[thread overview]
Message-ID: <20210205234515.1216538-3-lyude@redhat.com> (raw)
In-Reply-To: <20210205234515.1216538-1-lyude@redhat.com>

eDP doesn't do hotplugging, so there's no reason for us to reprobe it (unless a
connection status change is being forced, of course).

Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Dave Airlie <airlied@gmail.com>
Cc: greg.depoire@gmail.com
---
 drivers/gpu/drm/nouveau/nouveau_connector.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index 61e6d7412505..55e986b3cad9 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -556,6 +556,12 @@ nouveau_connector_detect(struct drm_connector *connector, bool force)
 	int ret;
 	enum drm_connector_status conn_status = connector_status_disconnected;
 
+	/* eDP doesn't do hotplugging, never probe more then once */
+	if (nv_connector->type == DCB_CONNECTOR_eDP &&
+	    connector->force == DRM_FORCE_UNSPECIFIED &&
+	    connector->status != connector_status_unknown)
+		return connector->status;
+
 	/* Outputs are only polled while runtime active, so resuming the
 	 * device here is unnecessary (and would deadlock upon runtime suspend
 	 * because it waits for polling to finish). We do however, want to
-- 
2.29.2

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
	David Airlie <airlied@linux.ie>,
	open list <linux-kernel@vger.kernel.org>,
	greg.depoire@gmail.com, Ben Skeggs <bskeggs@redhat.com>
Subject: [RFC v3 02/10] drm/nouveau/kms: Don't probe eDP connectors more then once
Date: Fri,  5 Feb 2021 18:45:06 -0500	[thread overview]
Message-ID: <20210205234515.1216538-3-lyude@redhat.com> (raw)
In-Reply-To: <20210205234515.1216538-1-lyude@redhat.com>

eDP doesn't do hotplugging, so there's no reason for us to reprobe it (unless a
connection status change is being forced, of course).

Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Dave Airlie <airlied@gmail.com>
Cc: greg.depoire@gmail.com
---
 drivers/gpu/drm/nouveau/nouveau_connector.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index 61e6d7412505..55e986b3cad9 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -556,6 +556,12 @@ nouveau_connector_detect(struct drm_connector *connector, bool force)
 	int ret;
 	enum drm_connector_status conn_status = connector_status_disconnected;
 
+	/* eDP doesn't do hotplugging, never probe more then once */
+	if (nv_connector->type == DCB_CONNECTOR_eDP &&
+	    connector->force == DRM_FORCE_UNSPECIFIED &&
+	    connector->status != connector_status_unknown)
+		return connector->status;
+
 	/* Outputs are only polled while runtime active, so resuming the
 	 * device here is unnecessary (and would deadlock upon runtime suspend
 	 * because it waits for polling to finish). We do however, want to
-- 
2.29.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
	David Airlie <airlied@linux.ie>,
	open list <linux-kernel@vger.kernel.org>,
	greg.depoire@gmail.com, Ben Skeggs <bskeggs@redhat.com>
Subject: [Intel-gfx] [RFC v3 02/10] drm/nouveau/kms: Don't probe eDP connectors more then once
Date: Fri,  5 Feb 2021 18:45:06 -0500	[thread overview]
Message-ID: <20210205234515.1216538-3-lyude@redhat.com> (raw)
In-Reply-To: <20210205234515.1216538-1-lyude@redhat.com>

eDP doesn't do hotplugging, so there's no reason for us to reprobe it (unless a
connection status change is being forced, of course).

Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Dave Airlie <airlied@gmail.com>
Cc: greg.depoire@gmail.com
---
 drivers/gpu/drm/nouveau/nouveau_connector.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index 61e6d7412505..55e986b3cad9 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -556,6 +556,12 @@ nouveau_connector_detect(struct drm_connector *connector, bool force)
 	int ret;
 	enum drm_connector_status conn_status = connector_status_disconnected;
 
+	/* eDP doesn't do hotplugging, never probe more then once */
+	if (nv_connector->type == DCB_CONNECTOR_eDP &&
+	    connector->force == DRM_FORCE_UNSPECIFIED &&
+	    connector->status != connector_status_unknown)
+		return connector->status;
+
 	/* Outputs are only polled while runtime active, so resuming the
 	 * device here is unnecessary (and would deadlock upon runtime suspend
 	 * because it waits for polling to finish). We do however, want to
-- 
2.29.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-02-06  3:57 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 23:45 [Nouveau] [RFC v3 00/10] drm: Extract DPCD backlight helpers from i915, add support in nouveau Lyude Paul
2021-02-05 23:45 ` [Intel-gfx] " Lyude Paul
2021-02-05 23:45 ` Lyude Paul
2021-02-05 23:45 ` [RFC v3 01/10] drm/nouveau/kms/nv40-/backlight: Assign prop type once Lyude Paul
2021-02-05 23:45   ` [Intel-gfx] " Lyude Paul
2021-02-05 23:45   ` Lyude Paul
2021-02-05 23:45   ` [Nouveau] " Lyude Paul
2021-02-05 23:45 ` Lyude Paul [this message]
2021-02-05 23:45   ` [Intel-gfx] [RFC v3 02/10] drm/nouveau/kms: Don't probe eDP connectors more then once Lyude Paul
2021-02-05 23:45   ` Lyude Paul
2021-02-05 23:45   ` [Nouveau] " Lyude Paul
2021-02-05 23:45 ` [RFC v3 03/10] drm/i915/dpcd_bl: Remove redundant AUX backlight frequency calculations Lyude Paul
2021-02-05 23:45   ` [Intel-gfx] " Lyude Paul
2021-02-05 23:45   ` Lyude Paul
2021-02-05 23:45   ` [Nouveau] " Lyude Paul
2021-02-05 23:45 ` [RFC v3 04/10] drm/i915/dpcd_bl: Handle drm_dpcd_read/write() return values correctly Lyude Paul
2021-02-05 23:45   ` [Intel-gfx] " Lyude Paul
2021-02-05 23:45   ` Lyude Paul
2021-02-05 23:45   ` [Nouveau] " Lyude Paul
2021-02-08 11:11   ` Rodrigo Vivi
2021-02-08 11:11     ` [Intel-gfx] " Rodrigo Vivi
2021-02-08 11:11     ` Rodrigo Vivi
2021-02-08 11:11     ` [Nouveau] " Rodrigo Vivi
2021-02-05 23:45 ` [RFC v3 05/10] drm/i915/dpcd_bl: Cleanup intel_dp_aux_vesa_enable_backlight() a bit Lyude Paul
2021-02-05 23:45   ` [Intel-gfx] " Lyude Paul
2021-02-05 23:45   ` Lyude Paul
2021-02-05 23:45   ` [Nouveau] " Lyude Paul
2021-02-06  0:07   ` Ilia Mirkin
2021-02-06  0:07     ` [Intel-gfx] " Ilia Mirkin
2021-02-06  0:07     ` Ilia Mirkin
2021-02-06  0:07     ` Ilia Mirkin
2021-02-05 23:45 ` [RFC v3 06/10] drm/i915/dpcd_bl: Cache some backlight capabilities in intel_panel.backlight Lyude Paul
2021-02-05 23:45   ` [Intel-gfx] " Lyude Paul
2021-02-05 23:45   ` Lyude Paul
2021-02-05 23:45   ` [Nouveau] " Lyude Paul
2021-02-08 11:13   ` Rodrigo Vivi
2021-02-08 11:13     ` [Intel-gfx] " Rodrigo Vivi
2021-02-08 11:13     ` Rodrigo Vivi
2021-02-08 11:13     ` [Nouveau] " Rodrigo Vivi
2021-02-05 23:45 ` [RFC v3 07/10] drm/i915/dpcd_bl: Move VESA backlight enabling code closer together Lyude Paul
2021-02-05 23:45   ` [Intel-gfx] " Lyude Paul
2021-02-05 23:45   ` Lyude Paul
2021-02-05 23:45   ` [Nouveau] " Lyude Paul
2021-02-08 11:14   ` Rodrigo Vivi
2021-02-08 11:14     ` [Intel-gfx] " Rodrigo Vivi
2021-02-08 11:14     ` Rodrigo Vivi
2021-02-08 11:14     ` [Nouveau] " Rodrigo Vivi
2021-02-05 23:45 ` [RFC v3 08/10] drm/i915/dpcd_bl: Return early in vesa_calc_max_backlight if we can't read PWMGEN_BIT_COUNT Lyude Paul
2021-02-05 23:45   ` [Intel-gfx] " Lyude Paul
2021-02-05 23:45   ` Lyude Paul
2021-02-05 23:45   ` [Nouveau] " Lyude Paul
2021-02-05 23:45 ` [RFC v3 09/10] drm/i915/dpcd_bl: Print return codes for VESA backlight failures Lyude Paul
2021-02-05 23:45   ` [Intel-gfx] " Lyude Paul
2021-02-05 23:45   ` Lyude Paul
2021-02-05 23:45   ` [Nouveau] " Lyude Paul
2021-02-05 23:45 ` [RFC v3 10/10] drm/dp: Extract i915's eDP backlight code into DRM helpers Lyude Paul
2021-02-05 23:45   ` [Intel-gfx] " Lyude Paul
2021-02-05 23:45   ` Lyude Paul
2021-02-05 23:45   ` [Nouveau] " Lyude Paul
2021-02-08  8:46   ` Thomas Zimmermann
2021-02-08  8:46     ` [Intel-gfx] " Thomas Zimmermann
2021-02-08  8:46     ` Thomas Zimmermann
2021-02-08  8:46     ` [Nouveau] " Thomas Zimmermann
2021-02-08 23:03     ` Lyude Paul
2021-02-08 23:03       ` [Intel-gfx] " Lyude Paul
2021-02-08 23:03       ` Lyude Paul
2021-02-08 23:03       ` [Nouveau] " Lyude Paul
2021-02-15 18:34       ` Thomas Zimmermann
2021-02-15 18:34         ` [Intel-gfx] " Thomas Zimmermann
2021-02-15 18:34         ` Thomas Zimmermann
2021-02-15 18:34         ` [Nouveau] " Thomas Zimmermann
2021-02-15 20:26         ` Lyude Paul
2021-02-15 20:26           ` [Intel-gfx] " Lyude Paul
2021-02-15 20:26           ` Lyude Paul
2021-02-15 20:26           ` [Nouveau] " Lyude Paul
2021-02-06  2:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev5) Patchwork
2021-02-06  2:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-02-06 15:09 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-02-08 22:52 ` [Nouveau] [RFC v3 00/10] drm: Extract DPCD backlight helpers from i915, add support in nouveau Lyude Paul
2021-02-08 22:52   ` [Intel-gfx] " Lyude Paul
2021-02-08 22:52   ` Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210205234515.1216538-3-lyude@redhat.com \
    --to=lyude@redhat.com \
    --cc=airlied@gmail.com \
    --cc=airlied@linux.ie \
    --cc=bskeggs@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=greg.depoire@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.