All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>
Subject: [PULL 01/18] tests/acceptance: Extract tesseract_available() helper in new namespace
Date: Mon,  8 Feb 2021 14:36:54 +0100	[thread overview]
Message-ID: <20210208133711.2596075-2-philmd@redhat.com> (raw)
In-Reply-To: <20210208133711.2596075-1-philmd@redhat.com>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

We are going to reuse tesseract_available(). Extract it to
a new 'tesseract_utils' namespace.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201021105035.2477784-4-f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 tests/acceptance/machine_m68k_nextcube.py | 25 +++-----------------
 tests/acceptance/tesseract_utils.py       | 28 +++++++++++++++++++++++
 2 files changed, 31 insertions(+), 22 deletions(-)
 create mode 100644 tests/acceptance/tesseract_utils.py

diff --git a/tests/acceptance/machine_m68k_nextcube.py b/tests/acceptance/machine_m68k_nextcube.py
index 2baba5fdc26..3c7400c43e4 100644
--- a/tests/acceptance/machine_m68k_nextcube.py
+++ b/tests/acceptance/machine_m68k_nextcube.py
@@ -1,19 +1,19 @@
 # Functional test that boots a VM and run OCR on the framebuffer
 #
-# Copyright (c) Philippe Mathieu-Daudé <f4bug@amsat.org>
+# Copyright (c) 2019 Philippe Mathieu-Daudé <f4bug@amsat.org>
 #
 # This work is licensed under the terms of the GNU GPL, version 2 or
 # later.  See the COPYING file in the top-level directory.
 
 import os
-import re
 import time
 import logging
 
 from avocado_qemu import Test
 from avocado import skipUnless
 from avocado.utils import process
-from avocado.utils.path import find_command, CmdNotFoundError
+
+from tesseract_utils import tesseract_available
 
 PIL_AVAILABLE = True
 try:
@@ -22,25 +22,6 @@
     PIL_AVAILABLE = False
 
 
-def tesseract_available(expected_version):
-    try:
-        find_command('tesseract')
-    except CmdNotFoundError:
-        return False
-    res = process.run('tesseract --version')
-    try:
-        version = res.stdout_text.split()[1]
-    except IndexError:
-        version = res.stderr_text.split()[1]
-    return int(version.split('.')[0]) == expected_version
-
-    match = re.match(r'tesseract\s(\d)', res)
-    if match is None:
-        return False
-    # now this is guaranteed to be a digit
-    return int(match.groups()[0]) == expected_version
-
-
 class NextCubeMachine(Test):
     """
     :avocado: tags=arch:m68k
diff --git a/tests/acceptance/tesseract_utils.py b/tests/acceptance/tesseract_utils.py
new file mode 100644
index 00000000000..acd6e8c2faa
--- /dev/null
+++ b/tests/acceptance/tesseract_utils.py
@@ -0,0 +1,28 @@
+# ...
+#
+# Copyright (c) 2019 Philippe Mathieu-Daudé <f4bug@amsat.org>
+#
+# This work is licensed under the terms of the GNU GPL, version 2 or
+# later. See the COPYING file in the top-level directory.
+
+import re
+
+from avocado.utils.path import find_command, CmdNotFoundError
+
+def tesseract_available(expected_version):
+    try:
+        find_command('tesseract')
+    except CmdNotFoundError:
+        return False
+    res = process.run('tesseract --version')
+    try:
+        version = res.stdout_text.split()[1]
+    except IndexError:
+        version = res.stderr_text.split()[1]
+    return int(version.split('.')[0]) == expected_version
+
+    match = re.match(r'tesseract\s(\d)', res)
+    if match is None:
+        return False
+    # now this is guaranteed to be a digit
+    return int(match.groups()[0]) == expected_version
-- 
2.26.2



  reply	other threads:[~2021-02-08 19:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08 13:36 [PULL 00/18] Integration testing patches for 2021-02-08 Philippe Mathieu-Daudé
2021-02-08 13:36 ` Philippe Mathieu-Daudé [this message]
2021-02-08 13:36 ` [PULL 02/18] tests/acceptance: Introduce tesseract_ocr() helper Philippe Mathieu-Daudé
2021-02-08 13:36 ` [PULL 03/18] tests/acceptance: Extract do_test_arm_orangepi_armbian_uboot() method Philippe Mathieu-Daudé
2021-02-08 13:36 ` [PULL 04/18] tests/acceptance: Test U-Boot/Linux from Armbian 20.08 on Orange Pi PC Philippe Mathieu-Daudé
2021-02-08 13:36 ` [PULL 05/18] tests/acceptance: Move the pseries test to a separate file Philippe Mathieu-Daudé
2021-02-08 13:36 ` [PULL 06/18] tests/acceptance: Test the mpc8544ds machine Philippe Mathieu-Daudé
2021-02-08 13:37 ` [PULL 07/18] tests/acceptance: Add a test for the virtex-ml507 ppc machine Philippe Mathieu-Daudé
2021-02-08 13:37 ` [PULL 08/18] tests/acceptance: Increase the timeout in the replay tests Philippe Mathieu-Daudé
2021-02-08 13:37 ` [PULL 09/18] tests/acceptance: Re-enable the microblaze test Philippe Mathieu-Daudé
2021-02-08 13:37 ` [PULL 10/18] tests/acceptance/boot_linux: fix typo on cloudinit error message Philippe Mathieu-Daudé
2021-02-08 13:37 ` [PULL 11/18] tests/acceptance/boot_linux: rename misleading cloudinit method Philippe Mathieu-Daudé
2021-02-08 13:37 ` [PULL 12/18] tests/acceptance/virtiofs_submounts: use workdir property Philippe Mathieu-Daudé
2021-02-08 13:37 ` [PULL 13/18] tests/acceptance/virtiofs_submounts: do not ask for ssh key password Philippe Mathieu-Daudé
2021-02-08 13:37 ` [PULL 14/18] tests/acceptance/virtiofs_submounts: use a virtio-net device instead Philippe Mathieu-Daudé
2021-02-08 13:37 ` [PULL 15/18] tests/acceptance/virtiofs_submounts: standardize port as integer Philippe Mathieu-Daudé
2021-02-08 13:37 ` [PULL 16/18] tests/acceptance/virtiofs_submounts: required space between IP and port Philippe Mathieu-Daudé
2021-02-08 13:37 ` [PULL 17/18] Acceptance tests: clarify ssh connection failure reason Philippe Mathieu-Daudé
2021-02-08 13:37 ` [PULL 18/18] Acceptance Tests: remove unnecessary tag from documentation example Philippe Mathieu-Daudé
2021-02-08 20:06 ` [PULL 00/18] Integration testing patches for 2021-02-08 Peter Maydell
2021-02-08 20:21   ` Philippe Mathieu-Daudé
2021-02-09 10:04     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210208133711.2596075-2-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=crosa@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.