All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: David Ahern <dsahern@gmail.com>, netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@idosch.org>,
	DENG Qingfang <dqfext@gmail.com>,
	Tobias Waldekranz <tobias@waldekranz.com>,
	Roopa Prabhu <roopa@nvidia.com>,
	Nikolay Aleksandrov <nikolay@nvidia.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH iproute2 4/6] man8/bridge.8: fix which one of self/master is default for "bridge fdb"
Date: Thu, 11 Feb 2021 12:45:00 +0200	[thread overview]
Message-ID: <20210211104502.2081443-5-olteanv@gmail.com> (raw)
In-Reply-To: <20210211104502.2081443-1-olteanv@gmail.com>

From: Vladimir Oltean <vladimir.oltean@nxp.com>

The bridge program does:

fdb_modify:
	/* Assume self */
	if (!(req.ndm.ndm_flags&(NTF_SELF|NTF_MASTER)))
		req.ndm.ndm_flags |= NTF_SELF;

which is clearly against the documented behavior. The only thing we can
do, sadly, is update the documentation.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 man/man8/bridge.8 | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
index b629c52b8341..1dc0aec83f09 100644
--- a/man/man8/bridge.8
+++ b/man/man8/bridge.8
@@ -533,11 +533,12 @@ specified.
 .sp
 
 .B self
-- the address is associated with the port drivers fdb. Usually hardware.
+- the address is associated with the port drivers fdb. Usually hardware
+  (default).
 .sp
 
 .B master
-- the address is associated with master devices fdb. Usually software (default).
+- the address is associated with master devices fdb. Usually software.
 .sp
 
 .B router
-- 
2.25.1


  parent reply	other threads:[~2021-02-11 10:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11 10:44 [PATCH iproute2 0/6] Clarifications to bridge man page Vladimir Oltean
2021-02-11 10:44 ` [PATCH iproute2 1/6] man8/bridge.8: document the "permanent" flag for "bridge fdb add" Vladimir Oltean
2021-02-11 10:44 ` [PATCH iproute2 2/6] man8/bridge.8: document that "local" is default " Vladimir Oltean
2021-02-11 10:44 ` [PATCH iproute2 3/6] man8/bridge.8: explain what a local FDB entry is Vladimir Oltean
2021-02-11 10:45 ` Vladimir Oltean [this message]
2021-02-11 10:45 ` [PATCH iproute2 5/6] man8/bridge.8: explain self vs master for "bridge fdb add" Vladimir Oltean
2021-02-15  8:22   ` Alexandra Winter
2021-02-15 10:32     ` Vladimir Oltean
2021-02-15 10:53       ` Alexandra Winter
2021-02-15 12:13         ` Vladimir Oltean
2021-02-15 12:33           ` Alexandra Winter
2021-02-11 10:45 ` [PATCH iproute2 6/6] man8/bridge.8: be explicit that "flood" is an egress setting Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210211104502.2081443-5-olteanv@gmail.com \
    --to=olteanv@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=dqfext@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@idosch.org \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@nvidia.com \
    --cc=roopa@nvidia.com \
    --cc=stephen@networkplumber.org \
    --cc=tobias@waldekranz.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.