All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Smart <jsmart2021@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: James Smart <jsmart2021@gmail.com>,
	Dick Kennedy <dick.kennedy@broadcom.com>
Subject: [PATCH 06/22] lpfc: Fix lpfc_els_retry() possible null pointer dereference
Date: Thu, 11 Feb 2021 15:44:27 -0800	[thread overview]
Message-ID: <20210211234443.3107-7-jsmart2021@gmail.com> (raw)
In-Reply-To: <20210211234443.3107-1-jsmart2021@gmail.com>

Driver crashed in lpfc_debugfs_disc_trc() due to null ndlp pointer.
In some calling cases, the ndlp is null and the did is looked up.

Fix by using the local did variable that is set appropriately based
on ndlp value.

Co-developed-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
---
 drivers/scsi/lpfc/lpfc_els.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index 780b4c1e98eb..788cb5d9054c 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -3823,7 +3823,7 @@ lpfc_els_retry(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
 
 	lpfc_debugfs_disc_trc(vport, LPFC_DISC_TRC_ELS_CMD,
 		"Retry ELS:       wd7:x%x wd4:x%x did:x%x",
-		*(((uint32_t *) irsp) + 7), irsp->un.ulpWord[4], ndlp->nlp_DID);
+		*(((uint32_t *)irsp) + 7), irsp->un.ulpWord[4], did);
 
 	switch (irsp->ulpStatus) {
 	case IOSTAT_FCP_RSP_ERROR:
-- 
2.26.2


  parent reply	other threads:[~2021-02-11 23:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11 23:44 [PATCH 00/22] lpfc: Update lpfc to revision 12.8.0.8 James Smart
2021-02-11 23:44 ` [PATCH 01/22] lpfc: Fix incorrect dbde assignment when building target abts wqe James Smart
2021-02-11 23:44 ` [PATCH 02/22] lpfc: Fix vport indices in lpfc_find_vport_by_vpid() James Smart
2021-02-11 23:44 ` [PATCH 03/22] lpfc: Fix reftag generation sizing errors James Smart
2021-02-26  3:08   ` Martin K. Petersen
2021-02-11 23:44 ` [PATCH 04/22] lpfc: Fix stale node accesses on stale RRQ request James Smart
2021-02-11 23:44 ` [PATCH 05/22] lpfc: Fix FLOGI failure due to accessing a freed node James Smart
2021-02-11 23:44 ` James Smart [this message]
2021-02-11 23:44 ` [PATCH 07/22] lpfc: Fix pt2pt connection does not recover after LOGO James Smart
2021-02-11 23:44 ` [PATCH 08/22] lpfc: Fix unnecessary null check in lpfc_release_scsi_buf James Smart
2021-02-11 23:44 ` [PATCH 09/22] lpfc: Fix null pointer dereference in lpfc_prep_els_iocb() James Smart
2021-02-11 23:44 ` [PATCH 10/22] lpfc: Fix use after free in lpfc_els_free_iocb James Smart
2021-02-11 23:44 ` [PATCH 11/22] lpfc: Fix status returned in lpfc_els_retry() error exit path James Smart
2021-02-11 23:44 ` [PATCH 12/22] lpfc: Fix dropped FLOGI during pt2pt discovery recovery James Smart
2021-02-11 23:44 ` [PATCH 13/22] lpfc: Fix PLOGI ACC to be transmit after REG_LOGIN James Smart
2021-02-11 23:44 ` [PATCH 14/22] lpfc: Fix ADISC handling that never frees nodes James Smart
2021-02-11 23:44 ` [PATCH 15/22] lpfc: Fix nodeinfo debugfs output James Smart
2021-02-11 23:44 ` [PATCH 16/22] lpfc: Fix pt2pt state transition causing rmmod hang James Smart
2021-02-11 23:44 ` [PATCH 17/22] lpfc: Fix crash caused by switch reboot James Smart
2021-02-11 23:44 ` [PATCH 18/22] lpfc: Change wording of invalid pci reset log message James Smart
2021-02-11 23:44 ` [PATCH 19/22] lpfc: Reduce LOG_TRACE_EVENT logging for vports James Smart
2021-02-11 23:44 ` [PATCH 20/22] lpfc: Correct function header comments related to ndlp reference counting James Smart
2021-02-11 23:44 ` [PATCH 21/22] lpfc: Update lpfc version to 12.8.0.8 James Smart
2021-02-11 23:44 ` [PATCH 22/22] lpfc: update copyrights for 12.8.0.7 and 12.8.0.8 changes James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210211234443.3107-7-jsmart2021@gmail.com \
    --to=jsmart2021@gmail.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.