All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com
Subject: [PATCH 2/2] monitor/qmp: Stop processing requests when shutdown is requested
Date: Fri, 12 Feb 2021 18:20:28 +0100	[thread overview]
Message-ID: <20210212172028.288825-3-kwolf@redhat.com> (raw)
In-Reply-To: <20210212172028.288825-1-kwolf@redhat.com>

monitor_qmp_dispatcher_co() used to check whether shutdown is requested
only when it would have to wait for new requests. If there were still
some queued requests, it would try to execute all of them before
shutting down.

This can be surprising when the queued QMP commands take long or hang
because Ctrl-C may not actually exit QEMU as soon as possible.

Change monitor_qmp_dispatcher_co() so that it additionally checks
whether shutdown is request before it gets a new request from the queue.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 monitor/qmp.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/monitor/qmp.c b/monitor/qmp.c
index 43880fa623..2326bd7f9b 100644
--- a/monitor/qmp.c
+++ b/monitor/qmp.c
@@ -227,6 +227,11 @@ void coroutine_fn monitor_qmp_dispatcher_co(void *data)
          */
         qatomic_mb_set(&qmp_dispatcher_co_busy, false);
 
+        /* On shutdown, don't take any more requests from the queue */
+        if (qmp_dispatcher_co_shutdown) {
+            return;
+        }
+
         while (!(req_obj = monitor_qmp_requests_pop_any_with_lock())) {
             /*
              * No more requests to process.  Wait to be reentered from
-- 
2.29.2



  parent reply	other threads:[~2021-02-12 17:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 17:20 [PATCH 0/2] monitor: Shutdown fixes Kevin Wolf
2021-02-12 17:20 ` [PATCH 1/2] monitor: Fix assertion failure on shutdown Kevin Wolf
2021-02-12 17:20 ` Kevin Wolf [this message]
2021-02-15 12:09   ` [PATCH 2/2] monitor/qmp: Stop processing requests when shutdown is requested Markus Armbruster
2021-02-15 12:28     ` Kevin Wolf
2021-02-15 12:42       ` Markus Armbruster
2021-02-15 13:58         ` Kevin Wolf
2021-02-15 14:22           ` Markus Armbruster
2021-02-15 12:16 ` [PATCH 0/2] monitor: Shutdown fixes Markus Armbruster
2021-02-15 12:44 ` Markus Armbruster
2021-06-29  9:14 ` Vladimir Sementsov-Ogievskiy
2021-07-06 15:32   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210212172028.288825-3-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.