From: Dario Binacchi <dariobin@libero.it> To: linux-kernel@vger.kernel.org Cc: Dario Binacchi <dariobin@libero.it>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Jyri Sarha <jyri.sarha@iki.fi>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>, dri-devel@lists.freedesktop.org Subject: [RESEND PATCH] drm/tilcdc: fix raster control register setting Date: Tue, 16 Feb 2021 21:22:25 +0100 [thread overview] Message-ID: <20210216202225.12861-1-dariobin@libero.it> (raw) The fdd property of the tilcdc_panel_info structure must set the reqdly bit field (bit 12 to 19) of the raster control register. The previous statement set the least significant bit instead. Signed-off-by: Dario Binacchi <dariobin@libero.it> --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 30213708fc99..238068e28729 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c @@ -393,7 +393,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc) return; } } - reg |= info->fdd < 12; + reg |= info->fdd << 12; tilcdc_write(dev, LCDC_RASTER_CTRL_REG, reg); if (info->invert_pxl_clk) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Dario Binacchi <dariobin@libero.it> To: linux-kernel@vger.kernel.org Cc: David Airlie <airlied@linux.ie>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>, dri-devel@lists.freedesktop.org, Jyri Sarha <jyri.sarha@iki.fi>, Dario Binacchi <dariobin@libero.it> Subject: [RESEND PATCH] drm/tilcdc: fix raster control register setting Date: Tue, 16 Feb 2021 21:22:25 +0100 [thread overview] Message-ID: <20210216202225.12861-1-dariobin@libero.it> (raw) The fdd property of the tilcdc_panel_info structure must set the reqdly bit field (bit 12 to 19) of the raster control register. The previous statement set the least significant bit instead. Signed-off-by: Dario Binacchi <dariobin@libero.it> --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 30213708fc99..238068e28729 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c @@ -393,7 +393,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc) return; } } - reg |= info->fdd < 12; + reg |= info->fdd << 12; tilcdc_write(dev, LCDC_RASTER_CTRL_REG, reg); if (info->invert_pxl_clk) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2021-02-16 20:24 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-16 20:22 Dario Binacchi [this message] 2021-02-16 20:22 ` [RESEND PATCH] drm/tilcdc: fix raster control register setting Dario Binacchi 2021-02-17 6:41 ` Tomi Valkeinen 2021-02-17 6:41 ` Tomi Valkeinen 2021-02-17 17:45 ` Dario Binacchi 2021-02-17 17:45 ` Dario Binacchi 2021-02-18 16:00 ` Jyri Sarha 2021-02-18 16:00 ` Jyri Sarha -- strict thread matches above, loose matches on Subject: below -- 2021-02-16 20:17 Dario Binacchi 2021-02-16 20:17 ` Dario Binacchi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210216202225.12861-1-dariobin@libero.it \ --to=dariobin@libero.it \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=jyri.sarha@iki.fi \ --cc=linux-kernel@vger.kernel.org \ --cc=tomi.valkeinen@ideasonboard.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.