All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicola Mazzucato <nicola.mazzucato@arm.com>
To: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	sudeep.holla@arm.com, rjw@rjwysocki.net, vireshk@kernel.org,
	cristian.marussi@arm.com
Cc: morten.rasmussen@arm.com, chris.redpath@arm.com,
	ionela.voinescu@arm.com, nicola.mazzucato@arm.com
Subject: [PATCH v8 1/3] scmi-cpufreq: Remove deferred probe
Date: Thu, 18 Feb 2021 22:23:24 +0000	[thread overview]
Message-ID: <20210218222326.15788-2-nicola.mazzucato@arm.com> (raw)
In-Reply-To: <20210218222326.15788-1-nicola.mazzucato@arm.com>

The current implementation of the scmi_cpufreq_init() function returns
-EPROBE_DEFER when the OPP table is not populated. In practice the
cpufreq core cannot handle this error code.
Therefore, fix the return value and clarify the error message.

Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
---
 drivers/cpufreq/scmi-cpufreq.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
index 491a0a24fb1e..c0345120a7d5 100644
--- a/drivers/cpufreq/scmi-cpufreq.c
+++ b/drivers/cpufreq/scmi-cpufreq.c
@@ -155,8 +155,10 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
 
 	nr_opp = dev_pm_opp_get_opp_count(cpu_dev);
 	if (nr_opp <= 0) {
-		dev_dbg(cpu_dev, "OPP table is not ready, deferring probe\n");
-		ret = -EPROBE_DEFER;
+		dev_err(cpu_dev, "%s: No OPPs for this device: %d\n",
+			__func__, ret);
+
+		ret = -ENODEV;
 		goto out_free_opp;
 	}
 
-- 
2.27.0


WARNING: multiple messages have this Message-ID (diff)
From: Nicola Mazzucato <nicola.mazzucato@arm.com>
To: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	sudeep.holla@arm.com, rjw@rjwysocki.net, vireshk@kernel.org,
	cristian.marussi@arm.com
Cc: chris.redpath@arm.com, ionela.voinescu@arm.com,
	morten.rasmussen@arm.com, nicola.mazzucato@arm.com
Subject: [PATCH v8 1/3] scmi-cpufreq: Remove deferred probe
Date: Thu, 18 Feb 2021 22:23:24 +0000	[thread overview]
Message-ID: <20210218222326.15788-2-nicola.mazzucato@arm.com> (raw)
In-Reply-To: <20210218222326.15788-1-nicola.mazzucato@arm.com>

The current implementation of the scmi_cpufreq_init() function returns
-EPROBE_DEFER when the OPP table is not populated. In practice the
cpufreq core cannot handle this error code.
Therefore, fix the return value and clarify the error message.

Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
---
 drivers/cpufreq/scmi-cpufreq.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
index 491a0a24fb1e..c0345120a7d5 100644
--- a/drivers/cpufreq/scmi-cpufreq.c
+++ b/drivers/cpufreq/scmi-cpufreq.c
@@ -155,8 +155,10 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
 
 	nr_opp = dev_pm_opp_get_opp_count(cpu_dev);
 	if (nr_opp <= 0) {
-		dev_dbg(cpu_dev, "OPP table is not ready, deferring probe\n");
-		ret = -EPROBE_DEFER;
+		dev_err(cpu_dev, "%s: No OPPs for this device: %d\n",
+			__func__, ret);
+
+		ret = -ENODEV;
 		goto out_free_opp;
 	}
 
-- 
2.27.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-18 22:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 22:23 [PATCH v8 0/3] CPUFreq: Add support for opp-sharing cpus Nicola Mazzucato
2021-02-18 22:23 ` Nicola Mazzucato
2021-02-18 22:23 ` Nicola Mazzucato [this message]
2021-02-18 22:23   ` [PATCH v8 1/3] scmi-cpufreq: Remove deferred probe Nicola Mazzucato
2021-02-18 22:23 ` [PATCH v8 2/3] scmi-cpufreq: Get opp_shared_cpus from opp-v2 for EM Nicola Mazzucato
2021-02-18 22:23   ` Nicola Mazzucato
2021-02-18 22:23 ` [PATCH v8 3/3] cpufreq: blacklist Arm Vexpress platforms in cpufreq-dt-platdev Nicola Mazzucato
2021-02-18 22:23   ` Nicola Mazzucato
2021-02-19  4:19 ` [PATCH v8 0/3] CPUFreq: Add support for opp-sharing cpus Viresh Kumar
2021-02-19  4:19   ` Viresh Kumar
2021-02-19 19:16   ` Sudeep Holla
2021-02-19 19:16     ` Sudeep Holla
2021-02-22  4:39     ` Viresh Kumar
2021-02-22  4:39       ` Viresh Kumar
2021-02-22 11:14       ` Sudeep Holla
2021-02-22 11:14         ` Sudeep Holla
2021-03-09 11:59 ` Sudeep Holla
2021-03-09 11:59   ` Sudeep Holla
2021-03-23  9:30 ` Sudeep Holla
2021-03-23  9:30   ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210218222326.15788-2-nicola.mazzucato@arm.com \
    --to=nicola.mazzucato@arm.com \
    --cc=chris.redpath@arm.com \
    --cc=cristian.marussi@arm.com \
    --cc=ionela.voinescu@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=morten.rasmussen@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=sudeep.holla@arm.com \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.