From: Vishal Verma <vishal.l.verma@intel.com> To: <linux-cxl@vger.kernel.org> Cc: linux-nvdimm@lists.01.org, Ben Widawsky <ben.widawsky@intel.com> Subject: [ndctl PATCH v2 13/13] test/libcxl: introduce a command size fuzzing test Date: Thu, 18 Feb 2021 19:03:31 -0700 [thread overview] Message-ID: <20210219020331.725687-14-vishal.l.verma@intel.com> (raw) In-Reply-To: <20210219020331.725687-1-vishal.l.verma@intel.com> Add a new test within test/libcxl which tries different combinations of valid and invalid payload sizes, and ensures that the kernel responds as expected by either succeeding, erroring out the ioctl, adjusting the out.size in the response etc. The fuzz set is a statically defined array which contains the different combinations to test. Adding a new combination onle needs appending to this array. Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> --- test/libcxl.c | 112 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 112 insertions(+) diff --git a/test/libcxl.c b/test/libcxl.c index 1cff32c..f7233b2 100644 --- a/test/libcxl.c +++ b/test/libcxl.c @@ -210,6 +210,117 @@ out_fail: return rc; } +struct cmd_fuzzer { + struct cxl_cmd *(*new_fn)(struct cxl_memdev *memdev); + int in; /* in size to set in cmd (INT_MAX = don't change) */ + int out; /* out size to set in cmd (INT_MAX = don't change) */ + int e_out; /* expected out size returned (INT_MAX = don't check) */ + int e_rc; /* expected ioctl return (INT_MAX = don't check) */ + int e_hwrc; /* expected 'mbox_status' (INT_MAX = don't check) */ +} fuzz_set[] = { + { cxl_cmd_new_identify, INT_MAX, INT_MAX, 67, 0, 0 }, + { cxl_cmd_new_identify, 64, INT_MAX, INT_MAX, -ENOMEM, INT_MAX }, + { cxl_cmd_new_identify, INT_MAX, 1024, 67, 0, INT_MAX }, + { cxl_cmd_new_identify, INT_MAX, 16, INT_MAX, -ENOMEM, INT_MAX }, +}; + +static int do_one_cmd_size_test(struct cxl_memdev *memdev, + struct cmd_fuzzer *test) +{ + const char *devname = cxl_memdev_get_devname(memdev); + struct cxl_cmd *cmd; + int rc; + + cmd = test->new_fn(memdev); + if (!cmd) + return -ENOMEM; + + if (test->in != INT_MAX) { + rc = cxl_cmd_set_input_payload(cmd, NULL, test->in); + if (rc) { + fprintf(stderr, + "%s: %s: failed to set in.size (%d): %s\n", + __func__, devname, test->in, strerror(-rc)); + goto out_fail; + } + } + if (test->out != INT_MAX) { + rc = cxl_cmd_set_output_payload(cmd, NULL, test->out); + if (rc) { + fprintf(stderr, + "%s: %s: failed to set out.size (%d): %s\n", + __func__, devname, test->out, strerror(-rc)); + goto out_fail; + } + } + + rc = cxl_cmd_submit(cmd); + if (test->e_rc != INT_MAX && rc != test->e_rc) { + fprintf(stderr, "%s: %s: expected cmd rc %d, got %d\n", + __func__, devname, test->e_rc, rc); + rc = -ENXIO; + goto out_fail; + } + + rc = cxl_cmd_get_out_size(cmd); + if (test->e_out != INT_MAX && rc != test->e_out) { + fprintf(stderr, "%s: %s: expected response out.size %d, got %d\n", + __func__, devname, test->e_out, rc); + rc = -ENXIO; + goto out_fail; + } + + rc = cxl_cmd_get_mbox_status(cmd); + if (test->e_hwrc != INT_MAX && rc != test->e_hwrc) { + fprintf(stderr, "%s: %s: expected firmware status %d, got %d\n", + __func__, devname, test->e_hwrc, rc); + rc = -ENXIO; + goto out_fail; + } + return 0; + +out_fail: + cxl_cmd_unref(cmd); + return rc; + +} + +static void print_fuzz_test_status(struct cmd_fuzzer *t, const char *devname, + unsigned long idx, const char *msg) +{ + fprintf(stderr, + "%s: fuzz_set[%lu]: in: %d, out %d, e_out: %d, e_rc: %d, e_hwrc: %d, result: %s\n", + devname, idx, + (t->in == INT_MAX) ? -1 : t->in, + (t->out == INT_MAX) ? -1 : t->out, + (t->e_out == INT_MAX) ? -1 : t->e_out, + (t->e_rc == INT_MAX) ? -1 : t->e_rc, + (t->e_hwrc == INT_MAX) ? -1 : t->e_hwrc, + msg); +} + +static int test_cxl_cmd_fuzz_sizes(struct cxl_ctx *ctx) +{ + struct cxl_memdev *memdev; + unsigned long i; + int rc; + + cxl_memdev_foreach(ctx, memdev) { + const char *devname = cxl_memdev_get_devname(memdev); + + for (i = 0; i < ARRAY_SIZE(fuzz_set); i++) { + rc = do_one_cmd_size_test(memdev, &fuzz_set[i]); + if (rc) { + print_fuzz_test_status(&fuzz_set[i], devname, + i, "FAIL"); + return rc; + } + print_fuzz_test_status(&fuzz_set[i], devname, i, "OK"); + } + } + return 0; +} + static int debugfs_write_raw_flag(char *str) { char *path = "/sys/kernel/debug/cxl/mbox/raw_allow_all"; @@ -350,6 +461,7 @@ static do_test_fn do_test[] = { test_cxl_emulation_env, test_cxl_cmd_identify, test_cxl_cmd_lsa, + test_cxl_cmd_fuzz_sizes, }; static int test_libcxl(int loglevel, struct test_ctx *test, struct cxl_ctx *ctx) -- 2.29.2 _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Vishal Verma <vishal.l.verma@intel.com> To: <linux-cxl@vger.kernel.org> Cc: <linux-nvdimm@lists.01.org>, Ben Widawsky <ben.widawsky@intel.com>, Dan Williams <dan.j.williams@intel.com>, Vishal Verma <vishal.l.verma@intel.com> Subject: [ndctl PATCH v2 13/13] test/libcxl: introduce a command size fuzzing test Date: Thu, 18 Feb 2021 19:03:31 -0700 [thread overview] Message-ID: <20210219020331.725687-14-vishal.l.verma@intel.com> (raw) In-Reply-To: <20210219020331.725687-1-vishal.l.verma@intel.com> Add a new test within test/libcxl which tries different combinations of valid and invalid payload sizes, and ensures that the kernel responds as expected by either succeeding, erroring out the ioctl, adjusting the out.size in the response etc. The fuzz set is a statically defined array which contains the different combinations to test. Adding a new combination onle needs appending to this array. Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> --- test/libcxl.c | 112 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 112 insertions(+) diff --git a/test/libcxl.c b/test/libcxl.c index 1cff32c..f7233b2 100644 --- a/test/libcxl.c +++ b/test/libcxl.c @@ -210,6 +210,117 @@ out_fail: return rc; } +struct cmd_fuzzer { + struct cxl_cmd *(*new_fn)(struct cxl_memdev *memdev); + int in; /* in size to set in cmd (INT_MAX = don't change) */ + int out; /* out size to set in cmd (INT_MAX = don't change) */ + int e_out; /* expected out size returned (INT_MAX = don't check) */ + int e_rc; /* expected ioctl return (INT_MAX = don't check) */ + int e_hwrc; /* expected 'mbox_status' (INT_MAX = don't check) */ +} fuzz_set[] = { + { cxl_cmd_new_identify, INT_MAX, INT_MAX, 67, 0, 0 }, + { cxl_cmd_new_identify, 64, INT_MAX, INT_MAX, -ENOMEM, INT_MAX }, + { cxl_cmd_new_identify, INT_MAX, 1024, 67, 0, INT_MAX }, + { cxl_cmd_new_identify, INT_MAX, 16, INT_MAX, -ENOMEM, INT_MAX }, +}; + +static int do_one_cmd_size_test(struct cxl_memdev *memdev, + struct cmd_fuzzer *test) +{ + const char *devname = cxl_memdev_get_devname(memdev); + struct cxl_cmd *cmd; + int rc; + + cmd = test->new_fn(memdev); + if (!cmd) + return -ENOMEM; + + if (test->in != INT_MAX) { + rc = cxl_cmd_set_input_payload(cmd, NULL, test->in); + if (rc) { + fprintf(stderr, + "%s: %s: failed to set in.size (%d): %s\n", + __func__, devname, test->in, strerror(-rc)); + goto out_fail; + } + } + if (test->out != INT_MAX) { + rc = cxl_cmd_set_output_payload(cmd, NULL, test->out); + if (rc) { + fprintf(stderr, + "%s: %s: failed to set out.size (%d): %s\n", + __func__, devname, test->out, strerror(-rc)); + goto out_fail; + } + } + + rc = cxl_cmd_submit(cmd); + if (test->e_rc != INT_MAX && rc != test->e_rc) { + fprintf(stderr, "%s: %s: expected cmd rc %d, got %d\n", + __func__, devname, test->e_rc, rc); + rc = -ENXIO; + goto out_fail; + } + + rc = cxl_cmd_get_out_size(cmd); + if (test->e_out != INT_MAX && rc != test->e_out) { + fprintf(stderr, "%s: %s: expected response out.size %d, got %d\n", + __func__, devname, test->e_out, rc); + rc = -ENXIO; + goto out_fail; + } + + rc = cxl_cmd_get_mbox_status(cmd); + if (test->e_hwrc != INT_MAX && rc != test->e_hwrc) { + fprintf(stderr, "%s: %s: expected firmware status %d, got %d\n", + __func__, devname, test->e_hwrc, rc); + rc = -ENXIO; + goto out_fail; + } + return 0; + +out_fail: + cxl_cmd_unref(cmd); + return rc; + +} + +static void print_fuzz_test_status(struct cmd_fuzzer *t, const char *devname, + unsigned long idx, const char *msg) +{ + fprintf(stderr, + "%s: fuzz_set[%lu]: in: %d, out %d, e_out: %d, e_rc: %d, e_hwrc: %d, result: %s\n", + devname, idx, + (t->in == INT_MAX) ? -1 : t->in, + (t->out == INT_MAX) ? -1 : t->out, + (t->e_out == INT_MAX) ? -1 : t->e_out, + (t->e_rc == INT_MAX) ? -1 : t->e_rc, + (t->e_hwrc == INT_MAX) ? -1 : t->e_hwrc, + msg); +} + +static int test_cxl_cmd_fuzz_sizes(struct cxl_ctx *ctx) +{ + struct cxl_memdev *memdev; + unsigned long i; + int rc; + + cxl_memdev_foreach(ctx, memdev) { + const char *devname = cxl_memdev_get_devname(memdev); + + for (i = 0; i < ARRAY_SIZE(fuzz_set); i++) { + rc = do_one_cmd_size_test(memdev, &fuzz_set[i]); + if (rc) { + print_fuzz_test_status(&fuzz_set[i], devname, + i, "FAIL"); + return rc; + } + print_fuzz_test_status(&fuzz_set[i], devname, i, "OK"); + } + } + return 0; +} + static int debugfs_write_raw_flag(char *str) { char *path = "/sys/kernel/debug/cxl/mbox/raw_allow_all"; @@ -350,6 +461,7 @@ static do_test_fn do_test[] = { test_cxl_emulation_env, test_cxl_cmd_identify, test_cxl_cmd_lsa, + test_cxl_cmd_fuzz_sizes, }; static int test_libcxl(int loglevel, struct test_ctx *test, struct cxl_ctx *ctx) -- 2.29.2
next prev parent reply other threads:[~2021-02-19 2:04 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-19 2:03 [ndctl PATCH v2 00/13] Initial CXL support Vishal Verma 2021-02-19 2:03 ` Vishal Verma 2021-02-19 2:03 ` [ndctl PATCH v2 01/13] cxl: add a cxl utility and libcxl library Vishal Verma 2021-02-19 2:03 ` Vishal Verma 2021-02-22 21:36 ` Ben Widawsky 2021-02-22 21:36 ` Ben Widawsky 2021-02-23 19:23 ` Verma, Vishal L 2021-02-23 19:23 ` Verma, Vishal L 2021-02-19 2:03 ` [ndctl PATCH v2 02/13] cxl: add a local copy of the cxl_mem UAPI header Vishal Verma 2021-02-19 2:03 ` Vishal Verma 2021-02-22 21:41 ` Ben Widawsky 2021-02-22 21:41 ` Ben Widawsky 2021-02-19 2:03 ` [ndctl PATCH v2 03/13] libcxl: add support for command query and submission Vishal Verma 2021-02-19 2:03 ` Vishal Verma 2021-02-22 21:55 ` Ben Widawsky 2021-02-22 21:55 ` Ben Widawsky 2021-02-19 2:03 ` [ndctl PATCH v2 04/13] libcxl: add support for the 'Identify Device' command Vishal Verma 2021-02-19 2:03 ` Vishal Verma 2021-02-22 22:02 ` Ben Widawsky 2021-02-22 22:02 ` Ben Widawsky 2021-02-19 2:03 ` [ndctl PATCH v2 05/13] test: rename 'ndctl_test' to 'test_ctx' Vishal Verma 2021-02-19 2:03 ` Vishal Verma 2021-02-19 2:03 ` [ndctl PATCH v2 06/13] test: rename 'ndctl_test_*' helpers to 'test_*' Vishal Verma 2021-02-19 2:03 ` Vishal Verma 2021-02-19 2:03 ` [ndctl PATCH v2 07/13] test: introduce a libcxl unit test Vishal Verma 2021-02-19 2:03 ` Vishal Verma 2021-02-22 22:15 ` Ben Widawsky 2021-02-22 22:15 ` Ben Widawsky 2021-02-19 2:03 ` [ndctl PATCH v2 08/13] libcxl: add GET_HEALTH_INFO mailbox command and accessors Vishal Verma 2021-02-19 2:03 ` Vishal Verma 2021-02-19 2:03 ` [ndctl PATCH v2 09/13] libcxl: add support for the 'GET_LSA' command Vishal Verma 2021-02-19 2:03 ` Vishal Verma 2021-02-19 2:03 ` [ndctl PATCH v2 10/13] util/hexdump: Add a util helper to print a buffer in hex Vishal Verma 2021-02-19 2:03 ` Vishal Verma 2021-02-19 2:03 ` [ndctl PATCH v2 11/13] test/libcxl: add a test for {set, get}_lsa commands Vishal Verma 2021-02-19 2:03 ` Vishal Verma 2021-02-19 2:03 ` [ndctl PATCH v2 12/13] Documentation/cxl: add library API documentation Vishal Verma 2021-02-19 2:03 ` Vishal Verma 2021-02-19 2:03 ` Vishal Verma [this message] 2021-02-19 2:03 ` [ndctl PATCH v2 13/13] test/libcxl: introduce a command size fuzzing test Vishal Verma
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210219020331.725687-14-vishal.l.verma@intel.com \ --to=vishal.l.verma@intel.com \ --cc=ben.widawsky@intel.com \ --cc=linux-cxl@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.