All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timo Rothenpieler <timo@rothenpieler.org>
To: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>,
	Olga Kornievskaia <aglo@umich.edu>,
	Timo Rothenpieler <timo@rothenpieler.org>
Subject: [PATCH] nfsd: set RPC_CLNT_CREATE_NO_IDLE_TIMEOUT on callback client
Date: Sun, 21 Feb 2021 22:13:47 +0100	[thread overview]
Message-ID: <20210221211347.3429-1-timo@rothenpieler.org> (raw)
In-Reply-To: <EF096827-F543-429E-AC9B-1E93C6A35B02@oracle.com>

This tackles an issue where the callback client times out from
inactivity, causing operations like server side copy to never return on
the client side.
I was observing that issue frequently on my RDMA connected clients, it
does not seem to manifest on tcp connected clients.

However, it does not fix the actual issue of the callback channel
not getting re-established and the client being stuck in the call
forever. It just makes it a lot less likely to occur, as long as no
other circumstances cause the callback channel to be disconnected.

Signed-off-by: Timo Rothenpieler <timo@rothenpieler.org>
---
 fs/nfsd/nfs4callback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index 052be5bf9ef5..75dacb7878b8 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -897,7 +897,7 @@ static int setup_callback_client(struct nfs4_client *clp, struct nfs4_cb_conn *c
 		.timeout	= &timeparms,
 		.program	= &cb_program,
 		.version	= 1,
-		.flags		= (RPC_CLNT_CREATE_NOPING | RPC_CLNT_CREATE_QUIET),
+		.flags		= (RPC_CLNT_CREATE_NOPING | RPC_CLNT_CREATE_QUIET | RPC_CLNT_CREATE_NO_IDLE_TIMEOUT),
 		.cred		= current_cred(),
 	};
 	struct rpc_clnt *client;
-- 
2.25.1


  reply	other threads:[~2021-02-21 21:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-21 18:27 [PATCH] nfsd: set RPC_CLNT_CREATE_NO_IDLE_TIMEOUT on callback client Timo Rothenpieler
2021-02-21 19:26 ` Chuck Lever
2021-02-21 21:13   ` Timo Rothenpieler [this message]
     [not found]   ` <3701466e-6c0a-93e1-1953-f2839b6fa37d@rothenpieler.org>
2021-02-22 21:47     ` Chuck Lever
2021-02-22 23:36       ` [PATCH] svcrdma: disable timeouts on rdma backchannel Timo Rothenpieler
2021-02-24 14:18         ` Chuck Lever
2021-02-24 20:02           ` J. Bruce Fields
2021-02-24 20:03             ` Chuck Lever
2021-02-24 20:08               ` Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210221211347.3429-1-timo@rothenpieler.org \
    --to=timo@rothenpieler.org \
    --cc=aglo@umich.edu \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.