All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akash Melachuri <amelachuri@gmail.com>
To: benjamin.tissoires@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: [PATCH] HID: ezkey: Fix trailing statements error style and blank line after declarations warning style.
Date: Sun, 21 Feb 2021 17:12:28 -0500	[thread overview]
Message-ID: <20210221221228.avvdbmcn5miebpk2@akash.localdomain> (raw)

This patch fixes the checkpatch.pl errors and warnings:
ERROR: trailing statements should be on next line
ERROR: trailing statements should be on next line
ERROR: trailing statements should be on next line
WARNING: Missing a blank line after declarations

Signed-off-by: Akash Melachuri <amelachuri@gmail.com>
---
 drivers/hid/hid-ezkey.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/hid-ezkey.c b/drivers/hid/hid-ezkey.c
index d14f91d78c96..8fa568ac79f9 100644
--- a/drivers/hid/hid-ezkey.c
+++ b/drivers/hid/hid-ezkey.c
@@ -30,14 +30,20 @@ static int ez_input_mapping(struct hid_device *hdev, struct hid_input *hi,
 		return 0;
 
 	switch (usage->hid & HID_USAGE) {
-	case 0x230: ez_map_key(BTN_MOUSE);	break;
-	case 0x231: ez_map_rel(REL_WHEEL);	break;
+	case 0x230:
+		ez_map_key(BTN_MOUSE);
+		break;
+	case 0x231:
+		ez_map_rel(REL_WHEEL);
+		break;
 	/*
 	 * this keyboard has a scrollwheel implemented in
 	 * totally broken way. We map this usage temporarily
 	 * to HWHEEL and handle it in the event quirk handler
 	 */
-	case 0x232: ez_map_rel(REL_HWHEEL);	break;
+	case 0x232:
+		ez_map_rel(REL_HWHEEL);
+		break;
 	default:
 		return 0;
 	}
@@ -54,6 +60,7 @@ static int ez_event(struct hid_device *hdev, struct hid_field *field,
 	/* handle the temporary quirky mapping to HWHEEL */
 	if (usage->type == EV_REL && usage->code == REL_HWHEEL) {
 		struct input_dev *input = field->hidinput->input;
+
 		input_event(input, usage->type, REL_WHEEL, -value);
 		return 1;
 	}
-- 
2.30.0


             reply	other threads:[~2021-02-21 22:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-21 22:12 Akash Melachuri [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-02-12  3:49 [PATCH] HID: ezkey: Fix trailing statements error style and blank line after declarations warning style Akash Melachuri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210221221228.avvdbmcn5miebpk2@akash.localdomain \
    --to=amelachuri@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.