All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timo Rothenpieler <timo@rothenpieler.org>
To: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>,
	Olga Kornievskaia <aglo@umich.edu>, Dai Ngo <dai.ngo@oracle.com>,
	Timo Rothenpieler <timo@rothenpieler.org>
Subject: [PATCH] svcrdma: disable timeouts on rdma backchannel
Date: Tue, 23 Feb 2021 00:36:19 +0100	[thread overview]
Message-ID: <20210222233619.21568-1-timo@rothenpieler.org> (raw)
In-Reply-To: <C99EA5DE-814A-418B-9685-D400F4E7B964@oracle.com>

This brings it in line with the regular tcp backchannel, which also has
all those timeouts disabled.

Prevents the backchannel from timing out, getting some async operations
like server side copying getting stuck indefinitely on the client side.

Signed-off-by: Timo Rothenpieler <timo@rothenpieler.org>
---
Did the same testing with this applied than before, and could not
observe it getting stuck, same as with the previous patch, which I
removed before testing this one.

This obviously still does not fix the issue of it being seemingly unable
to reestablish the disconnected backchannel.
An event that disconnects the backchannel but leaves the main connection
intact seems a pretty rare occurance though, outside of this issue.

 net/sunrpc/xprtrdma/svc_rdma_backchannel.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/sunrpc/xprtrdma/svc_rdma_backchannel.c b/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
index 63f8be974df2..8186ab6f99f1 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
@@ -252,9 +252,9 @@ xprt_setup_rdma_bc(struct xprt_create *args)
 	xprt->timeout = &xprt_rdma_bc_timeout;
 	xprt_set_bound(xprt);
 	xprt_set_connected(xprt);
-	xprt->bind_timeout = RPCRDMA_BIND_TO;
-	xprt->reestablish_timeout = RPCRDMA_INIT_REEST_TO;
-	xprt->idle_timeout = RPCRDMA_IDLE_DISC_TO;
+	xprt->bind_timeout = 0;
+	xprt->reestablish_timeout = 0;
+	xprt->idle_timeout = 0;
 
 	xprt->prot = XPRT_TRANSPORT_BC_RDMA;
 	xprt->ops = &xprt_rdma_bc_procs;
-- 
2.25.1


  reply	other threads:[~2021-02-22 23:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-21 18:27 [PATCH] nfsd: set RPC_CLNT_CREATE_NO_IDLE_TIMEOUT on callback client Timo Rothenpieler
2021-02-21 19:26 ` Chuck Lever
2021-02-21 21:13   ` Timo Rothenpieler
     [not found]   ` <3701466e-6c0a-93e1-1953-f2839b6fa37d@rothenpieler.org>
2021-02-22 21:47     ` Chuck Lever
2021-02-22 23:36       ` Timo Rothenpieler [this message]
2021-02-24 14:18         ` [PATCH] svcrdma: disable timeouts on rdma backchannel Chuck Lever
2021-02-24 20:02           ` J. Bruce Fields
2021-02-24 20:03             ` Chuck Lever
2021-02-24 20:08               ` Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210222233619.21568-1-timo@rothenpieler.org \
    --to=timo@rothenpieler.org \
    --cc=aglo@umich.edu \
    --cc=chuck.lever@oracle.com \
    --cc=dai.ngo@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.