From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Craig Janeczek" <jancraig@amazon.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [PATCH v4 07/12] target/mips: Use OPC_MUL instead of OPC__MXU_MUL
Date: Wed, 24 Feb 2021 19:57:01 +0100 [thread overview]
Message-ID: <20210224185706.3293058-8-f4bug@amsat.org> (raw)
In-Reply-To: <20210224185706.3293058-1-f4bug@amsat.org>
We already have a macro and definition to extract / check
the Special2 MUL opcode. Use it instead of the unnecessary
OPC__MXU_MUL macro.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/mips/translate.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index 9e875fa4a25..2d8ddbad112 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -1464,7 +1464,6 @@ enum {
*/
enum {
- OPC__MXU_MUL = 0x02,
OPC_MXU__POOL00 = 0x03,
OPC_MXU_D16MUL = 0x08,
OPC_MXU_D16MAC = 0x0A,
@@ -25784,7 +25783,7 @@ static void decode_opc_mxu(DisasContext *ctx, uint32_t insn)
{
uint32_t opcode = extract32(insn, 0, 6);
- if (opcode == OPC__MXU_MUL) {
+ if (MASK_SPECIAL2(insn) == OPC_MUL) {
uint32_t rs, rt, rd, op1;
rs = extract32(insn, 21, 5);
--
2.26.2
next prev parent reply other threads:[~2021-02-24 19:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 18:56 [PATCH v4 00/12] target/mips: Extract MXU code to new mxu_translate.c file Philippe Mathieu-Daudé
2021-02-24 18:56 ` [PATCH v4 01/12] target/mips/meson: Introduce mips_tcg source set Philippe Mathieu-Daudé
2021-02-24 19:05 ` Richard Henderson
2021-02-24 18:56 ` [PATCH v4 02/12] target/mips/meson: Restrict mips-semi.c to TCG Philippe Mathieu-Daudé
2021-02-24 19:05 ` Richard Henderson
2021-02-24 18:56 ` [PATCH v4 03/12] target/mips: Rewrite complex ifdef'ry Philippe Mathieu-Daudé
2021-02-24 18:56 ` [PATCH v4 04/12] target/mips: Remove XBurst Media eXtension Unit dead code Philippe Mathieu-Daudé
2021-02-24 18:56 ` [PATCH v4 05/12] target/mips: Remove unused CPUMIPSState* from MXU functions Philippe Mathieu-Daudé
2021-02-24 18:57 ` [PATCH v4 06/12] target/mips: Pass instruction opcode to decode_opc_mxu() Philippe Mathieu-Daudé
2021-02-24 18:57 ` Philippe Mathieu-Daudé [this message]
2021-02-24 18:57 ` [PATCH v4 08/12] target/mips: Move MUL opcode check from decode_mxu() to decode_legacy() Philippe Mathieu-Daudé
2021-02-24 19:06 ` Richard Henderson
2021-02-24 18:57 ` [PATCH v4 09/12] target/mips: Convert decode_opc_mxu() to decodetree prototype Philippe Mathieu-Daudé
2021-02-24 19:06 ` Richard Henderson
2021-02-24 18:57 ` [PATCH v4 10/12] target/mips: Simplify decode_opc_mxu() ifdef'ry Philippe Mathieu-Daudé
2021-02-24 19:07 ` Richard Henderson
2021-02-24 18:57 ` [PATCH v4 11/12] target/mips: Introduce mxu_translate_init() helper Philippe Mathieu-Daudé
2021-02-24 18:57 ` [PATCH v4 12/12] target/mips: Extract MXU code to new mxu_translate.c file Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224185706.3293058-8-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=jancraig@amazon.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.