All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [PATCH v5 07/13] target/mips: Use OPC_MUL instead of OPC__MXU_MUL
Date: Fri, 26 Feb 2021 10:31:04 +0100	[thread overview]
Message-ID: <20210226093111.3865906-8-f4bug@amsat.org> (raw)
In-Reply-To: <20210226093111.3865906-1-f4bug@amsat.org>

We already have a macro and definition to extract / check
the Special2 MUL opcode. Use it instead of the unnecessary
OPC__MXU_MUL macro.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/mips/translate.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/target/mips/translate.c b/target/mips/translate.c
index 9e875fa4a25..2d8ddbad112 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -1464,7 +1464,6 @@ enum {
  */
 
 enum {
-    OPC__MXU_MUL     = 0x02,
     OPC_MXU__POOL00  = 0x03,
     OPC_MXU_D16MUL   = 0x08,
     OPC_MXU_D16MAC   = 0x0A,
@@ -25784,7 +25783,7 @@ static void decode_opc_mxu(DisasContext *ctx, uint32_t insn)
 {
     uint32_t opcode = extract32(insn, 0, 6);
 
-    if (opcode == OPC__MXU_MUL) {
+    if (MASK_SPECIAL2(insn) == OPC_MUL) {
         uint32_t  rs, rt, rd, op1;
 
         rs = extract32(insn, 21, 5);
-- 
2.26.2



  parent reply	other threads:[~2021-02-26  9:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26  9:30 [PATCH v5 00/13] target/mips: Extract MXU code to new mxu_translate.c file Philippe Mathieu-Daudé
2021-02-26  9:30 ` [PATCH v5 01/13] target/mips/meson: Introduce mips_tcg source set Philippe Mathieu-Daudé
2021-02-26  9:30 ` [PATCH v5 02/13] target/mips/meson: Restrict mips-semi.c to TCG Philippe Mathieu-Daudé
2021-02-26  9:31 ` [PATCH v5 03/13] target/mips: Rewrite complex ifdef'ry Philippe Mathieu-Daudé
2021-02-26  9:31 ` [PATCH v5 04/13] target/mips: Remove XBurst Media eXtension Unit dead code Philippe Mathieu-Daudé
2021-02-26  9:31 ` [PATCH v5 05/13] target/mips: Remove unused CPUMIPSState* from MXU functions Philippe Mathieu-Daudé
2021-02-26  9:31 ` [PATCH v5 06/13] target/mips: Pass instruction opcode to decode_opc_mxu() Philippe Mathieu-Daudé
2021-02-26  9:31 ` Philippe Mathieu-Daudé [this message]
2021-02-26  9:31 ` [PATCH v5 08/13] target/mips: Move MUL opcode check from decode_mxu() to decode_legacy() Philippe Mathieu-Daudé
2021-02-26  9:31 ` [PATCH v5 09/13] target/mips: Rename decode_opc_mxu() as decode_ase_mxu() Philippe Mathieu-Daudé
2021-02-26  9:31 ` [PATCH v5 10/13] target/mips: Convert decode_ase_mxu() to decodetree prototype Philippe Mathieu-Daudé
2021-02-26  9:31 ` [PATCH v5 11/13] target/mips: Simplify decode_opc_mxu() ifdef'ry Philippe Mathieu-Daudé
2021-02-26  9:31 ` [PATCH v5 12/13] target/mips: Introduce mxu_translate_init() helper Philippe Mathieu-Daudé
2021-02-26  9:31 ` [PATCH v5 13/13] target/mips: Extract MXU code to new mxu_translate.c file Philippe Mathieu-Daudé
2021-03-13 23:45 ` [PATCH v5 00/13] " Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210226093111.3865906-8-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.