From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Douglas Anderson <dianders@chromium.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [PATCH v2 4/4] HID: i2c-hid: acpi: Drop redundant ACPI_PTR()
Date: Fri, 26 Feb 2021 21:32:25 +0200 [thread overview]
Message-ID: <20210226193225.47129-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20210226193225.47129-1-andriy.shevchenko@linux.intel.com>
The driver depends on ACPI, ACPI_PTR() resolution is always the same.
Otherwise a compiler may produce a warning.
That said, the rule of thumb either ugly ifdeffery with ACPI_PTR or
none should be used in a driver.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: no changes
drivers/hid/i2c-hid/i2c-hid-acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid-acpi.c b/drivers/hid/i2c-hid/i2c-hid-acpi.c
index a4810f199d59..a6f0257a26de 100644
--- a/drivers/hid/i2c-hid/i2c-hid-acpi.c
+++ b/drivers/hid/i2c-hid/i2c-hid-acpi.c
@@ -126,7 +126,7 @@ static struct i2c_driver i2c_hid_acpi_driver = {
.name = "i2c_hid_acpi",
.pm = &i2c_hid_core_pm,
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
- .acpi_match_table = ACPI_PTR(i2c_hid_acpi_match),
+ .acpi_match_table = i2c_hid_acpi_match,
},
.probe_new = i2c_hid_acpi_probe,
--
2.30.0
next prev parent reply other threads:[~2021-02-26 19:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 19:32 [PATCH v2 1/4] HID: i2c-hid: acpi: Get ACPI companion only once and reuse it Andy Shevchenko
2021-02-26 19:32 ` [PATCH v2 2/4] HID: i2c-hid: acpi: Switch to new style i2c-driver probe function Andy Shevchenko
2021-02-26 19:32 ` [PATCH v2 3/4] HID: i2c-hid: acpi: Move GUID out of function and described it Andy Shevchenko
2021-02-26 19:32 ` Andy Shevchenko [this message]
2021-03-01 14:38 ` [PATCH v2 4/4] HID: i2c-hid: acpi: Drop redundant ACPI_PTR() Benjamin Tissoires
2021-03-01 15:34 ` Jiri Kosina
2021-03-01 16:14 ` Andy Shevchenko
2021-03-08 9:45 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210226193225.47129-4-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dianders@chromium.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.