From: Nathan Chancellor <nathan@kernel.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>,
Luca Coelho <luciano.coelho@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
Jakub Kicinski <kuba@kernel.org>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Gil Adam <gil.adam@intel.com>,
Mordechay Goodstein <mordechay.goodstein@intel.com>,
Johannes Berg <johannes.berg@intel.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables
Date: Fri, 26 Feb 2021 14:06:40 -0700 [thread overview]
Message-ID: <20210226210640.GA21320@MSI.localdomain> (raw)
In-Reply-To: <20210223140039.1708534-1-weiyongjun1@huawei.com>
On Tue, Feb 23, 2021 at 02:00:39PM +0000, Wei Yongjun wrote:
> Make sure dmi_system_id tables are NULL terminated.
>
> Fixes: a2ac0f48a07c ("iwlwifi: mvm: implement approved list for the PPAG feature")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
We received a report about a crash in iwlwifi when compiled with LTO and
this fix resolves it.
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
> index 15e2773ce7e7..5ee64f7f3c85 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
> @@ -1083,6 +1083,7 @@ static const struct dmi_system_id dmi_ppag_approved_list[] = {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTek COMPUTER INC."),
> },
> },
> + {}
> };
>
> static int iwl_mvm_ppag_init(struct iwl_mvm *mvm)
>
next prev parent reply other threads:[~2021-02-26 21:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 14:00 [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables Wei Yongjun
2021-02-26 21:06 ` Nathan Chancellor [this message]
2021-02-27 6:39 ` Kalle Valo
2021-03-02 18:31 ` Coelho, Luciano
2021-03-02 19:05 ` Jakub Kicinski
2021-03-02 19:50 ` Kalle Valo
2021-03-02 21:42 ` Jakub Kicinski
2021-03-03 6:45 ` Coelho, Luciano
2021-02-26 21:37 ` vic.michel.web
2021-03-03 15:57 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210226210640.GA21320@MSI.localdomain \
--to=nathan@kernel.org \
--cc=emmanuel.grumbach@intel.com \
--cc=gil.adam@intel.com \
--cc=hulkci@huawei.com \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=mordechay.goodstein@intel.com \
--cc=netdev@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.