All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: Oder Chiou <oder_chiou@realtek.com>,
	Jack Yu <jack.yu@realtek.com>,
	tiwai@suse.de,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	broonie@kernel.org, Shuming Fan <shumingf@realtek.com>,
	Bard liao <yung-chuan.liao@linux.intel.com>
Subject: [PATCH 09/24] ASoC: rt5645: use logical OR
Date: Tue,  2 Mar 2021 15:25:12 -0600	[thread overview]
Message-ID: <20210302212527.55158-10-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210302212527.55158-1-pierre-louis.bossart@linux.intel.com>

cppcheck warning:

sound/soc/codecs/rt5645.c:693:37: style:inconclusive: Boolean
expression 'reg>=420&&reg<=461' is used in bitwise operation. Did you
mean '||'? [bitwiseOnBoolean]
 if ((reg >= 0x1a4 && reg <= 0x1cd) | (reg >= 0x1e5 && reg <= 0x1f8) |
                                    ^
sound/soc/codecs/rt5645.c:693:70: style:inconclusive: Boolean
expression 'reg==177' is used in bitwise operation. Did you mean '||'?
[bitwiseOnBoolean]
 if ((reg >= 0x1a4 && reg <= 0x1cd) | (reg >= 0x1e5 && reg <= 0x1f8) |
                                                                     ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/codecs/rt5645.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
index 63a7e052eaa0..4db6cd70e32b 100644
--- a/sound/soc/codecs/rt5645.c
+++ b/sound/soc/codecs/rt5645.c
@@ -690,7 +690,7 @@ static int rt5645_hweq_get(struct snd_kcontrol *kcontrol,
 
 static bool rt5645_validate_hweq(unsigned short reg)
 {
-	if ((reg >= 0x1a4 && reg <= 0x1cd) | (reg >= 0x1e5 && reg <= 0x1f8) |
+	if ((reg >= 0x1a4 && reg <= 0x1cd) || (reg >= 0x1e5 && reg <= 0x1f8) ||
 		(reg == RT5645_EQ_CTRL2))
 		return true;
 
-- 
2.25.1


  parent reply	other threads:[~2021-03-02 21:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02 21:25 [PATCH 00/24] ASoC: realtek: fix cppcheck warnings Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 01/24] ASoC: rt1011: use logical OR Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 02/24] ASoC: rt1011: remove redundant test Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 03/24] ASoC: rt1011: clarify expression Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 04/24] ASoC: rt1015: " Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 05/24] ASoC: rt1016: " Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 06/24] ASoC: rt1305: " Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 07/24] ASoC: rt1308: " Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 08/24] ASoC: rt5640: " Pierre-Louis Bossart
2021-03-02 21:25 ` Pierre-Louis Bossart [this message]
2021-03-02 21:25 ` [PATCH 10/24] ASoC: rt5645: " Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 11/24] ASoC: rt5651: " Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 12/24] ASoC: rt5651: remove useless assignment Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 13/24] ASoC: rt5659: clarify expression Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 14/24] ASoC: rt5660: " Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 15/24] ASoC: rt5663: " Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 16/24] ASoC: rt5665: " Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 17/24] ASoC: rt5668: " Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 18/24] ASoC: rt5668: remove useless assignments Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 19/24] ASoC: rt5670: clarify expression Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 20/24] ASoC: rt5677: " Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 21/24] ASoC: rt5677: remove useless assignment Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 22/24] ASoC: rt5682: clarify expression Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 23/24] ASoC: rt5682: remove useless assignments Pierre-Louis Bossart
2021-03-02 21:25 ` [PATCH 24/24] ASoC: rt5682: remove useless initialization Pierre-Louis Bossart
2021-03-04  0:54 ` [PATCH 00/24] ASoC: realtek: fix cppcheck warnings Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210302212527.55158-10-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jack.yu@realtek.com \
    --cc=oder_chiou@realtek.com \
    --cc=shumingf@realtek.com \
    --cc=tiwai@suse.de \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.