From: Jeffle Xu <jefflexu@linux.alibaba.com> To: msnitzer@redhat.com, axboe@kernel.dk Cc: io-uring@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, mpatocka@redhat.com, caspar@linux.alibaba.com, joseph.qi@linux.alibaba.com Subject: [PATCH v5 01/12] block: move definition of blk_qc_t to types.h Date: Wed, 3 Mar 2021 19:57:29 +0800 [thread overview] Message-ID: <20210303115740.127001-2-jefflexu@linux.alibaba.com> (raw) In-Reply-To: <20210303115740.127001-1-jefflexu@linux.alibaba.com> So that kiocb.ki_cookie can be defined as blk_qc_t, which will enforce the encapsulation. Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Mike Snitzer <snitzer@redhat.com> --- include/linux/blk_types.h | 2 +- include/linux/fs.h | 2 +- include/linux/types.h | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index db026b6ec15a..fb429daaa909 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -505,7 +505,7 @@ static inline int op_stat_group(unsigned int op) return op_is_write(op); } -typedef unsigned int blk_qc_t; +/* Macros for blk_qc_t */ #define BLK_QC_T_NONE -1U #define BLK_QC_T_SHIFT 16 #define BLK_QC_T_INTERNAL (1U << 31) diff --git a/include/linux/fs.h b/include/linux/fs.h index ec8f3ddf4a6a..8b14dacf618d 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -332,7 +332,7 @@ struct kiocb { u16 ki_hint; u16 ki_ioprio; /* See linux/ioprio.h */ union { - unsigned int ki_cookie; /* for ->iopoll */ + blk_qc_t ki_cookie; /* for ->iopoll */ struct wait_page_queue *ki_waitq; /* for async buffered IO */ }; diff --git a/include/linux/types.h b/include/linux/types.h index ac825ad90e44..52a54ed6ffac 100644 --- a/include/linux/types.h +++ b/include/linux/types.h @@ -125,6 +125,9 @@ typedef s64 int64_t; typedef u64 sector_t; typedef u64 blkcnt_t; +/* cookie used for IO polling */ +typedef unsigned int blk_qc_t; + /* * The type of an index into the pagecache. */ -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Jeffle Xu <jefflexu@linux.alibaba.com> To: msnitzer@redhat.com, axboe@kernel.dk Cc: caspar@linux.alibaba.com, linux-block@vger.kernel.org, joseph.qi@linux.alibaba.com, dm-devel@redhat.com, mpatocka@redhat.com, io-uring@vger.kernel.org Subject: [dm-devel] [PATCH v5 01/12] block: move definition of blk_qc_t to types.h Date: Wed, 3 Mar 2021 19:57:29 +0800 [thread overview] Message-ID: <20210303115740.127001-2-jefflexu@linux.alibaba.com> (raw) In-Reply-To: <20210303115740.127001-1-jefflexu@linux.alibaba.com> So that kiocb.ki_cookie can be defined as blk_qc_t, which will enforce the encapsulation. Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Mike Snitzer <snitzer@redhat.com> --- include/linux/blk_types.h | 2 +- include/linux/fs.h | 2 +- include/linux/types.h | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index db026b6ec15a..fb429daaa909 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -505,7 +505,7 @@ static inline int op_stat_group(unsigned int op) return op_is_write(op); } -typedef unsigned int blk_qc_t; +/* Macros for blk_qc_t */ #define BLK_QC_T_NONE -1U #define BLK_QC_T_SHIFT 16 #define BLK_QC_T_INTERNAL (1U << 31) diff --git a/include/linux/fs.h b/include/linux/fs.h index ec8f3ddf4a6a..8b14dacf618d 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -332,7 +332,7 @@ struct kiocb { u16 ki_hint; u16 ki_ioprio; /* See linux/ioprio.h */ union { - unsigned int ki_cookie; /* for ->iopoll */ + blk_qc_t ki_cookie; /* for ->iopoll */ struct wait_page_queue *ki_waitq; /* for async buffered IO */ }; diff --git a/include/linux/types.h b/include/linux/types.h index ac825ad90e44..52a54ed6ffac 100644 --- a/include/linux/types.h +++ b/include/linux/types.h @@ -125,6 +125,9 @@ typedef s64 int64_t; typedef u64 sector_t; typedef u64 blkcnt_t; +/* cookie used for IO polling */ +typedef unsigned int blk_qc_t; + /* * The type of an index into the pagecache. */ -- 2.27.0 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-03-03 16:42 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-03 11:57 [PATCH v5 00/12] dm: support polling Jeffle Xu 2021-03-03 11:57 ` [dm-devel] " Jeffle Xu 2021-03-03 11:57 ` Jeffle Xu [this message] 2021-03-03 11:57 ` [dm-devel] [PATCH v5 01/12] block: move definition of blk_qc_t to types.h Jeffle Xu 2021-03-03 11:57 ` [PATCH v5 02/12] block: add queue_to_disk() to get gendisk from request_queue Jeffle Xu 2021-03-03 11:57 ` [dm-devel] " Jeffle Xu 2021-03-03 11:57 ` [PATCH v5 03/12] block: add poll method to support bio-based IO polling Jeffle Xu 2021-03-03 11:57 ` [dm-devel] " Jeffle Xu 2021-03-10 22:01 ` Mike Snitzer 2021-03-10 22:01 ` [dm-devel] " Mike Snitzer 2021-03-11 5:31 ` JeffleXu 2021-03-11 5:31 ` JeffleXu 2021-03-03 11:57 ` [PATCH v5 04/12] block: add poll_capable " Jeffle Xu 2021-03-03 11:57 ` [dm-devel] " Jeffle Xu 2021-03-10 22:21 ` Mike Snitzer 2021-03-10 22:21 ` [dm-devel] " Mike Snitzer 2021-03-11 5:43 ` JeffleXu 2021-03-11 5:43 ` JeffleXu 2021-03-03 11:57 ` [PATCH v5 05/12] blk-mq: extract one helper function polling hw queue Jeffle Xu 2021-03-03 11:57 ` [dm-devel] " Jeffle Xu 2021-03-03 11:57 ` [PATCH v5 06/12] blk-mq: add iterator for polling hw queues Jeffle Xu 2021-03-03 11:57 ` [dm-devel] " Jeffle Xu 2021-03-03 11:57 ` [PATCH v5 07/12] blk-mq: add one helper function getting hw queue Jeffle Xu 2021-03-03 11:57 ` [dm-devel] " Jeffle Xu 2021-03-03 11:57 ` [PATCH v5 08/12] dm: always return BLK_QC_T_NONE for bio-based device Jeffle Xu 2021-03-03 11:57 ` [dm-devel] " Jeffle Xu 2021-03-03 11:57 ` [PATCH v5 09/12] nvme/pci: don't wait for locked polling queue Jeffle Xu 2021-03-03 11:57 ` [dm-devel] " Jeffle Xu 2021-03-10 21:57 ` Mike Snitzer 2021-03-10 21:57 ` [dm-devel] " Mike Snitzer 2021-03-03 11:57 ` [PATCH v5 10/12] block: fastpath for bio-based polling Jeffle Xu 2021-03-03 11:57 ` [dm-devel] " Jeffle Xu 2021-03-10 23:18 ` Mike Snitzer 2021-03-10 23:18 ` [dm-devel] " Mike Snitzer 2021-03-11 6:36 ` JeffleXu 2021-03-11 6:36 ` JeffleXu 2021-03-12 2:26 ` JeffleXu 2021-03-12 2:26 ` JeffleXu 2021-03-11 13:56 ` Ming Lei 2021-03-11 13:56 ` [dm-devel] " Ming Lei 2021-03-12 1:56 ` JeffleXu 2021-03-12 1:56 ` JeffleXu 2021-03-03 11:57 ` [PATCH v5 11/12] block: sub-fastpath " Jeffle Xu 2021-03-03 11:57 ` [dm-devel] " Jeffle Xu 2021-03-03 11:57 ` [PATCH v5 12/12] dm: support IO polling for bio-based dm device Jeffle Xu 2021-03-03 11:57 ` [dm-devel] " Jeffle Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210303115740.127001-2-jefflexu@linux.alibaba.com \ --to=jefflexu@linux.alibaba.com \ --cc=axboe@kernel.dk \ --cc=caspar@linux.alibaba.com \ --cc=dm-devel@redhat.com \ --cc=io-uring@vger.kernel.org \ --cc=joseph.qi@linux.alibaba.com \ --cc=linux-block@vger.kernel.org \ --cc=mpatocka@redhat.com \ --cc=msnitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.