All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org,
	VMware Graphics <linux-graphics-maintainer@vmware.com>,
	Roland Scheidegger <sroland@vmware.com>,
	Zack Rusin <zackr@vmware.com>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH 45/53] drm/vmwgfx/vmwgfx_cotable: Fix a couple of simple documentation problems
Date: Wed,  3 Mar 2021 13:43:11 +0000	[thread overview]
Message-ID: <20210303134319.3160762-46-lee.jones@linaro.org> (raw)
In-Reply-To: <20210303134319.3160762-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c:72: warning: Function parameter or member 'unbind_func' not described in 'vmw_cotable_info'
 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c:308: warning: Function parameter or member 'val_buf' not described in 'vmw_cotable_unbind'

Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Roland Scheidegger <sroland@vmware.com>
Cc: Zack Rusin <zackr@vmware.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Zack Rusin <zackr@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210115181601.3432599-3-lee.jones@linaro.org
---
 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c
index ba658fa9cf6c6..42321b9c8129f 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c
@@ -63,6 +63,7 @@ struct vmw_cotable {
  * @min_initial_entries: Min number of initial intries at cotable allocation
  * for this cotable type.
  * @size: Size of each entry.
+ * @unbind_func: Unbind call-back function.
  */
 struct vmw_cotable_info {
 	u32 min_initial_entries;
@@ -297,7 +298,7 @@ int vmw_cotable_scrub(struct vmw_resource *res, bool readback)
  *
  * @res: Pointer to the cotable resource.
  * @readback: Whether to read back cotable data to the backup buffer.
- * val_buf: Pointer to a struct ttm_validate_buffer prepared by the caller
+ * @val_buf: Pointer to a struct ttm_validate_buffer prepared by the caller
  * for convenience / fencing.
  *
  * Unbinds the cotable from the device and fences the backup buffer.
-- 
2.27.0


WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: David Airlie <airlied@linux.ie>,
	Roland Scheidegger <sroland@vmware.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	VMware Graphics <linux-graphics-maintainer@vmware.com>
Subject: [PATCH 45/53] drm/vmwgfx/vmwgfx_cotable: Fix a couple of simple documentation problems
Date: Wed,  3 Mar 2021 13:43:11 +0000	[thread overview]
Message-ID: <20210303134319.3160762-46-lee.jones@linaro.org> (raw)
In-Reply-To: <20210303134319.3160762-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c:72: warning: Function parameter or member 'unbind_func' not described in 'vmw_cotable_info'
 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c:308: warning: Function parameter or member 'val_buf' not described in 'vmw_cotable_unbind'

Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Roland Scheidegger <sroland@vmware.com>
Cc: Zack Rusin <zackr@vmware.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Zack Rusin <zackr@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210115181601.3432599-3-lee.jones@linaro.org
---
 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c
index ba658fa9cf6c6..42321b9c8129f 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c
@@ -63,6 +63,7 @@ struct vmw_cotable {
  * @min_initial_entries: Min number of initial intries at cotable allocation
  * for this cotable type.
  * @size: Size of each entry.
+ * @unbind_func: Unbind call-back function.
  */
 struct vmw_cotable_info {
 	u32 min_initial_entries;
@@ -297,7 +298,7 @@ int vmw_cotable_scrub(struct vmw_resource *res, bool readback)
  *
  * @res: Pointer to the cotable resource.
  * @readback: Whether to read back cotable data to the backup buffer.
- * val_buf: Pointer to a struct ttm_validate_buffer prepared by the caller
+ * @val_buf: Pointer to a struct ttm_validate_buffer prepared by the caller
  * for convenience / fencing.
  *
  * Unbinds the cotable from the device and fences the backup buffer.
-- 
2.27.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2021-03-03 18:11 UTC|newest]

Thread overview: 185+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 13:42 [RESEND 00/53] Rid GPU from W=1 warnings Lee Jones
2021-03-03 13:42 ` Lee Jones
2021-03-03 13:42 ` Lee Jones
2021-03-03 13:42 ` [Nouveau] " Lee Jones
2021-03-03 13:42 ` [PATCH 01/53] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` [Nouveau] " Lee Jones
2021-03-03 13:42 ` [PATCH 02/53] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` [Nouveau] " Lee Jones
2021-03-03 13:42 ` [PATCH 03/53] drm/msm/dp/dp_display: Remove unused variable 'hpd' Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42 ` [PATCH 04/53] drm/amd/display/dc/bios/command_table: Remove unused variable Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 15:22   ` Alex Deucher
2021-03-03 15:22     ` Alex Deucher
2021-03-03 15:22     ` Alex Deucher
2021-03-03 13:42 ` [PATCH 05/53] include: drm: drm_atomic: Make use of 'new_plane_state' Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42 ` [PATCH 06/53] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` [Nouveau] " Lee Jones
2021-03-03 13:42 ` [PATCH 07/53] drm/amd/display/dc/bios/command_table: Remove unused variable and associated comment Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 15:22   ` Alex Deucher
2021-03-03 15:22     ` Alex Deucher
2021-03-03 15:22     ` Alex Deucher
2021-03-03 13:42 ` [PATCH 08/53] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:46   ` Christian König
2021-03-03 13:46     ` Christian König
2021-03-03 13:46     ` Christian König
2021-03-03 13:42 ` [PATCH 09/53] drm/amd/display/dc/calcs/dce_calcs: Remove some large variables from the stack Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42 ` [PATCH 10/53] drm/amd/display/dc/dce/dce_aux: Remove duplicate line causing 'field overwritten' issue Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 15:24   ` Alex Deucher
2021-03-03 15:24     ` Alex Deucher
2021-03-03 15:24     ` Alex Deucher
2021-03-03 13:42 ` [PATCH 11/53] drm/amd/display/dc/dce80/dce80_resource: Make local functions static Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42 ` [PATCH 12/53] drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc header Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` [Nouveau] " Lee Jones
2021-03-03 13:42 ` [PATCH 13/53] drm/nouveau/nouveau_bo: Remove unused variables 'dev' Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` [Nouveau] " Lee Jones
2021-03-03 13:42 ` [PATCH 14/53] drm/nouveau/nouveau_display: Remove set but unused variable 'width' Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` [Nouveau] " Lee Jones
2021-03-03 13:42 ` [PATCH 15/53] drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` [Nouveau] " Lee Jones
2021-03-03 13:42 ` [PATCH 16/53] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function returning void Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` [Nouveau] " Lee Jones
2021-03-03 13:42 ` [PATCH 17/53] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` [Nouveau] " Lee Jones
2021-03-03 16:52   ` Lyude Paul
2021-03-03 16:52     ` Lyude Paul
2021-03-03 16:52     ` [Nouveau] " Lyude Paul
2021-03-03 13:42 ` [PATCH 18/53] drm/nouveau/nv50_display: Remove superfluous prototype for local static functions Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` [Nouveau] " Lee Jones
2021-03-03 13:42 ` [PATCH 19/53] drm/nouveau/dispnv50/disp: Include header containing our prototypes Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` [Nouveau] " Lee Jones
2021-03-03 13:42 ` [PATCH 20/53] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` [Nouveau] " Lee Jones
2021-03-03 13:42 ` [PATCH 21/53] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` [Nouveau] " Lee Jones
2021-03-03 13:42 ` [PATCH 22/53] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42   ` [Nouveau] " Lee Jones
2021-03-03 13:42 ` [PATCH 23/53] drm/vmwgfx/vmwgfx_execbuf: Fix some kernel-doc related issues Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42 ` [PATCH 24/53] drm/vmwgfx/vmwgfx_kms: Remove unused variable 'ret' from 'vmw_du_primary_plane_atomic_check()' Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42 ` [PATCH 25/53] drm/vmwgfx/vmwgfx_kms: Mark vmw_{cursor,primary}_plane_formats as __maybe_unused Lee Jones
2021-03-03 13:42   ` [PATCH 25/53] drm/vmwgfx/vmwgfx_kms: Mark vmw_{cursor, primary}_plane_formats " Lee Jones
2021-03-03 13:42 ` [PATCH 26/53] drm/vmwgfx/vmwgfx_drv: Fix some kernel-doc misdemeanours Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42 ` [PATCH 27/53] drm/vmwgfx/vmwgfx_ioctl: Provide missing '@' sign required by kernel-doc Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42 ` [PATCH 28/53] drm/vmwgfx/vmwgfx_resource: Fix worthy function headers demote some others Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42 ` [PATCH 29/53] drm/vmwgfx/vmwgfx_ttm_buffer: Supply some missing parameter descriptions Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42 ` [PATCH 30/53] drm/vmwgfx/vmwgfx_fifo: Demote non-conformant kernel-doc header Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42 ` [PATCH 31/53] drm/vmwgfx/vmwgfx_ldu: Supply descriptions for 'state' function parameter Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42 ` [PATCH 32/53] drm/vmwgfx/vmwgfx_kms: Update worthy function headers and demote others Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:42 ` [PATCH 33/53] drm/vmwgfx/vmwgfx_overlay: Demote kernel-doc abuses to standard comment blocks Lee Jones
2021-03-03 13:42   ` Lee Jones
2021-03-03 13:43 ` [PATCH 34/53] drm/vmwgfx/vmwgfx_fence: Add, remove and demote various documentation params/headers Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 35/53] drm/vmwgfx/vmwgfx_bo: Remove superfluous param description and supply another Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 36/53] drm/vmwgfx/vmwgfx_context: Demote kernel-doc abuses Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 37/53] drm/vmwgfx/vmwgfx_scrn: Demote unworthy kernel-doc headers and update others Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 38/53] drm/vmwgfx/vmwgfx_surface: Fix some kernel-doc related issues Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 39/53] drm/vmwgfx/vmwgfx_cmdbuf_res: Rename param description and remove another Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 40/53] drm/vmwgfx/vmwgfx_shader: Demote kernel-doc abuses and fix-up worthy headers Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 41/53] drm/vmwgfx/vmwgfx_cmdbuf: Fix a bunch of missing or incorrectly formatted/named params Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 42/53] drm/vmwgfx/vmwgfx_cmdbuf_res: Remove unused variable 'ret' Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 43/53] drm/vmwgfx/vmwgfx_stdu: Add some missing param/member descriptions Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 44/53] drm/vmwgfx/vmwgfx_cmdbuf: Fix misnaming of 'headers' should be plural Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` Lee Jones [this message]
2021-03-03 13:43   ` [PATCH 45/53] drm/vmwgfx/vmwgfx_cotable: Fix a couple of simple documentation problems Lee Jones
2021-03-03 13:43 ` [PATCH 46/53] drm/vmwgfx/vmwgfx_so: Add description for 'vmw_view's 'rcu' member Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 47/53] drm/vmwgfx/vmwgfx_binding: Provide some missing param descriptions and remove others Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 48/53] drm/vmwgfx/vmwgfx_msg: Fix misspelling of 'msg' Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 49/53] drm/vmwgfx/vmwgfx_blit: Add description for 'vmw_bo_cpu_blit's 'diff' param Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 50/53] drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function param descriptions Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 51/53] drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 52/53] drm/vmwgfx/vmwgfx_thp: Add description for 'vmw_thp_manager's member 'manager' Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-03 13:43 ` [PATCH 53/53] drm/vmwgfx/ttm_object: Reorder header to immediately precede its struct Lee Jones
2021-03-03 13:43   ` Lee Jones
2021-03-05 15:33 ` [RESEND 00/53] Rid GPU from W=1 warnings Roland Scheidegger
2021-03-05 15:33   ` Roland Scheidegger
2021-03-05 15:33   ` Roland Scheidegger
2021-03-05 15:33   ` [Nouveau] " Roland Scheidegger
2021-03-08  9:19   ` Lee Jones
2021-03-08  9:19     ` Lee Jones
2021-03-08  9:19     ` Lee Jones
2021-03-08  9:19     ` [Nouveau] " Lee Jones
2021-03-11 13:31     ` Daniel Vetter
2021-03-11 13:31       ` Daniel Vetter
2021-03-11 13:31       ` Daniel Vetter
2021-03-11 13:31       ` [Nouveau] " Daniel Vetter
2021-03-11 13:51       ` Lee Jones
2021-03-11 13:51         ` Lee Jones
2021-03-11 13:51         ` Lee Jones
2021-03-11 13:51         ` [Nouveau] " Lee Jones
2021-03-17  8:17         ` Lee Jones
2021-03-17  8:17           ` Lee Jones
2021-03-17  8:17           ` Lee Jones
2021-03-17  8:17           ` [Nouveau] " Lee Jones
2021-03-17 20:32           ` Daniel Vetter
2021-03-17 20:32             ` Daniel Vetter
2021-03-17 20:32             ` Daniel Vetter
2021-03-17 20:32             ` [Nouveau] " Daniel Vetter
2021-03-18 13:18             ` Daniel Vetter
2021-03-18 13:18               ` Daniel Vetter
2021-03-18 13:18               ` Daniel Vetter
2021-03-18 13:18               ` [Nouveau] " Daniel Vetter
2021-03-19  8:24               ` Lee Jones
2021-03-19  8:24                 ` Lee Jones
2021-03-19  8:24                 ` Lee Jones
2021-03-19  8:24                 ` [Nouveau] " Lee Jones
2021-03-19 17:55                 ` Daniel Vetter
2021-03-19 17:55                   ` Daniel Vetter
2021-03-19 17:55                   ` Daniel Vetter
2021-03-19 17:55                   ` [Nouveau] " Daniel Vetter
2021-03-22  8:39                   ` Lee Jones
2021-03-22  8:39                     ` Lee Jones
2021-03-22  8:39                     ` Lee Jones
2021-03-22  8:39                     ` [Nouveau] " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210303134319.3160762-46-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-graphics-maintainer@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sroland@vmware.com \
    --cc=zackr@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.