From: Paul Cercueil <paul@crapouillou.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: od@zcrc.me, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org,
Paul Cercueil <paul@crapouillou.net>
Subject: [PATCH v3 1/3] input: gpio-keys: Remove extra call to input_sync
Date: Sun, 7 Mar 2021 22:22:38 +0000 [thread overview]
Message-ID: <20210307222240.380583-1-paul@crapouillou.net> (raw)
The input_sync() function is already called after the loop in
gpio_keys_report_state(), so it does not need to be called after each
iteration within gpio_keys_gpio_report_event().
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
Notes:
v2: Keep the input_sync() within gpio_keys_report_state() so that it's
not called at every iteration of the loop.
v3: No change
drivers/input/keyboard/gpio_keys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index 77bac4ddf324..7fcb2c35c5cc 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -373,7 +373,6 @@ static void gpio_keys_gpio_report_event(struct gpio_button_data *bdata)
} else {
input_event(input, type, *bdata->code, state);
}
- input_sync(input);
}
static void gpio_keys_gpio_work_func(struct work_struct *work)
@@ -382,6 +381,7 @@ static void gpio_keys_gpio_work_func(struct work_struct *work)
container_of(work, struct gpio_button_data, work.work);
gpio_keys_gpio_report_event(bdata);
+ input_sync(bdata->input);
if (bdata->button->wakeup)
pm_relax(bdata->input->dev.parent);
--
2.30.1
next reply other threads:[~2021-03-07 22:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 22:22 Paul Cercueil [this message]
2021-03-07 22:22 ` [PATCH v3 2/3] input: gpio-keys: Use hrtimer for release timer Paul Cercueil
2021-03-23 21:33 ` Dmitry Torokhov
2021-03-07 22:22 ` [PATCH v3 3/3] input: gpio-keys: Use hrtimer for software debounce, if possible Paul Cercueil
2021-03-23 21:34 ` Dmitry Torokhov
2021-04-06 8:37 ` Tony Lindgren
2021-04-07 4:34 ` Dmitry Torokhov
2021-03-23 21:33 ` [PATCH v3 1/3] input: gpio-keys: Remove extra call to input_sync Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210307222240.380583-1-paul@crapouillou.net \
--to=paul@crapouillou.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.