All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	andrew@lunn.ch, hkallweit1@gmail.com, kuba@kernel.org,
	davem@davemloft.net
Subject: [PATCH net 1/3] net: phy: broadcom: Add power down exit reset state delay
Date: Wed, 10 Mar 2021 12:41:04 -0800	[thread overview]
Message-ID: <20210310204106.2767772-2-f.fainelli@gmail.com> (raw)
In-Reply-To: <20210310204106.2767772-1-f.fainelli@gmail.com>

Per the datasheet, when we clear the power down bit, the PHY remains in
an internal reset state for 40us and then resume normal operation.
Account for that delay to avoid any issues in the future if
genphy_resume() changes.

Fixes: fe26821fa614 ("net: phy: broadcom: Wire suspend/resume for BCM54810")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/net/phy/broadcom.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
index fa0be591ae79..b8eb736fb456 100644
--- a/drivers/net/phy/broadcom.c
+++ b/drivers/net/phy/broadcom.c
@@ -399,6 +399,11 @@ static int bcm54xx_resume(struct phy_device *phydev)
 	if (ret < 0)
 		return ret;
 
+	/* Upon exiting power down, the PHY remains in an internal reset state
+	 * for 40us
+	 */
+	usleep(40);
+
 	return bcm54xx_config_init(phydev);
 }
 
-- 
2.25.1


  reply	other threads:[~2021-03-10 20:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 20:41 [PATCH net 0/3] net: phy: broadcom: Suspend fixes Florian Fainelli
2021-03-10 20:41 ` Florian Fainelli [this message]
2021-03-10 22:36   ` [PATCH net 1/3] net: phy: broadcom: Add power down exit reset state delay kernel test robot
2021-03-10 22:36     ` kernel test robot
2021-03-10 23:20   ` kernel test robot
2021-03-10 23:20     ` kernel test robot
2021-03-10 20:41 ` [PATCH net 2/3] net: phy: broadcom: Only set BMCR.PDOWN to suspend Florian Fainelli
2021-03-10 21:07   ` Heiner Kallweit
2021-03-10 21:15     ` Florian Fainelli
2021-03-10 21:43       ` Heiner Kallweit
2021-03-10 22:56         ` Florian Fainelli
2021-03-11  3:31           ` Florian Fainelli
2021-03-10 20:41 ` [PATCH net 3/3] net: phy: broadcom: Use corrected suspend for BCM54811 Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210310204106.2767772-2-f.fainelli@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.