From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <ziy@nvidia.com>, <willy@infradead.org>,
<william.kucharski@oracle.com>, <vbabka@suse.cz>,
<peterx@redhat.com>, <yulei.kernel@gmail.com>,
<walken@google.com>, <aneesh.kumar@linux.ibm.com>,
<rcampbell@nvidia.com>, <thomas_os@shipmail.org>,
<yang.shi@linux.alibaba.com>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, <linmiaohe@huawei.com>
Subject: [PATCH v2 4/6] mm/huge_memory.c: remove redundant PageCompound() check
Date: Tue, 16 Mar 2021 08:40:05 -0400 [thread overview]
Message-ID: <20210316124007.20474-5-linmiaohe@huawei.com> (raw)
In-Reply-To: <20210316124007.20474-1-linmiaohe@huawei.com>
The !PageCompound() check limits the page must be head or tail while
!PageHead() further limits it to page head only. So !PageHead() check
is equivalent here.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/huge_memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 57a1b72e03c8..ebfb0bf2e3fd 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -1291,7 +1291,7 @@ vm_fault_t do_huge_pmd_wp_page(struct vm_fault *vmf, pmd_t orig_pmd)
}
page = pmd_page(orig_pmd);
- VM_BUG_ON_PAGE(!PageCompound(page) || !PageHead(page), page);
+ VM_BUG_ON_PAGE(!PageHead(page), page);
/* Lock page for reuse_swap_page() */
if (!trylock_page(page)) {
--
2.19.1
next prev parent reply other threads:[~2021-03-16 12:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 12:40 [PATCH v2 0/6] Some cleanups for huge_memory Miaohe Lin
2021-03-16 12:40 ` [PATCH v2 1/6] mm/huge_memory.c: rework the function vma_adjust_trans_huge() Miaohe Lin
2021-03-16 20:40 ` Peter Xu
2021-03-17 2:18 ` Miaohe Lin
2021-03-17 13:07 ` Peter Xu
2021-03-16 12:40 ` [PATCH v2 2/6] mm/huge_memory.c: make get_huge_zero_page() return bool Miaohe Lin
2021-03-16 12:40 ` [PATCH v2 3/6] mm/huge_memory.c: rework the function do_huge_pmd_numa_page() slightly Miaohe Lin
2021-03-16 12:40 ` Miaohe Lin [this message]
2021-03-16 12:40 ` [PATCH v2 5/6] mm/huge_memory.c: remove unused macro TRANSPARENT_HUGEPAGE_DEBUG_COW_FLAG Miaohe Lin
2021-03-16 12:40 ` [PATCH v2 6/6] mm/huge_memory.c: use helper function migration_entry_to_page() Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316124007.20474-5-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=rcampbell@nvidia.com \
--cc=thomas_os@shipmail.org \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
--cc=yulei.kernel@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.