From: Andre Przywara <andre.przywara@arm.com> To: Will Deacon <will@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Shuah Khan <shuah@kernel.org> Cc: Amit Daniel Kachhap <amit.kachhap@arm.com>, Mark Brown <broonie@kernel.org>, Vincenzo Frascino <vincenzo.frascino@arm.com>, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: [PATCH 02/11] kselftest/arm64: mte: Fix pthread linking Date: Fri, 19 Mar 2021 16:53:25 +0000 [thread overview] Message-ID: <20210319165334.29213-3-andre.przywara@arm.com> (raw) In-Reply-To: <20210319165334.29213-1-andre.przywara@arm.com> The GCC manual suggests to use -pthread, when linking with the PThread library, also to add this switch to both the compilation and linking stages. Do as the manual says, to fix compilation with Ubuntu's 20.04 toolchain, which was getting -lpthread too early on the command line: ------------ /usr/bin/ld: /tmp/cc5zbo2A.o: in function `execute_test': tools/testing/selftests/arm64/mte/check_gcr_el1_cswitch.c:86: undefined reference to `pthread_create' /usr/bin/ld: tools/testing/selftests/arm64/mte/check_gcr_el1_cswitch.c:90: undefined reference to `pthread_join' ------------ Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- tools/testing/selftests/arm64/mte/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/arm64/mte/Makefile b/tools/testing/selftests/arm64/mte/Makefile index df15d44aeb8d..90aadd86fa0d 100644 --- a/tools/testing/selftests/arm64/mte/Makefile +++ b/tools/testing/selftests/arm64/mte/Makefile @@ -1,7 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 # Copyright (C) 2020 ARM Limited -CFLAGS += -std=gnu99 -I. -lpthread +CFLAGS += -std=gnu99 -I. -pthread +LDFLAGS += -pthread SRCS := $(filter-out mte_common_util.c,$(wildcard *.c)) PROGS := $(patsubst %.c,%,$(SRCS)) -- 2.17.5
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com> To: Will Deacon <will@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Shuah Khan <shuah@kernel.org> Cc: Amit Daniel Kachhap <amit.kachhap@arm.com>, Mark Brown <broonie@kernel.org>, Vincenzo Frascino <vincenzo.frascino@arm.com>, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: [PATCH 02/11] kselftest/arm64: mte: Fix pthread linking Date: Fri, 19 Mar 2021 16:53:25 +0000 [thread overview] Message-ID: <20210319165334.29213-3-andre.przywara@arm.com> (raw) In-Reply-To: <20210319165334.29213-1-andre.przywara@arm.com> The GCC manual suggests to use -pthread, when linking with the PThread library, also to add this switch to both the compilation and linking stages. Do as the manual says, to fix compilation with Ubuntu's 20.04 toolchain, which was getting -lpthread too early on the command line: ------------ /usr/bin/ld: /tmp/cc5zbo2A.o: in function `execute_test': tools/testing/selftests/arm64/mte/check_gcr_el1_cswitch.c:86: undefined reference to `pthread_create' /usr/bin/ld: tools/testing/selftests/arm64/mte/check_gcr_el1_cswitch.c:90: undefined reference to `pthread_join' ------------ Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- tools/testing/selftests/arm64/mte/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/arm64/mte/Makefile b/tools/testing/selftests/arm64/mte/Makefile index df15d44aeb8d..90aadd86fa0d 100644 --- a/tools/testing/selftests/arm64/mte/Makefile +++ b/tools/testing/selftests/arm64/mte/Makefile @@ -1,7 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 # Copyright (C) 2020 ARM Limited -CFLAGS += -std=gnu99 -I. -lpthread +CFLAGS += -std=gnu99 -I. -pthread +LDFLAGS += -pthread SRCS := $(filter-out mte_common_util.c,$(wildcard *.c)) PROGS := $(patsubst %.c,%,$(SRCS)) -- 2.17.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-19 16:54 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-19 16:53 [PATCH 00/11] kselftest/arm64: mte: Fix feature detection and compilation Andre Przywara 2021-03-19 16:53 ` Andre Przywara 2021-03-19 16:53 ` [PATCH 01/11] kselftest/arm64: mte: Fix compilation with native compiler Andre Przywara 2021-03-19 16:53 ` Andre Przywara 2021-03-19 17:29 ` Nick Desaulniers 2021-03-19 17:29 ` Nick Desaulniers 2021-03-19 16:53 ` Andre Przywara [this message] 2021-03-19 16:53 ` [PATCH 02/11] kselftest/arm64: mte: Fix pthread linking Andre Przywara 2021-03-19 16:53 ` [PATCH 03/11] kselftest/arm64: mte: ksm_options: Fix fscanf warning Andre Przywara 2021-03-19 16:53 ` Andre Przywara 2021-03-19 16:53 ` [PATCH 04/11] kselftest/arm64: mte: user_mem: Fix write() warning Andre Przywara 2021-03-19 16:53 ` Andre Przywara 2021-03-19 16:53 ` [PATCH 05/11] kselftest/arm64: mte: common: Fix write() warnings Andre Przywara 2021-03-19 16:53 ` Andre Przywara 2021-03-19 16:53 ` [PATCH 06/11] kselftest/arm64: mte: Fix MTE feature detection Andre Przywara 2021-03-19 16:53 ` Andre Przywara 2021-03-19 16:53 ` [PATCH 07/11] kselftest/arm64: mte: Use cross-compiler if specified Andre Przywara 2021-03-19 16:53 ` Andre Przywara 2021-03-19 16:53 ` [PATCH 08/11] kselftest/arm64: mte: Output warning about failing compiler Andre Przywara 2021-03-19 16:53 ` Andre Przywara 2021-03-19 16:53 ` [PATCH 09/11] kselftest/arm64: mte: Makefile: Fix clang compilation Andre Przywara 2021-03-19 16:53 ` Andre Przywara 2021-03-19 16:53 ` [PATCH 10/11] kselftest/arm64: mte: Fix clang warning Andre Przywara 2021-03-19 16:53 ` Andre Przywara 2021-03-19 17:36 ` Nick Desaulniers 2021-03-19 17:36 ` Nick Desaulniers 2021-03-19 16:53 ` [PATCH 11/11] kselftest/arm64: mte: Report filename on failing temp file creation Andre Przywara 2021-03-19 16:53 ` Andre Przywara 2021-03-19 17:12 ` [PATCH 00/11] kselftest/arm64: mte: Fix feature detection and compilation Mark Brown 2021-03-19 17:12 ` Mark Brown 2021-03-23 17:54 ` Catalin Marinas 2021-03-23 17:54 ` Catalin Marinas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210319165334.29213-3-andre.przywara@arm.com \ --to=andre.przywara@arm.com \ --cc=amit.kachhap@arm.com \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=shuah@kernel.org \ --cc=vincenzo.frascino@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.