All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v2 2/3] drm/i915/display: remove FIXME comment for intended feature
Date: Fri, 19 Mar 2021 10:36:02 -0700	[thread overview]
Message-ID: <20210319173603.521779-3-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20210319173603.521779-1-lucas.demarchi@intel.com>

Direction on gen >= 9 was to stop using straps and rely on VBT
indicating if the port is present or not. Remove FIXME comment since
this will never be "fixed".

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index c793cbecfb3b..82471961e721 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -11683,15 +11683,9 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
 
 		icl_dsi_init(dev_priv);
 	} else if (IS_GEN9_LP(dev_priv)) {
-		/*
-		 * FIXME: Broxton doesn't support port detection via the
-		 * DDI_BUF_CTL_A or SFUSE_STRAP registers, find another way to
-		 * detect the ports.
-		 */
 		intel_ddi_init(dev_priv, PORT_A);
 		intel_ddi_init(dev_priv, PORT_B);
 		intel_ddi_init(dev_priv, PORT_C);
-
 		vlv_dsi_init(dev_priv);
 	} else if (HAS_DDI(dev_priv)) {
 		int found;
-- 
2.30.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-03-19 17:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 17:36 [Intel-gfx] [PATCH v2 0/3] Simplify intel_setup_outputs() Lucas De Marchi
2021-03-19 17:36 ` [Intel-gfx] [PATCH v2 1/3] drm/i915/display: move vbt check to intel_ddi_init() Lucas De Marchi
2021-03-19 17:36 ` Lucas De Marchi [this message]
2021-03-23 10:14   ` [Intel-gfx] [PATCH v2 2/3] drm/i915/display: remove FIXME comment for intended feature Jani Nikula
2021-03-19 17:36 ` [Intel-gfx] [PATCH v2 3/3] drm/i915/display: remove strap checks from gen 9 Lucas De Marchi
2021-04-07 16:14   ` Srivatsa, Anusha
2021-03-19 18:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Simplify intel_setup_outputs() (rev2) Patchwork
2021-03-19 18:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-19 21:02 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-03-23 22:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Simplify intel_setup_outputs() (rev3) Patchwork
2021-03-23 23:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-24 17:09 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-03-24 18:00   ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210319173603.521779-3-lucas.demarchi@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.