From: Ming Lei <ming.lei@redhat.com> To: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, Jeffle Xu <jefflexu@linux.alibaba.com>, Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com, Ming Lei <ming.lei@redhat.com> Subject: [PATCH V3 05/13] block: add req flag of REQ_POLL_CTX Date: Wed, 24 Mar 2021 20:19:19 +0800 [thread overview] Message-ID: <20210324121927.362525-6-ming.lei@redhat.com> (raw) In-Reply-To: <20210324121927.362525-1-ming.lei@redhat.com> Add one req flag REQ_POLL_CTX which will be used in the following patch for supporting bio based IO polling. Exactly this flag can help us to do: 1) request flag is cloned in bio_fast_clone(), so if we mark one FS bio as REQ_POLL_CTX, all bios cloned from this FS bio will be marked as REQ_POLL_CTX too. 2) create per-task io polling context if the bio based queue supports polling and the submitted bio is HIPRI. Per-task io poll context will be created during submit_bio() before marking this HIPRI bio as REQ_POLL_CTX. Then we can avoid to create such io polling context if one cloned bio with REQ_POLL_CTX is submitted from another kernel context. 3) for supporting bio based io polling, we need to poll IOs from all underlying queues of the bio device, this way help us to recognize which IO needs to polled in bio based style, which will be applied in following patch. Signed-off-by: Ming Lei <ming.lei@redhat.com> --- block/blk-core.c | 25 ++++++++++++++++++++++++- include/linux/blk_types.h | 4 ++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/block/blk-core.c b/block/blk-core.c index 4671bbf31fd3..eb07d61cfdc2 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -840,11 +840,30 @@ static inline bool blk_queue_support_bio_poll(struct request_queue *q) static inline void blk_bio_poll_preprocess(struct request_queue *q, struct bio *bio) { + bool mq; + if (!(bio->bi_opf & REQ_HIPRI)) return; - if (!blk_queue_poll(q) || (!queue_is_mq(q) && !blk_get_bio_poll_ctx())) + /* + * Can't support bio based IO polling without per-task poll ctx + * + * We have created per-task io poll context, and mark this + * bio as REQ_POLL_CTX, so: 1) if any cloned bio from this bio is + * submitted from another kernel context, we won't create bio + * poll context for it, and that bio can be completed by IRQ; + * 2) If such bio is submitted from current context, we will + * complete it via blk_poll(); 3) If driver knows that one + * underlying bio allocated from driver is for FS bio, meantime + * it is submitted in current context, driver can mark such bio + * as REQ_HIPRI & REQ_POLL_CTX manually, so the bio can be completed + * via blk_poll too. + */ + mq = queue_is_mq(q); + if (!blk_queue_poll(q) || (!mq && !blk_get_bio_poll_ctx())) bio->bi_opf &= ~REQ_HIPRI; + else if (!mq) + bio->bi_opf |= REQ_POLL_CTX; } static noinline_for_stack bool submit_bio_checks(struct bio *bio) @@ -894,8 +913,12 @@ static noinline_for_stack bool submit_bio_checks(struct bio *bio) /* * Create per-task io poll ctx if bio polling supported and HIPRI * set. + * + * If REQ_POLL_CTX isn't set for this HIPRI bio, we think it originated + * from FS and allocate io polling context. */ blk_create_io_context(q, blk_queue_support_bio_poll(q) && + !(bio->bi_opf & REQ_POLL_CTX) && (bio->bi_opf & REQ_HIPRI)); blk_bio_poll_preprocess(q, bio); diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index db026b6ec15a..99160d588c2d 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -394,6 +394,9 @@ enum req_flag_bits { __REQ_HIPRI, + /* for marking IOs originated from same FS bio in same context */ + __REQ_POLL_CTX, + /* for driver use */ __REQ_DRV, __REQ_SWAP, /* swapping request. */ @@ -418,6 +421,7 @@ enum req_flag_bits { #define REQ_NOUNMAP (1ULL << __REQ_NOUNMAP) #define REQ_HIPRI (1ULL << __REQ_HIPRI) +#define REQ_POLL_CTX (1ULL << __REQ_POLL_CTX) #define REQ_DRV (1ULL << __REQ_DRV) #define REQ_SWAP (1ULL << __REQ_SWAP) -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com> To: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, Jeffle Xu <jefflexu@linux.alibaba.com>, dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>, Ming Lei <ming.lei@redhat.com> Subject: [dm-devel] [PATCH V3 05/13] block: add req flag of REQ_POLL_CTX Date: Wed, 24 Mar 2021 20:19:19 +0800 [thread overview] Message-ID: <20210324121927.362525-6-ming.lei@redhat.com> (raw) In-Reply-To: <20210324121927.362525-1-ming.lei@redhat.com> Add one req flag REQ_POLL_CTX which will be used in the following patch for supporting bio based IO polling. Exactly this flag can help us to do: 1) request flag is cloned in bio_fast_clone(), so if we mark one FS bio as REQ_POLL_CTX, all bios cloned from this FS bio will be marked as REQ_POLL_CTX too. 2) create per-task io polling context if the bio based queue supports polling and the submitted bio is HIPRI. Per-task io poll context will be created during submit_bio() before marking this HIPRI bio as REQ_POLL_CTX. Then we can avoid to create such io polling context if one cloned bio with REQ_POLL_CTX is submitted from another kernel context. 3) for supporting bio based io polling, we need to poll IOs from all underlying queues of the bio device, this way help us to recognize which IO needs to polled in bio based style, which will be applied in following patch. Signed-off-by: Ming Lei <ming.lei@redhat.com> --- block/blk-core.c | 25 ++++++++++++++++++++++++- include/linux/blk_types.h | 4 ++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/block/blk-core.c b/block/blk-core.c index 4671bbf31fd3..eb07d61cfdc2 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -840,11 +840,30 @@ static inline bool blk_queue_support_bio_poll(struct request_queue *q) static inline void blk_bio_poll_preprocess(struct request_queue *q, struct bio *bio) { + bool mq; + if (!(bio->bi_opf & REQ_HIPRI)) return; - if (!blk_queue_poll(q) || (!queue_is_mq(q) && !blk_get_bio_poll_ctx())) + /* + * Can't support bio based IO polling without per-task poll ctx + * + * We have created per-task io poll context, and mark this + * bio as REQ_POLL_CTX, so: 1) if any cloned bio from this bio is + * submitted from another kernel context, we won't create bio + * poll context for it, and that bio can be completed by IRQ; + * 2) If such bio is submitted from current context, we will + * complete it via blk_poll(); 3) If driver knows that one + * underlying bio allocated from driver is for FS bio, meantime + * it is submitted in current context, driver can mark such bio + * as REQ_HIPRI & REQ_POLL_CTX manually, so the bio can be completed + * via blk_poll too. + */ + mq = queue_is_mq(q); + if (!blk_queue_poll(q) || (!mq && !blk_get_bio_poll_ctx())) bio->bi_opf &= ~REQ_HIPRI; + else if (!mq) + bio->bi_opf |= REQ_POLL_CTX; } static noinline_for_stack bool submit_bio_checks(struct bio *bio) @@ -894,8 +913,12 @@ static noinline_for_stack bool submit_bio_checks(struct bio *bio) /* * Create per-task io poll ctx if bio polling supported and HIPRI * set. + * + * If REQ_POLL_CTX isn't set for this HIPRI bio, we think it originated + * from FS and allocate io polling context. */ blk_create_io_context(q, blk_queue_support_bio_poll(q) && + !(bio->bi_opf & REQ_POLL_CTX) && (bio->bi_opf & REQ_HIPRI)); blk_bio_poll_preprocess(q, bio); diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index db026b6ec15a..99160d588c2d 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -394,6 +394,9 @@ enum req_flag_bits { __REQ_HIPRI, + /* for marking IOs originated from same FS bio in same context */ + __REQ_POLL_CTX, + /* for driver use */ __REQ_DRV, __REQ_SWAP, /* swapping request. */ @@ -418,6 +421,7 @@ enum req_flag_bits { #define REQ_NOUNMAP (1ULL << __REQ_NOUNMAP) #define REQ_HIPRI (1ULL << __REQ_HIPRI) +#define REQ_POLL_CTX (1ULL << __REQ_POLL_CTX) #define REQ_DRV (1ULL << __REQ_DRV) #define REQ_SWAP (1ULL << __REQ_SWAP) -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-03-24 12:21 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-24 12:19 [PATCH V3 00/13] block: support bio based io polling Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 12:19 ` [PATCH V3 01/13] block: add helper of blk_queue_poll Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 13:19 ` Hannes Reinecke 2021-03-24 13:19 ` [dm-devel] " Hannes Reinecke 2021-03-24 17:54 ` Christoph Hellwig 2021-03-24 17:54 ` [dm-devel] " Christoph Hellwig 2021-03-25 1:56 ` JeffleXu 2021-03-25 1:56 ` [dm-devel] " JeffleXu 2021-03-24 12:19 ` [PATCH V3 02/13] block: add one helper to free io_context Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 13:21 ` Hannes Reinecke 2021-03-24 13:21 ` [dm-devel] " Hannes Reinecke 2021-03-24 12:19 ` [PATCH V3 03/13] block: add helper of blk_create_io_context Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 13:22 ` Hannes Reinecke 2021-03-24 13:22 ` [dm-devel] " Hannes Reinecke 2021-03-24 15:52 ` Keith Busch 2021-03-24 15:52 ` [dm-devel] " Keith Busch 2021-03-24 18:17 ` Christoph Hellwig 2021-03-24 18:17 ` [dm-devel] " Christoph Hellwig 2021-03-25 0:30 ` Ming Lei 2021-03-25 0:30 ` [dm-devel] " Ming Lei 2021-03-24 12:19 ` [PATCH V3 04/13] block: create io poll context for submission and poll task Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 13:26 ` Hannes Reinecke 2021-03-24 13:26 ` [dm-devel] " Hannes Reinecke 2021-03-25 2:34 ` JeffleXu 2021-03-25 2:34 ` [dm-devel] " JeffleXu 2021-03-25 2:51 ` Ming Lei 2021-03-25 2:51 ` [dm-devel] " Ming Lei 2021-03-25 3:01 ` JeffleXu 2021-03-25 3:01 ` [dm-devel] " JeffleXu 2021-03-24 12:19 ` Ming Lei [this message] 2021-03-24 12:19 ` [dm-devel] [PATCH V3 05/13] block: add req flag of REQ_POLL_CTX Ming Lei 2021-03-24 15:32 ` Hannes Reinecke 2021-03-24 15:32 ` [dm-devel] " Hannes Reinecke 2021-03-25 0:32 ` Ming Lei 2021-03-25 0:32 ` [dm-devel] " Ming Lei 2021-03-25 6:55 ` JeffleXu 2021-03-25 6:55 ` [dm-devel] " JeffleXu 2021-03-24 12:19 ` [PATCH V3 06/13] block: add new field into 'struct bvec_iter' Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 15:33 ` Hannes Reinecke 2021-03-24 15:33 ` [dm-devel] " Hannes Reinecke 2021-03-24 12:19 ` [PATCH V3 07/13] block/mq: extract one helper function polling hw queue Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-25 6:50 ` Hannes Reinecke 2021-03-25 6:50 ` [dm-devel] " Hannes Reinecke 2021-03-24 12:19 ` [PATCH V3 08/13] block: prepare for supporting bio_list via other link Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-26 15:02 ` Hannes Reinecke 2021-03-26 15:02 ` [dm-devel] " Hannes Reinecke 2021-03-24 12:19 ` [PATCH V3 09/13] block: use per-task poll context to implement bio based io polling Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-25 6:34 ` JeffleXu 2021-03-25 6:34 ` [dm-devel] " JeffleXu 2021-03-25 8:05 ` Ming Lei 2021-03-25 8:05 ` [dm-devel] " Ming Lei 2021-03-25 9:18 ` JeffleXu 2021-03-25 9:18 ` [dm-devel] " JeffleXu 2021-03-25 9:56 ` Ming Lei 2021-03-25 9:56 ` [dm-devel] " Ming Lei 2021-03-24 12:19 ` [PATCH V3 10/13] blk-mq: limit hw queues to be polled in each blk_poll() Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 12:19 ` [PATCH V3 11/13] block: add queue_to_disk() to get gendisk from request_queue Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 12:19 ` [PATCH V3 12/13] block: add poll_capable method to support bio-based IO polling Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 12:19 ` [PATCH V3 13/13] dm: support IO polling for bio-based dm device Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-25 18:45 ` Mike Snitzer 2021-03-25 18:45 ` [dm-devel] " Mike Snitzer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210324121927.362525-6-ming.lei@redhat.com \ --to=ming.lei@redhat.com \ --cc=axboe@kernel.dk \ --cc=dm-devel@redhat.com \ --cc=jefflexu@linux.alibaba.com \ --cc=linux-block@vger.kernel.org \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.