From: Joao Martins <joao.m.martins@oracle.com> To: linux-mm@kvack.org Cc: linux-nvdimm@lists.01.org, Matthew Wilcox <willy@infradead.org>, Jason Gunthorpe <jgg@ziepe.ca>, Muchun Song <songmuchun@bytedance.com>, Mike Kravetz <mike.kravetz@oracle.com>, Andrew Morton <akpm@linux-foundation.org>, Joao Martins <joao.m.martins@oracle.com> Subject: [PATCH v1 06/11] mm/sparse-vmemmap: refactor vmemmap_populate_basepages() Date: Thu, 25 Mar 2021 23:09:33 +0000 [thread overview] Message-ID: <20210325230938.30752-7-joao.m.martins@oracle.com> (raw) In-Reply-To: <20210325230938.30752-1-joao.m.martins@oracle.com> Move the actual pte population logic into a separate function vmemmap_populate_address() and have vmemmap_populate_basepages() walk through all base pages it needs to populate. Signed-off-by: Joao Martins <joao.m.martins@oracle.com> --- mm/sparse-vmemmap.c | 44 ++++++++++++++++++++++++++------------------ 1 file changed, 26 insertions(+), 18 deletions(-) diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index 370728c206ee..8814876edcfa 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -216,33 +216,41 @@ pgd_t * __meminit vmemmap_pgd_populate(unsigned long addr, int node) return pgd; } -int __meminit vmemmap_populate_basepages(unsigned long start, unsigned long end, - int node, struct vmem_altmap *altmap) +static int __meminit vmemmap_populate_address(unsigned long addr, int node, + struct vmem_altmap *altmap) { - unsigned long addr = start; pgd_t *pgd; p4d_t *p4d; pud_t *pud; pmd_t *pmd; pte_t *pte; + pgd = vmemmap_pgd_populate(addr, node); + if (!pgd) + return -ENOMEM; + p4d = vmemmap_p4d_populate(pgd, addr, node); + if (!p4d) + return -ENOMEM; + pud = vmemmap_pud_populate(p4d, addr, node); + if (!pud) + return -ENOMEM; + pmd = vmemmap_pmd_populate(pud, addr, node); + if (!pmd) + return -ENOMEM; + pte = vmemmap_pte_populate(pmd, addr, node, altmap); + if (!pte) + return -ENOMEM; + vmemmap_verify(pte, node, addr, addr + PAGE_SIZE); +} + +int __meminit vmemmap_populate_basepages(unsigned long start, unsigned long end, + int node, struct vmem_altmap *altmap) +{ + unsigned long addr = start; + for (; addr < end; addr += PAGE_SIZE) { - pgd = vmemmap_pgd_populate(addr, node); - if (!pgd) - return -ENOMEM; - p4d = vmemmap_p4d_populate(pgd, addr, node); - if (!p4d) - return -ENOMEM; - pud = vmemmap_pud_populate(p4d, addr, node); - if (!pud) - return -ENOMEM; - pmd = vmemmap_pmd_populate(pud, addr, node); - if (!pmd) - return -ENOMEM; - pte = vmemmap_pte_populate(pmd, addr, node, altmap); - if (!pte) + if (vmemmap_populate_address(addr, node, altmap)) return -ENOMEM; - vmemmap_verify(pte, node, addr, addr + PAGE_SIZE); } return 0; -- 2.17.1 _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Joao Martins <joao.m.martins@oracle.com> To: linux-mm@kvack.org Cc: Dan Williams <dan.j.williams@intel.com>, Ira Weiny <ira.weiny@intel.com>, linux-nvdimm@lists.01.org, Matthew Wilcox <willy@infradead.org>, Jason Gunthorpe <jgg@ziepe.ca>, Jane Chu <jane.chu@oracle.com>, Muchun Song <songmuchun@bytedance.com>, Mike Kravetz <mike.kravetz@oracle.com>, Andrew Morton <akpm@linux-foundation.org>, Joao Martins <joao.m.martins@oracle.com> Subject: [PATCH v1 06/11] mm/sparse-vmemmap: refactor vmemmap_populate_basepages() Date: Thu, 25 Mar 2021 23:09:33 +0000 [thread overview] Message-ID: <20210325230938.30752-7-joao.m.martins@oracle.com> (raw) In-Reply-To: <20210325230938.30752-1-joao.m.martins@oracle.com> Move the actual pte population logic into a separate function vmemmap_populate_address() and have vmemmap_populate_basepages() walk through all base pages it needs to populate. Signed-off-by: Joao Martins <joao.m.martins@oracle.com> --- mm/sparse-vmemmap.c | 44 ++++++++++++++++++++++++++------------------ 1 file changed, 26 insertions(+), 18 deletions(-) diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index 370728c206ee..8814876edcfa 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -216,33 +216,41 @@ pgd_t * __meminit vmemmap_pgd_populate(unsigned long addr, int node) return pgd; } -int __meminit vmemmap_populate_basepages(unsigned long start, unsigned long end, - int node, struct vmem_altmap *altmap) +static int __meminit vmemmap_populate_address(unsigned long addr, int node, + struct vmem_altmap *altmap) { - unsigned long addr = start; pgd_t *pgd; p4d_t *p4d; pud_t *pud; pmd_t *pmd; pte_t *pte; + pgd = vmemmap_pgd_populate(addr, node); + if (!pgd) + return -ENOMEM; + p4d = vmemmap_p4d_populate(pgd, addr, node); + if (!p4d) + return -ENOMEM; + pud = vmemmap_pud_populate(p4d, addr, node); + if (!pud) + return -ENOMEM; + pmd = vmemmap_pmd_populate(pud, addr, node); + if (!pmd) + return -ENOMEM; + pte = vmemmap_pte_populate(pmd, addr, node, altmap); + if (!pte) + return -ENOMEM; + vmemmap_verify(pte, node, addr, addr + PAGE_SIZE); +} + +int __meminit vmemmap_populate_basepages(unsigned long start, unsigned long end, + int node, struct vmem_altmap *altmap) +{ + unsigned long addr = start; + for (; addr < end; addr += PAGE_SIZE) { - pgd = vmemmap_pgd_populate(addr, node); - if (!pgd) - return -ENOMEM; - p4d = vmemmap_p4d_populate(pgd, addr, node); - if (!p4d) - return -ENOMEM; - pud = vmemmap_pud_populate(p4d, addr, node); - if (!pud) - return -ENOMEM; - pmd = vmemmap_pmd_populate(pud, addr, node); - if (!pmd) - return -ENOMEM; - pte = vmemmap_pte_populate(pmd, addr, node, altmap); - if (!pte) + if (vmemmap_populate_address(addr, node, altmap)) return -ENOMEM; - vmemmap_verify(pte, node, addr, addr + PAGE_SIZE); } return 0; -- 2.17.1
next prev parent reply other threads:[~2021-03-25 23:10 UTC|newest] Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-25 23:09 [PATCH v1 00/11] mm, sparse-vmemmap: Introduce compound pagemaps Joao Martins 2021-03-25 23:09 ` Joao Martins 2021-03-25 23:09 ` [PATCH v1 01/11] memory-failure: fetch compound_head after pgmap_pfn_valid() Joao Martins 2021-03-25 23:09 ` Joao Martins 2021-04-24 0:12 ` Dan Williams 2021-04-24 0:12 ` Dan Williams 2021-04-24 19:00 ` Joao Martins 2021-04-24 19:00 ` Joao Martins 2021-03-25 23:09 ` [PATCH v1 02/11] mm/page_alloc: split prep_compound_page into head and tail subparts Joao Martins 2021-03-25 23:09 ` Joao Martins 2021-04-24 0:16 ` Dan Williams 2021-04-24 0:16 ` Dan Williams 2021-04-24 19:05 ` Joao Martins 2021-04-24 19:05 ` Joao Martins 2021-03-25 23:09 ` [PATCH v1 03/11] mm/page_alloc: refactor memmap_init_zone_device() page init Joao Martins 2021-03-25 23:09 ` Joao Martins 2021-04-24 0:18 ` Dan Williams 2021-04-24 0:18 ` Dan Williams 2021-04-24 19:05 ` Joao Martins 2021-04-24 19:05 ` Joao Martins 2021-03-25 23:09 ` [PATCH v1 04/11] mm/memremap: add ZONE_DEVICE support for compound pages Joao Martins 2021-03-25 23:09 ` Joao Martins 2021-05-05 18:44 ` Dan Williams 2021-05-05 18:44 ` Dan Williams 2021-05-05 18:58 ` Matthew Wilcox 2021-05-05 18:58 ` Matthew Wilcox 2021-05-05 19:49 ` Joao Martins 2021-05-05 19:49 ` Joao Martins 2021-05-05 22:20 ` Dan Williams 2021-05-05 22:20 ` Dan Williams 2021-05-05 22:36 ` Joao Martins 2021-05-05 22:36 ` Joao Martins 2021-05-05 23:03 ` Dan Williams 2021-05-05 23:03 ` Dan Williams 2021-05-06 10:12 ` Joao Martins 2021-05-06 10:12 ` Joao Martins 2021-05-18 17:27 ` Joao Martins 2021-05-18 17:27 ` Joao Martins 2021-05-18 19:56 ` Jane Chu 2021-05-18 19:56 ` Jane Chu 2021-05-19 11:29 ` Joao Martins 2021-05-19 11:29 ` Joao Martins 2021-05-19 18:36 ` Jane Chu 2021-06-07 20:17 ` Dan Williams 2021-06-07 20:47 ` Joao Martins 2021-06-07 21:00 ` Joao Martins 2021-06-07 21:57 ` Dan Williams 2021-05-06 8:05 ` Aneesh Kumar K.V 2021-05-06 8:05 ` Aneesh Kumar K.V 2021-05-06 10:23 ` Joao Martins 2021-05-06 10:23 ` Joao Martins 2021-05-06 11:43 ` Matthew Wilcox 2021-05-06 11:43 ` Matthew Wilcox 2021-05-06 12:15 ` Joao Martins 2021-05-06 12:15 ` Joao Martins 2021-03-25 23:09 ` [PATCH v1 05/11] mm/sparse-vmemmap: add a pgmap argument to section activation Joao Martins 2021-03-25 23:09 ` Joao Martins 2021-05-05 22:34 ` Dan Williams 2021-05-05 22:34 ` Dan Williams 2021-05-05 22:37 ` Joao Martins 2021-05-05 22:37 ` Joao Martins 2021-05-05 23:14 ` Dan Williams 2021-05-05 23:14 ` Dan Williams 2021-05-06 10:24 ` Joao Martins 2021-05-06 10:24 ` Joao Martins 2021-03-25 23:09 ` Joao Martins [this message] 2021-03-25 23:09 ` [PATCH v1 06/11] mm/sparse-vmemmap: refactor vmemmap_populate_basepages() Joao Martins 2021-05-05 22:43 ` Dan Williams 2021-05-05 22:43 ` Dan Williams 2021-05-06 10:27 ` Joao Martins 2021-05-06 10:27 ` Joao Martins 2021-05-06 18:36 ` Joao Martins 2021-05-06 18:36 ` Joao Martins 2021-03-25 23:09 ` [PATCH v1 07/11] mm/sparse-vmemmap: populate compound pagemaps Joao Martins 2021-03-25 23:09 ` Joao Martins 2021-05-06 1:18 ` Dan Williams 2021-05-06 1:18 ` Dan Williams 2021-05-06 11:01 ` Joao Martins 2021-05-06 11:01 ` Joao Martins 2021-05-10 19:19 ` Dan Williams 2021-05-10 19:19 ` Dan Williams 2021-05-13 18:45 ` Joao Martins 2021-05-13 18:45 ` Joao Martins 2021-06-16 15:05 ` Joao Martins 2021-06-16 23:35 ` Dan Williams 2021-03-25 23:09 ` [PATCH v1 08/11] mm/sparse-vmemmap: use hugepages for PUD " Joao Martins 2021-03-25 23:09 ` Joao Martins 2021-06-01 19:30 ` Dan Williams 2021-06-07 12:02 ` Joao Martins 2021-06-07 19:47 ` Dan Williams 2021-03-25 23:09 ` [PATCH v1 09/11] mm/page_alloc: reuse tail struct pages for " Joao Martins 2021-03-25 23:09 ` Joao Martins 2021-06-01 23:35 ` Dan Williams 2021-06-07 13:48 ` Joao Martins 2021-06-07 19:32 ` Dan Williams 2021-06-14 18:41 ` Joao Martins 2021-06-14 23:07 ` Dan Williams 2021-03-25 23:09 ` [PATCH v1 10/11] device-dax: compound pagemap support Joao Martins 2021-03-25 23:09 ` Joao Martins 2021-06-02 0:36 ` Dan Williams 2021-06-07 13:59 ` Joao Martins 2021-03-25 23:09 ` [PATCH v1 11/11] mm/gup: grab head page refcount once for group of subpages Joao Martins 2021-03-25 23:09 ` Joao Martins 2021-06-02 1:05 ` Dan Williams 2021-06-07 15:21 ` Joao Martins 2021-06-07 19:22 ` Dan Williams 2021-04-01 9:38 ` [PATCH v1 00/11] mm, sparse-vmemmap: Introduce compound pagemaps Joao Martins 2021-04-01 9:38 ` Joao Martins
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210325230938.30752-7-joao.m.martins@oracle.com \ --to=joao.m.martins@oracle.com \ --cc=akpm@linux-foundation.org \ --cc=jgg@ziepe.ca \ --cc=linux-mm@kvack.org \ --cc=linux-nvdimm@lists.01.org \ --cc=mike.kravetz@oracle.com \ --cc=songmuchun@bytedance.com \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.