From: Tyler Hicks <tyhicks@linux.microsoft.com> To: Dan Williams <dan.j.williams@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>, Ira Weiny <ira.weiny@intel.com> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>, Pavel Tatashin <pasha.tatashin@soleen.com>, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Subject: [PATCH] libnvdimm/region: Allow setting align attribute on regions without mappings Date: Fri, 26 Mar 2021 10:26:45 -0500 [thread overview] Message-ID: <20210326152645.85225-1-tyhicks@linux.microsoft.com> (raw) The alignment constraint for namespace creation in a region was increased, from 2M to 16M, for non-PowerPC architectures in v5.7 with commit 2522afb86a8c ("libnvdimm/region: Introduce an 'align' attribute"). The thought behind the change was that region alignment should be uniform across all architectures and, since PowerPC had the largest alignment constraint of 16M, all architectures should conform to that alignment. The change regressed namespace creation in pre-defined regions that relied on 2M alignment but a workaround was provided in the form of a sysfs attribute, named 'align', that could be adjusted to a non-default alignment value. However, the sysfs attribute's store function returned an error (-ENXIO) when userspace attempted to change the alignment of a region that had no mappings. This affected 2M aligned regions of volatile memory that were defined in a device tree using "pmem-region" and created by the of_pmem_region_driver, since those regions do not contain mappings (ndr_mappings is 0). Allow userspace to set the align attribute on pre-existing regions that do not have mappings so that namespaces can still be within those regions, despite not being aligned to 16M. Fixes: 2522afb86a8c ("libnvdimm/region: Introduce an 'align' attribute") Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com> --- drivers/nvdimm/region_devs.c | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c index ef23119db574..09cff8aa6b40 100644 --- a/drivers/nvdimm/region_devs.c +++ b/drivers/nvdimm/region_devs.c @@ -545,29 +545,32 @@ static ssize_t align_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) { struct nd_region *nd_region = to_nd_region(dev); - unsigned long val, dpa; - u32 remainder; + unsigned long val; int rc; rc = kstrtoul(buf, 0, &val); if (rc) return rc; - if (!nd_region->ndr_mappings) - return -ENXIO; - - /* - * Ensure space-align is evenly divisible by the region - * interleave-width because the kernel typically has no facility - * to determine which DIMM(s), dimm-physical-addresses, would - * contribute to the tail capacity in system-physical-address - * space for the namespace. - */ - dpa = div_u64_rem(val, nd_region->ndr_mappings, &remainder); - if (!is_power_of_2(dpa) || dpa < PAGE_SIZE - || val > region_size(nd_region) || remainder) + if (val > region_size(nd_region)) return -EINVAL; + if (nd_region->ndr_mappings) { + unsigned long dpa; + u32 remainder; + + /* + * Ensure space-align is evenly divisible by the region + * interleave-width because the kernel typically has no facility + * to determine which DIMM(s), dimm-physical-addresses, would + * contribute to the tail capacity in system-physical-address + * space for the namespace. + */ + dpa = div_u64_rem(val, nd_region->ndr_mappings, &remainder); + if (!is_power_of_2(dpa) || dpa < PAGE_SIZE || remainder) + return -EINVAL; + } + /* * Given that space allocation consults this value multiple * times ensure it does not change for the duration of the -- 2.25.1 _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Tyler Hicks <tyhicks@linux.microsoft.com> To: Dan Williams <dan.j.williams@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>, Ira Weiny <ira.weiny@intel.com> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>, Jeff Moyer <jmoyer@redhat.com>, Pavel Tatashin <pasha.tatashin@soleen.com>, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Subject: [PATCH] libnvdimm/region: Allow setting align attribute on regions without mappings Date: Fri, 26 Mar 2021 10:26:45 -0500 [thread overview] Message-ID: <20210326152645.85225-1-tyhicks@linux.microsoft.com> (raw) The alignment constraint for namespace creation in a region was increased, from 2M to 16M, for non-PowerPC architectures in v5.7 with commit 2522afb86a8c ("libnvdimm/region: Introduce an 'align' attribute"). The thought behind the change was that region alignment should be uniform across all architectures and, since PowerPC had the largest alignment constraint of 16M, all architectures should conform to that alignment. The change regressed namespace creation in pre-defined regions that relied on 2M alignment but a workaround was provided in the form of a sysfs attribute, named 'align', that could be adjusted to a non-default alignment value. However, the sysfs attribute's store function returned an error (-ENXIO) when userspace attempted to change the alignment of a region that had no mappings. This affected 2M aligned regions of volatile memory that were defined in a device tree using "pmem-region" and created by the of_pmem_region_driver, since those regions do not contain mappings (ndr_mappings is 0). Allow userspace to set the align attribute on pre-existing regions that do not have mappings so that namespaces can still be within those regions, despite not being aligned to 16M. Fixes: 2522afb86a8c ("libnvdimm/region: Introduce an 'align' attribute") Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com> --- drivers/nvdimm/region_devs.c | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c index ef23119db574..09cff8aa6b40 100644 --- a/drivers/nvdimm/region_devs.c +++ b/drivers/nvdimm/region_devs.c @@ -545,29 +545,32 @@ static ssize_t align_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) { struct nd_region *nd_region = to_nd_region(dev); - unsigned long val, dpa; - u32 remainder; + unsigned long val; int rc; rc = kstrtoul(buf, 0, &val); if (rc) return rc; - if (!nd_region->ndr_mappings) - return -ENXIO; - - /* - * Ensure space-align is evenly divisible by the region - * interleave-width because the kernel typically has no facility - * to determine which DIMM(s), dimm-physical-addresses, would - * contribute to the tail capacity in system-physical-address - * space for the namespace. - */ - dpa = div_u64_rem(val, nd_region->ndr_mappings, &remainder); - if (!is_power_of_2(dpa) || dpa < PAGE_SIZE - || val > region_size(nd_region) || remainder) + if (val > region_size(nd_region)) return -EINVAL; + if (nd_region->ndr_mappings) { + unsigned long dpa; + u32 remainder; + + /* + * Ensure space-align is evenly divisible by the region + * interleave-width because the kernel typically has no facility + * to determine which DIMM(s), dimm-physical-addresses, would + * contribute to the tail capacity in system-physical-address + * space for the namespace. + */ + dpa = div_u64_rem(val, nd_region->ndr_mappings, &remainder); + if (!is_power_of_2(dpa) || dpa < PAGE_SIZE || remainder) + return -EINVAL; + } + /* * Given that space allocation consults this value multiple * times ensure it does not change for the duration of the -- 2.25.1
next reply other threads:[~2021-03-26 15:27 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-26 15:26 Tyler Hicks [this message] 2021-03-26 15:26 ` [PATCH] libnvdimm/region: Allow setting align attribute on regions without mappings Tyler Hicks 2021-03-26 22:03 ` Pavel Tatashin 2021-03-26 22:03 ` Pavel Tatashin 2021-03-30 11:02 ` Aneesh Kumar K.V 2021-03-30 11:02 ` Aneesh Kumar K.V 2021-03-30 15:43 ` Tyler Hicks 2021-03-30 15:43 ` Tyler Hicks
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210326152645.85225-1-tyhicks@linux.microsoft.com \ --to=tyhicks@linux.microsoft.com \ --cc=aneesh.kumar@linux.ibm.com \ --cc=dan.j.williams@intel.com \ --cc=dave.jiang@intel.com \ --cc=ira.weiny@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=pasha.tatashin@soleen.com \ --cc=vishal.l.verma@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.