From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/Microchip (AT91) SoC support)
Subject: [PATCH 03/17] ASoC: atmel: atmel-i2s: remove useless initialization
Date: Fri, 26 Mar 2021 16:59:13 -0500 [thread overview]
Message-ID: <20210326215927.936377-4-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com>
Cppcheck complains:
sound/soc/atmel/atmel-i2s.c:628:6: style: Redundant initialization for 'err'. The initialized value is overwritten before it is read. [redundantInitialization]
err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
^
sound/soc/atmel/atmel-i2s.c:598:10: note: err is initialized
int err = -ENXIO;
^
sound/soc/atmel/atmel-i2s.c:628:6: note: err is overwritten
err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/atmel/atmel-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/atmel/atmel-i2s.c b/sound/soc/atmel/atmel-i2s.c
index 7c6187e41f2b..584656cc7d3c 100644
--- a/sound/soc/atmel/atmel-i2s.c
+++ b/sound/soc/atmel/atmel-i2s.c
@@ -595,7 +595,7 @@ static int atmel_i2s_probe(struct platform_device *pdev)
struct regmap *regmap;
void __iomem *base;
int irq;
- int err = -ENXIO;
+ int err;
unsigned int pcm_flags = 0;
unsigned int version;
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
tiwai@suse.de, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
broonie@kernel.org,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
"moderated list:ARM/Microchip AT91 SoC support"
<linux-arm-kernel@lists.infradead.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>
Subject: [PATCH 03/17] ASoC: atmel: atmel-i2s: remove useless initialization
Date: Fri, 26 Mar 2021 16:59:13 -0500 [thread overview]
Message-ID: <20210326215927.936377-4-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com>
Cppcheck complains:
sound/soc/atmel/atmel-i2s.c:628:6: style: Redundant initialization for 'err'. The initialized value is overwritten before it is read. [redundantInitialization]
err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
^
sound/soc/atmel/atmel-i2s.c:598:10: note: err is initialized
int err = -ENXIO;
^
sound/soc/atmel/atmel-i2s.c:628:6: note: err is overwritten
err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/atmel/atmel-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/atmel/atmel-i2s.c b/sound/soc/atmel/atmel-i2s.c
index 7c6187e41f2b..584656cc7d3c 100644
--- a/sound/soc/atmel/atmel-i2s.c
+++ b/sound/soc/atmel/atmel-i2s.c
@@ -595,7 +595,7 @@ static int atmel_i2s_probe(struct platform_device *pdev)
struct regmap *regmap;
void __iomem *base;
int irq;
- int err = -ENXIO;
+ int err;
unsigned int pcm_flags = 0;
unsigned int version;
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
tiwai@suse.de, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
broonie@kernel.org,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
Jaroslav Kysela <perex@perex.cz>,
"moderated list:ARM/Microchip AT91 SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH 03/17] ASoC: atmel: atmel-i2s: remove useless initialization
Date: Fri, 26 Mar 2021 16:59:13 -0500 [thread overview]
Message-ID: <20210326215927.936377-4-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com>
Cppcheck complains:
sound/soc/atmel/atmel-i2s.c:628:6: style: Redundant initialization for 'err'. The initialized value is overwritten before it is read. [redundantInitialization]
err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
^
sound/soc/atmel/atmel-i2s.c:598:10: note: err is initialized
int err = -ENXIO;
^
sound/soc/atmel/atmel-i2s.c:628:6: note: err is overwritten
err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/atmel/atmel-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/atmel/atmel-i2s.c b/sound/soc/atmel/atmel-i2s.c
index 7c6187e41f2b..584656cc7d3c 100644
--- a/sound/soc/atmel/atmel-i2s.c
+++ b/sound/soc/atmel/atmel-i2s.c
@@ -595,7 +595,7 @@ static int atmel_i2s_probe(struct platform_device *pdev)
struct regmap *regmap;
void __iomem *base;
int irq;
- int err = -ENXIO;
+ int err;
unsigned int pcm_flags = 0;
unsigned int version;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-26 22:00 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 21:59 [PATCH 00/17] ASoC: remove cppcheck warnings for multiple SOCs Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 01/17] ASoC: amd: renoir: acp3x-pdm-dma: remove unnecessary assignments Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 02/17] ASoC: atmel: fix shadowed variable Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-29 7:38 ` Codrin.Ciubotariu
2021-03-29 7:38 ` Codrin.Ciubotariu
2021-03-29 7:38 ` Codrin.Ciubotariu
2021-03-26 21:59 ` Pierre-Louis Bossart [this message]
2021-03-26 21:59 ` [PATCH 03/17] ASoC: atmel: atmel-i2s: remove useless initialization Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-29 7:32 ` Codrin.Ciubotariu
2021-03-29 7:32 ` Codrin.Ciubotariu
2021-03-29 7:32 ` Codrin.Ciubotariu
2021-03-26 21:59 ` [PATCH 04/17] ASoC: bcm: cygnus_ssp: " Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 05/17] ASoC: meson: axg-tdmin: remove useless assignment Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 06/17] ASoC: meson: axg-tdmout: " Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 07/17] ASoC: pxa: " Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 08/17] ASoC: sti: sti_uniperif: add missing error check Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-29 8:01 ` Arnaud POULIQUEN
2021-03-29 8:01 ` Arnaud POULIQUEN
2021-03-26 21:59 ` [PATCH 09/17] ASoC: sti: uniperif: align function prototypes Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-29 8:00 ` Arnaud POULIQUEN
2021-03-29 8:00 ` Arnaud POULIQUEN
2021-03-26 21:59 ` [PATCH 10/17] ASoC: stm: stm32_adfsdm: fix snprintf format string Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 11/17] ASoC: sunxi: sun8i-codec: clarify expression Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-29 8:12 ` Maxime Ripard
2021-03-29 8:12 ` Maxime Ripard
2021-03-29 8:12 ` Maxime Ripard
2021-03-26 21:59 ` [PATCH 12/17] ASoC: tegra: tegra20_das: " Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-29 7:14 ` Thierry Reding
2021-03-29 7:14 ` Thierry Reding
2021-03-26 21:59 ` [PATCH 13/17] ASoC: tegra: tegra20_das: align function prototypes Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-29 7:14 ` Thierry Reding
2021-03-29 7:14 ` Thierry Reding
2021-03-26 21:59 ` [PATCH 14/17] ASoC: ti: omap-abe-twl6040: remove useless assignment Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-29 5:52 ` Péter Ujfalusi
2021-03-29 5:52 ` Péter Ujfalusi
2021-03-26 21:59 ` [PATCH 15/17] ASoC: ti: omap-mcsp: remove duplicate test Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-29 5:56 ` Péter Ujfalusi
2021-03-29 5:56 ` Péter Ujfalusi
2021-03-26 21:59 ` [PATCH 16/17] ASoC: ux500: mop500: rename shadowing variable Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 17/17] ASoC: ux500: mop500: align function prototype Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart
2021-04-01 10:16 ` [PATCH 00/17] ASoC: remove cppcheck warnings for multiple SOCs Mark Brown
2021-04-01 10:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326215927.936377-4-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=codrin.ciubotariu@microchip.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.