All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org
Cc: linux-pm@vger.kernel.org, amitk@kernel.org, rui.zhang@intel.com,
	lukasz.luba@arm.com
Subject: [PATCH 2/2] thermal: power_allocator: update once cooling devices when temp is low
Date: Wed, 31 Mar 2021 17:33:52 +0100	[thread overview]
Message-ID: <20210331163352.32416-3-lukasz.luba@arm.com> (raw)
In-Reply-To: <20210331163352.32416-1-lukasz.luba@arm.com>

The cooling device state change generates an event, also when there is no
need, because temperature is low and device is not throttled. Avoid to
unnecessary update the cooling device which means also not sending event.
The cooling device state has not changed because the temperature is still
below the first activation trip point value, so we can do this.
Add a tracking mechanism if the update was triggered and makes sure it
will be done only once when the temperature continue to stay below first
trip point.

Reported-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
 drivers/thermal/gov_power_allocator.c | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
index 0cbd10cab193..6085b6661b8b 100644
--- a/drivers/thermal/gov_power_allocator.c
+++ b/drivers/thermal/gov_power_allocator.c
@@ -65,6 +65,8 @@ static inline s64 div_frac(s64 x, s64 y)
  *					controlling for.
  * @sustainable_power:	Sustainable power (heat) that this thermal zone can
  *			dissipate
+ * @updated:		Keeps track if the framework was updated when the
+ *			temperature went below the first trip point.
  */
 struct power_allocator_params {
 	bool allocated_tzp;
@@ -73,6 +75,7 @@ struct power_allocator_params {
 	int trip_switch_on;
 	int trip_max_desired_temperature;
 	u32 sustainable_power;
+	bool updated;
 };
 
 /**
@@ -395,6 +398,12 @@ static int allocate_power(struct thermal_zone_device *tz,
 
 	mutex_lock(&tz->lock);
 
+	/*
+	 * The temperature has crossed the first trip point, so next time
+	 * when it drops below, update cooling devices and framework.
+	 */
+	params->updated = false;
+
 	num_actors = 0;
 	total_weight = 0;
 	list_for_each_entry(instance, &tz->thermal_instances, tz_node) {
@@ -596,10 +605,18 @@ static void allow_maximum_power(struct thermal_zone_device *tz)
 		 */
 		cdev->ops->get_requested_power(cdev, &req_power);
 
-		instance->cdev->updated = false;
+		if (!params->updated)
+			instance->cdev->updated = false;
+
 		mutex_unlock(&instance->cdev->lock);
-		thermal_cdev_update(instance->cdev);
+
+		if (!params->updated)
+			thermal_cdev_update(instance->cdev);
 	}
+
+	/* Don't send updates next time when temperature is low. */
+	params->updated = true;
+
 	mutex_unlock(&tz->lock);
 }
 
-- 
2.17.1


      parent reply	other threads:[~2021-03-31 16:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31 16:33 [PATCH 0/2] Improve IPA mechanisms in low temperature state Lukasz Luba
2021-03-31 16:33 ` [PATCH 1/2] thermal: power_allocator: maintain the device statistics from going stale Lukasz Luba
2021-04-02 15:54   ` Daniel Lezcano
2021-04-06  8:44     ` Lukasz Luba
2021-04-06 10:16       ` Daniel Lezcano
2021-04-06 10:39         ` Lukasz Luba
2021-04-06 11:24           ` Daniel Lezcano
2021-04-06 12:25             ` Lukasz Luba
2021-04-06 14:32               ` Daniel Lezcano
2021-04-06 18:38                 ` Lukasz Luba
2021-04-06 19:45                   ` Daniel Lezcano
2021-03-31 16:33 ` Lukasz Luba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210331163352.32416-3-lukasz.luba@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.