All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Kostya Porotchkin <kostap@marvell.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	linux-phy@lists.infradead.org
Subject: [PATCH -next] phy: marvell: phy-mvebu-cp11i-utmi needs USB_COMMON
Date: Thu,  1 Apr 2021 14:00:45 -0700	[thread overview]
Message-ID: <20210401210045.23525-1-rdunlap@infradead.org> (raw)

When USB and USB_COMMON are not enabled, phy-mvebu-cp110-utmi
suffers a build error due to a missing interface that is provided
by CONFIG_USB_COMMON, so make the driver depend on USB_COMMON.

ld: drivers/phy/marvell/phy-mvebu-cp110-utmi.o: in function `mvebu_cp110_utmi_phy_probe':
phy-mvebu-cp110-utmi.c:(.text+0x152): undefined reference to `of_usb_get_dr_mode_by_phy'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Kostya Porotchkin <kostap@marvell.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: linux-phy@lists.infradead.org
---
 drivers/phy/marvell/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20210331.orig/drivers/phy/marvell/Kconfig
+++ linux-next-20210331/drivers/phy/marvell/Kconfig
@@ -70,7 +70,7 @@ config PHY_MVEBU_CP110_COMPHY
 config PHY_MVEBU_CP110_UTMI
 	tristate "Marvell CP110 UTMI driver"
 	depends on ARCH_MVEBU || COMPILE_TEST
-	depends on OF
+	depends on OF && USB_COMMON
 	select GENERIC_PHY
 	help
 	  Enable this to support Marvell CP110 UTMI PHY driver.

WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Kostya Porotchkin <kostap@marvell.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	linux-phy@lists.infradead.org
Subject: [PATCH -next] phy: marvell: phy-mvebu-cp11i-utmi needs USB_COMMON
Date: Thu,  1 Apr 2021 14:00:45 -0700	[thread overview]
Message-ID: <20210401210045.23525-1-rdunlap@infradead.org> (raw)

When USB and USB_COMMON are not enabled, phy-mvebu-cp110-utmi
suffers a build error due to a missing interface that is provided
by CONFIG_USB_COMMON, so make the driver depend on USB_COMMON.

ld: drivers/phy/marvell/phy-mvebu-cp110-utmi.o: in function `mvebu_cp110_utmi_phy_probe':
phy-mvebu-cp110-utmi.c:(.text+0x152): undefined reference to `of_usb_get_dr_mode_by_phy'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Kostya Porotchkin <kostap@marvell.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: linux-phy@lists.infradead.org
---
 drivers/phy/marvell/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20210331.orig/drivers/phy/marvell/Kconfig
+++ linux-next-20210331/drivers/phy/marvell/Kconfig
@@ -70,7 +70,7 @@ config PHY_MVEBU_CP110_COMPHY
 config PHY_MVEBU_CP110_UTMI
 	tristate "Marvell CP110 UTMI driver"
 	depends on ARCH_MVEBU || COMPILE_TEST
-	depends on OF
+	depends on OF && USB_COMMON
 	select GENERIC_PHY
 	help
 	  Enable this to support Marvell CP110 UTMI PHY driver.

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

             reply	other threads:[~2021-04-01 21:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01 21:00 Randy Dunlap [this message]
2021-04-01 21:00 ` [PATCH -next] phy: marvell: phy-mvebu-cp11i-utmi needs USB_COMMON Randy Dunlap
2021-04-06  5:04 ` Vinod Koul
2021-04-06  5:04   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210401210045.23525-1-rdunlap@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=kishon@ti.com \
    --cc=kostap@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.