All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <aahringo@redhat.com>
To: stefan@datenfreihafen.org
Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH RESEND wpan 04/15] net: ieee802154: forbid monitor for add llsec key
Date: Sun,  4 Apr 2021 20:30:43 -0400	[thread overview]
Message-ID: <20210405003054.256017-5-aahringo@redhat.com> (raw)
In-Reply-To: <20210405003054.256017-1-aahringo@redhat.com>

This patch forbids to add llsec key for monitor interfaces which we
don't support yet. Otherwise we will access llsec mib which isn't
initialized for monitors.

Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
 net/ieee802154/nl802154.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
index 7815f253c8a3..42a246b6f9cb 100644
--- a/net/ieee802154/nl802154.c
+++ b/net/ieee802154/nl802154.c
@@ -1552,6 +1552,9 @@ static int nl802154_add_llsec_key(struct sk_buff *skb, struct genl_info *info)
 	struct ieee802154_llsec_key_id id = { };
 	u32 commands[NL802154_CMD_FRAME_NR_IDS / 32] = { };
 
+	if (wpan_dev->iftype == NL802154_IFTYPE_MONITOR)
+		return -EOPNOTSUPP;
+
 	if (!info->attrs[NL802154_ATTR_SEC_KEY] ||
 	    nla_parse_nested_deprecated(attrs, NL802154_KEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_KEY], nl802154_key_policy, info->extack))
 		return -EINVAL;
-- 
2.26.3


  parent reply	other threads:[~2021-04-05  0:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05  0:30 [PATCH RESEND wpan 00/15] net: ieee802154: forbid sec params for monitors Alexander Aring
2021-04-05  0:30 ` [PATCH RESEND wpan 01/15] net: ieee802154: nl-mac: fix check on panid Alexander Aring
2021-04-05  0:30 ` [PATCH RESEND wpan 02/15] net: ieee802154: forbid monitor for set llsec params Alexander Aring
2021-04-05  0:30 ` [PATCH RESEND wpan 03/15] net: ieee802154: stop dump llsec keys for monitors Alexander Aring
2021-04-05  0:30 ` Alexander Aring [this message]
2021-04-05  0:30 ` [PATCH RESEND wpan 05/15] net: ieee802154: forbid monitor for del llsec key Alexander Aring
2021-04-05  0:30 ` [PATCH RESEND wpan 06/15] net: ieee802154: stop dump llsec devs for monitors Alexander Aring
2021-04-05  0:30 ` [PATCH RESEND wpan 07/15] net: ieee802154: forbid monitor for add llsec dev Alexander Aring
2021-04-05  0:30 ` [PATCH RESEND wpan 08/15] net: ieee802154: forbid monitor for del " Alexander Aring
2021-04-05  0:30 ` [PATCH RESEND wpan 09/15] net: ieee802154: stop dump llsec devkeys for monitors Alexander Aring
2021-04-05  0:30 ` [PATCH RESEND wpan 10/15] net: ieee802154: forbid monitor for add llsec devkey Alexander Aring
2021-04-05  0:30 ` [PATCH RESEND wpan 11/15] net: ieee802154: forbid monitor for del " Alexander Aring
2021-04-05  0:30 ` [PATCH RESEND wpan 12/15] net: ieee802154: stop dump llsec seclevels for monitors Alexander Aring
2021-04-05  0:30 ` [PATCH RESEND wpan 13/15] net: ieee802154: forbid monitor for add llsec seclevel Alexander Aring
2021-04-05  0:30 ` [PATCH RESEND wpan 14/15] net: ieee802154: forbid monitor for del " Alexander Aring
2021-04-05  0:30 ` [PATCH RESEND wpan 15/15] net: ieee802154: stop dump llsec params for monitors Alexander Aring
2021-04-05 11:51 ` [PATCH RESEND wpan 00/15] net: ieee802154: forbid sec " Alexander Aring
2021-04-06 20:29 ` Stefan Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210405003054.256017-5-aahringo@redhat.com \
    --to=aahringo@redhat.com \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stefan@datenfreihafen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.