From: Dave Chinner <david@fromorbit.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 2/4] xfs: inode fork allocation depends on XFS_IFEXTENT flag
Date: Tue, 6 Apr 2021 21:59:21 +1000 [thread overview]
Message-ID: <20210406115923.1738753-3-david@fromorbit.com> (raw)
In-Reply-To: <20210406115923.1738753-1-david@fromorbit.com>
From: Dave Chinner <dchinner@redhat.com>
Due to confusion on when the XFS_IFEXTENT needs to be set, the
changes in e6a688c33238 ("xfs: initialise attr fork on inode
create") failed to set the flag when initialising the empty
attribute fork at inode creation. Set this flag the same way
xfs_bmap_add_attrfork() does after attry fork allocation.
Fixes: e6a688c33238 ("xfs: initialise attr fork on inode create")
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
fs/xfs/xfs_inode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 3b516ab7f22b..6e3fbe25ef57 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -890,6 +890,7 @@ xfs_init_new_inode(
if (init_xattrs && xfs_sb_version_hasattr(&mp->m_sb)) {
ip->i_d.di_forkoff = xfs_default_attroffset(ip) >> 3;
ip->i_afp = xfs_ifork_alloc(XFS_DINODE_FMT_EXTENTS, 0);
+ ip->i_afp->if_flags = XFS_IFEXTENTS;
}
/*
--
2.31.0
next prev parent reply other threads:[~2021-04-06 11:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 11:59 [PATCH 0/4 v2] xfs: fix eager attr fork init regressions Dave Chinner
2021-04-06 11:59 ` [PATCH 1/4] xfs: eager inode attr fork init needs attr feature awareness Dave Chinner
2021-04-06 15:40 ` Christoph Hellwig
2021-04-06 21:29 ` Dave Chinner
2021-04-07 5:08 ` Christoph Hellwig
2021-04-06 20:07 ` Allison Henderson
2021-04-06 11:59 ` Dave Chinner [this message]
2021-04-06 13:10 ` [PATCH 2/4] xfs: inode fork allocation depends on XFS_IFEXTENT flag Christoph Hellwig
2021-04-06 20:07 ` Allison Henderson
2021-04-06 11:59 ` [PATCH 3/4] xfs: default attr fork size does not handle device inodes Dave Chinner
2021-04-06 20:07 ` Allison Henderson
2021-04-06 11:59 ` [PATCH 4/4] xfs: precalculate default inode attribute offset Dave Chinner
2021-04-06 20:08 ` Allison Henderson
2021-04-06 13:48 ` [PATCH 0/4 v2] xfs: fix eager attr fork init regressions Brian Foster
-- strict thread matches above, loose matches on Subject: below --
2021-03-30 5:30 [PATCH 0/4] " Dave Chinner
2021-03-30 5:30 ` [PATCH 2/4] xfs: inode fork allocation depends on XFS_IFEXTENT flag Dave Chinner
2021-03-30 18:06 ` Darrick J. Wong
2021-03-30 21:40 ` Dave Chinner
2021-04-02 7:02 ` Christoph Hellwig
2021-04-03 22:21 ` Dave Chinner
2021-04-04 3:25 ` Darrick J. Wong
2021-04-02 7:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406115923.1738753-3-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.