From: "Mirela Rabulea (OSS)" <mirela.rabulea@oss.nxp.com> To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl Cc: linux-imx@nxp.com, linux-media@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robert.chiras@nxp.com, laurentiu.palcu@nxp.com, Mirela Rabulea <mirela.rabulea@nxp.com> Subject: [PATCH] media: imx-jpeg: Fix double free in mxc_jpeg_remove Date: Tue, 6 Apr 2021 20:34:28 +0300 [thread overview] Message-ID: <20210406173428.19283-1-mirela.rabulea@oss.nxp.com> (raw) From: Mirela Rabulea <mirela.rabulea@nxp.com> The video_unregister_device already calls video_device_release, so remove video_device_release, to avoid a double free, when removing the module. This showed up in a repeated rmmod/insmod scenario. Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com> --- drivers/media/platform/imx-jpeg/mxc-jpeg.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/imx-jpeg/mxc-jpeg.c index 2d29558f1864..ca1b7e8c65f4 100644 --- a/drivers/media/platform/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/imx-jpeg/mxc-jpeg.c @@ -2099,7 +2099,6 @@ static int mxc_jpeg_remove(struct platform_device *pdev) mxc_jpeg_free_slot_data(jpeg, slot); video_unregister_device(jpeg->dec_vdev); - video_device_release(jpeg->dec_vdev); v4l2_m2m_release(jpeg->m2m_dev); v4l2_device_unregister(&jpeg->v4l2_dev); mxc_jpeg_detach_pm_domains(jpeg); -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: "Mirela Rabulea (OSS)" <mirela.rabulea@oss.nxp.com> To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl Cc: linux-imx@nxp.com, linux-media@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robert.chiras@nxp.com, laurentiu.palcu@nxp.com, Mirela Rabulea <mirela.rabulea@nxp.com> Subject: [PATCH] media: imx-jpeg: Fix double free in mxc_jpeg_remove Date: Tue, 6 Apr 2021 20:34:28 +0300 [thread overview] Message-ID: <20210406173428.19283-1-mirela.rabulea@oss.nxp.com> (raw) From: Mirela Rabulea <mirela.rabulea@nxp.com> The video_unregister_device already calls video_device_release, so remove video_device_release, to avoid a double free, when removing the module. This showed up in a repeated rmmod/insmod scenario. Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com> --- drivers/media/platform/imx-jpeg/mxc-jpeg.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/imx-jpeg/mxc-jpeg.c index 2d29558f1864..ca1b7e8c65f4 100644 --- a/drivers/media/platform/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/imx-jpeg/mxc-jpeg.c @@ -2099,7 +2099,6 @@ static int mxc_jpeg_remove(struct platform_device *pdev) mxc_jpeg_free_slot_data(jpeg, slot); video_unregister_device(jpeg->dec_vdev); - video_device_release(jpeg->dec_vdev); v4l2_m2m_release(jpeg->m2m_dev); v4l2_device_unregister(&jpeg->v4l2_dev); mxc_jpeg_detach_pm_domains(jpeg); -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-04-06 17:34 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-06 17:34 Mirela Rabulea (OSS) [this message] 2021-04-06 17:34 ` [PATCH] media: imx-jpeg: Fix double free in mxc_jpeg_remove Mirela Rabulea (OSS)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210406173428.19283-1-mirela.rabulea@oss.nxp.com \ --to=mirela.rabulea@oss.nxp.com \ --cc=festevam@gmail.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=kernel@pengutronix.de \ --cc=laurentiu.palcu@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=mirela.rabulea@nxp.com \ --cc=robert.chiras@nxp.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.