From: Igor Pylypiv <ipylypiv@google.com>
To: Jack Wang <jinpu.wang@cloud.ionos.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Vishakha Channapattan <vishakhavc@google.com>,
Akshat Jain <akshatzen@google.com>,
Jolly Shah <jollys@google.com>, Yu Zheng <yuuzheng@google.com>,
linux-scsi@vger.kernel.org, Viswas G <Viswas.G@microchip.com>,
Deepak Ukey <deepak.ukey@microchip.com>,
Igor Pylypiv <ipylypiv@google.com>
Subject: [PATCH v2 1/2] scsi: pm80xx: Increase timeout for pm80xx mpi_uninit_check()
Date: Tue, 6 Apr 2021 11:05:33 -0700 [thread overview]
Message-ID: <20210406180534.1924345-2-ipylypiv@google.com> (raw)
In-Reply-To: <20210406180534.1924345-1-ipylypiv@google.com>
The mpi_uninit_check() takes longer for inbound doorbell register to be
cleared. Increased the timeout substantially so that the driver does not
fail to load.
Previously, the inbound doorbell wait time was mistakenly increased in
the mpi_init_check() instead of the mpi_uninit_check(). It is okay to
leave the mpi_init_check() wait time as is as these are timeout values
and if there is a failure, waiting longer is not an issue.
Fixes: e90e236250e9 ("scsi: pm80xx: Increase timeout for pm80xx
mpi_uninit_check")
Reviewed-by: Vishakha Channapattan <vishakhavc@google.com>
Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
---
drivers/scsi/pm8001/pm80xx_hwi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
index 84315560e8e1..c6b0834e3806 100644
--- a/drivers/scsi/pm8001/pm80xx_hwi.c
+++ b/drivers/scsi/pm8001/pm80xx_hwi.c
@@ -1502,9 +1502,9 @@ static int mpi_uninit_check(struct pm8001_hba_info *pm8001_ha)
/* wait until Inbound DoorBell Clear Register toggled */
if (IS_SPCV_12G(pm8001_ha->pdev)) {
- max_wait_count = 4 * 1000 * 1000;/* 4 sec */
+ max_wait_count = 30 * 1000 * 1000; /* 30 sec */
} else {
- max_wait_count = 2 * 1000 * 1000;/* 2 sec */
+ max_wait_count = 15 * 1000 * 1000; /* 15 sec */
}
do {
udelay(1);
--
2.31.1.295.g9ea45b61b8-goog
next prev parent reply other threads:[~2021-04-06 18:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 18:05 [PATCH v2 0/2] pm80xx mpi_uninit_check() fixes Igor Pylypiv
2021-04-06 18:05 ` Igor Pylypiv [this message]
2021-04-06 18:05 ` [PATCH v2 2/2] scsi: pm80xx: Remove busy wait from mpi_uninit_check() Igor Pylypiv
2021-04-16 2:51 ` [PATCH v2 0/2] pm80xx mpi_uninit_check() fixes Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406180534.1924345-2-ipylypiv@google.com \
--to=ipylypiv@google.com \
--cc=Viswas.G@microchip.com \
--cc=akshatzen@google.com \
--cc=deepak.ukey@microchip.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=jollys@google.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=vishakhavc@google.com \
--cc=yuuzheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.